Re: [PR] feat(explore-chart-panel): darken the color of vertical split for better recognizability [superset]

["msyavuz (via GitHub)" <gi...@apache.org>]

msyavuz commented on code in PR #38086:
URL: https://github.com/apache/superset/pull/38086#discussion_r2882836033


##########
superset-frontend/src/explore/components/ExploreChartPanel/index.tsx:
##########
@@ -113,8 +113,10 @@ const Styles = styled.div<{ showSplite: boolean }>`
   }
 
   .gutter {
-    border-top: 1px solid ${({ theme }) => theme.colorSplit};
-    border-bottom: 1px solid ${({ theme }) => theme.colorSplit};
+    border-top: 1px solid
+      color-mix(in srgb, ${({ theme }) => theme.colorSplit}, black 15%);
+    border-bottom: 1px solid
+      color-mix(in srgb, ${({ theme }) => theme.colorSplit}, black 15%);

Review Comment:
   Per @alexandrusoare:
   > What happens when you have another theme config with colorSplit? 
   
   I think it looks better as a customizaiton but maybe we should change this in theme default instead



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org