You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/23 10:14:38 UTC

[GitHub] [pulsar] eolivelli commented on a change in pull request #11039: fix flaky AdminApiTest

eolivelli commented on a change in pull request #11039:
URL: https://github.com/apache/pulsar/pull/11039#discussion_r656955151



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest.java
##########
@@ -1219,7 +1219,9 @@ public void testDeleteTenantForcefully() throws Exception {
 
         // delete tenant forcefully
         admin.tenants().deleteTenant(tenant, true);
-        assertFalse(admin.tenants().getTenants().contains(tenant));

Review comment:
       fixing the problem this way is somehow closing the eyes in front of a problem.
   
   if I delete a tenant I would like that if I run "pulsar-admin tenants list" the tenant is no more there
   
   the "deleteTenant" operation is blocking and it must block until the operation succeeds and the system has a consistent view of the status of a such a "big entity".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org