[jira] [Comment Edited] (HBASE-19761) Fix Checkstyle errors in hbase-zookeeper

["Jan Hentschel (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-19761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495029#comment-16495029 ] 

Jan Hentschel edited comment on HBASE-19761 at 5/30/18 11:07 AM:
-----------------------------------------------------------------

[~maoling] Can you check if Checkstyle gets executed at the {{package}} phase? I remember a discussion some time ago on when Checkstyle should be executed, either the {{package}} or the {{install}} phase. I think the {{package}} phase won. Just compared it to the *hbase-thrift* module. It has the following Checkstyle definition:

{code}
<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-checkstyle-plugin</artifactId>
    <configuration>
        <failOnViolation>true</failOnViolation>
    </configuration>
</plugin>
{code}

With the definition for the plugin I gave you it should be part of the {{install}} phase. Can you double-check it with the plugin definition as above?


was (Author: jan hentschel):
[~maoling] Can you check if Checkstyle gets executed at the {{package}} phase? I remember a discussion some time ago on when Checkstyle should be executed, either the {{package}} or the {{install}} phase. I think the {{package}} phase won. Just compared it to the *hbase-thrift* module. It has the following Checkstyle definition:

{code}
<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-checkstyle-plugin</artifactId>
    <configuration>
        <failOnViolation>true</failOnViolation>
    </configuration>
</plugin>
{çode}

With the definition for the plugin I gave you it should be part of the {{install}} phase. Can you double-check it with the plugin definition as above?

> Fix Checkstyle errors in hbase-zookeeper
> ----------------------------------------
>
>                 Key: HBASE-19761
>                 URL: https://issues.apache.org/jira/browse/HBASE-19761
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Jan Hentschel
>            Assignee: maoling
>            Priority: Minor
>         Attachments: HBASE-19761-master-v0.patch, HBASE-19761-master-v1.patch, HBASE-19761-master-v2.patch, HBASE-19761-master-v3.patch, HBASE-19761.master.001.patch, HBASE-19761.master.002.patch
>
>
> Fix the remaining Checkstyle errors in the *hbase-zookeeper* module and enable Checkstyle to fail on violations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)