You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Krishna Kumar (JIRA)" <ji...@apache.org> on 2011/01/24 08:16:43 UTC
[jira] Created: (HIVE-1924) checkformat implementations leak
handles
checkformat implementations leak handles
----------------------------------------
Key: HIVE-1924
URL: https://issues.apache.org/jira/browse/HIVE-1924
Project: Hive
Issue Type: Bug
Components: Query Processor
Reporter: Krishna Kumar
In validateInput, Reader constructors of SequenceFile and RCFile throw exceptions to indicate that the format is incorrect, but the close is not called in a finally block.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1924) checkformat implementations leak
handles
Posted by "Krishna Kumar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Krishna Kumar updated HIVE-1924:
--------------------------------
Status: Open (was: Patch Available)
Hmm, The patch is not correct. Setting hive.checkformat=false does seem to stop the leaks though. Investigating...
> checkformat implementations leak handles
> ----------------------------------------
>
> Key: HIVE-1924
> URL: https://issues.apache.org/jira/browse/HIVE-1924
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Krishna Kumar
> Attachments: HIVE.1924.patch.txt
>
>
> In validateInput, Reader constructors of SequenceFile and RCFile throw exceptions to indicate that the format is incorrect, but the close is not called in a finally block.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HIVE-1924) checkformat implementations leak
handles
Posted by "Krishna Kumar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Krishna Kumar resolved HIVE-1924.
---------------------------------
Resolution: Duplicate
Problem referenced in HADOOP-5476 and HIVE-1185
> checkformat implementations leak handles
> ----------------------------------------
>
> Key: HIVE-1924
> URL: https://issues.apache.org/jira/browse/HIVE-1924
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Krishna Kumar
> Attachments: HIVE.1924.patch.txt
>
>
> In validateInput, Reader constructors of SequenceFile and RCFile throw exceptions to indicate that the format is incorrect, but the close is not called in a finally block.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1924) checkformat implementations leak
handles
Posted by "Krishna Kumar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Krishna Kumar updated HIVE-1924:
--------------------------------
Status: Patch Available (was: Open)
Not sure how to test this automatically, since the readers are transient. The way I actually tested is by
- running on a nfs mounted directory (since nfs creates .nfsxxxxxx files for open files which have been deleted)
- pausing the code after a load command (with conf hive. is executed
- using lsof to list open files by the process
> checkformat implementations leak handles
> ----------------------------------------
>
> Key: HIVE-1924
> URL: https://issues.apache.org/jira/browse/HIVE-1924
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Krishna Kumar
>
> In validateInput, Reader constructors of SequenceFile and RCFile throw exceptions to indicate that the format is incorrect, but the close is not called in a finally block.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1924) checkformat implementations leak
handles
Posted by "Krishna Kumar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Krishna Kumar updated HIVE-1924:
--------------------------------
Attachment: HIVE.1924.patch.txt
Tested only manually with hive.fileformat.check set to true
> checkformat implementations leak handles
> ----------------------------------------
>
> Key: HIVE-1924
> URL: https://issues.apache.org/jira/browse/HIVE-1924
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Krishna Kumar
> Attachments: HIVE.1924.patch.txt
>
>
> In validateInput, Reader constructors of SequenceFile and RCFile throw exceptions to indicate that the format is incorrect, but the close is not called in a finally block.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.