[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8758: driver/uart_rpmsg: Passthrough data by default

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #8758:
URL: https://github.com/apache/nuttx/pull/8758#discussion_r1128983729


##########
drivers/serial/uart_rpmsg.c:
##########
@@ -412,8 +412,14 @@ int uart_rpmsg_init(FAR const char *cpuname, FAR const char *devname,
       return ret;
     }
 
+  /* Ignore the `isconsole` to passthrough all UART data,
+   * since the most common usage of rpmsg uart is to communicate with cu
+   * in other processor core, should not do CRLF convertion and ECHO.
+   * Note: you can also change this behavior by termios.
+   */
+
   dev->ops       = &g_uart_rpmsg_ops;
-  dev->isconsole = isconsole;

Review Comment:
   let remove isconsole argument from uart_rpmsg_init, or modify the caller to pass false.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org