You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "davisusanibar (via GitHub)" <gi...@apache.org> on 2023/04/21 20:28:48 UTC
[GitHub] [arrow] davisusanibar opened a new pull request, #35277: feat: enable GCS on macosx
davisusanibar opened a new pull request, #35277:
URL: https://github.com/apache/arrow/pull/35277
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
Enables GCS on MacOS when building the Arrow Dataset for Java.
### What changes are included in this PR?
CI build to enable GCS
### Are these changes tested?
````java
import org.apache.arrow.dataset.file.FileFormat;
import org.apache.arrow.dataset.file.FileSystemDatasetFactory;
import org.apache.arrow.dataset.jni.NativeMemoryPool;
import org.apache.arrow.dataset.scanner.ScanOptions;
import org.apache.arrow.dataset.scanner.Scanner;
import org.apache.arrow.dataset.source.Dataset;
import org.apache.arrow.dataset.source.DatasetFactory;
import org.apache.arrow.memory.BufferAllocator;
import org.apache.arrow.memory.RootAllocator;
import org.apache.arrow.vector.ipc.ArrowReader;
import org.apache.arrow.vector.types.pojo.Schema;
public class Test {
public static void main(String[] args) {
String uri = "gs://anonymous@voltrondata-labs-datasets/nyc-taxi-tiny/year=2022/month=2/part-0.parquet"; // Google Cloud Storage
ScanOptions options = new ScanOptions(/*batchSize*/ 32768);
try (
BufferAllocator allocator = new RootAllocator();
DatasetFactory datasetFactory = new FileSystemDatasetFactory(allocator, NativeMemoryPool.getDefault(), FileFormat.PARQUET, uri);
Dataset dataset = datasetFactory.finish();
Scanner scanner = dataset.newScan(options);
ArrowReader reader = scanner.scanBatches()
) {
Schema schema = scanner.schema();
System.out.println(schema); // Schema<vendor_name: Utf8, pickup_datetime: Timestamp(MILLISECOND, null), dropoff_datetime: Timestamp(MILLISECOND, null), passenger_count: Int(64, true), trip_distance: FloatingPoint(DOUBLE), pickup_longitude: FloatingPoint(DOUBLE), pickup_latitude: FloatingPoint(DOUBLE), rate_code: Utf8, store_and_fwd: Utf8, dropoff_longitude: FloatingPoint(DOUBLE), dropoff_latitude: FloatingPoint(DOUBLE), payment_type: Utf8, fare_amount: FloatingPoint(DOUBLE), extra: FloatingPoint(DOUBLE), mta_tax: FloatingPoint(DOUBLE), tip_amount: FloatingPoint(DOUBLE), tolls_amount: FloatingPoint(DOUBLE), total_amount: FloatingPoint(DOUBLE), improvement_surcharge: FloatingPoint(DOUBLE), congestion_surcharge: FloatingPoint(DOUBLE), pickup_location_id: Int(64, true), dropoff_location_id: Int(64, true)>
while (reader.loadNextBatch()) {
System.out.println("RowCount: " + reader.getVectorSchemaRoot().getRowCount()); //2979
}
} catch (Exception e) {
e.printStackTrace();
}
}
}
````
### Are there any user-facing changes?
No
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1520466232
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on a diff in pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar commented on code in PR #35277:
URL: https://github.com/apache/arrow/pull/35277#discussion_r1218582466
##########
ci/scripts/java_jni_macos_build.sh:
##########
@@ -75,15 +77,18 @@ cmake \
-DARROW_DEPENDENCY_USE_SHARED=OFF \
-DARROW_GANDIVA=${ARROW_GANDIVA} \
-DARROW_GANDIVA_STATIC_LIBSTDCPP=ON \
+ -DARROW_GCS=${ARROW_GCS} \
-DARROW_ORC=${ARROW_ORC} \
-DARROW_PARQUET=${ARROW_PARQUET} \
-DARROW_S3=${ARROW_S3} \
-DARROW_USE_CCACHE=${ARROW_USE_CCACHE} \
+ -DARROW_WITH_SNAPPY=ON \
Review Comment:
At Arrow build, ARROW_WITH_SNAPPY is not added by default and GCS use that codec by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1592414148
Hmm. It's not reproduced on local...
It seems that the error message show that we need to add Abseil's CRC related modules to https://github.com/apache/arrow/blob/main/cpp/cmake_modules/ThirdpartyToolchain.cmake#L2856-L3756 .
BTW, can we use 20230125.3 https://github.com/abseil/abseil-cpp/releases/tag/20230125.3 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1520470618
Revision: d6da99d68488565df82cca8a8e0d5e2e301955e2
Submitted crossbow builds: [ursacomputing/crossbow @ actions-fa53b98180](https://github.com/ursacomputing/crossbow/branches/all?query=actions-fa53b98180)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4788637584/jobs/8515506097)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35274: [Java][CI] Enable GCS on MacOS [arrow]
Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar closed pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
URL: https://github.com/apache/arrow/pull/35277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on a diff in pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar commented on code in PR #35277:
URL: https://github.com/apache/arrow/pull/35277#discussion_r1218575213
##########
java/Brewfile:
##########
@@ -17,3 +17,4 @@
brew "openjdk@11"
brew "sccache"
+brew "curl"
Review Comment:
Juste deleted, that was added for testing purpose that at the end we add CURL_ROOT on the github.yml file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1577867444
Revision: e1db91b809315fe93c899435df16c6edd9de468f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-7a70b20d3a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7a70b20d3a)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/5184422363/jobs/9343305987)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #35277:
URL: https://github.com/apache/arrow/pull/35277#discussion_r1174235099
##########
cpp/build-support/run-test.sh:
##########
@@ -60,6 +60,9 @@ rm -f $LOGFILE $LOGFILE.gz
pipe_cmd=cat
+# Install the gcs testbench
+sh ../../../../../ci/scripts/install_gcs_testbench.sh default
Review Comment:
I think this is quite confusing without following the previous code in detail. I think doing this in relation to `$ROOT` would make it a bit clearer?
```suggestion
sh $ROOT/../ci/scripts/install_gcs_testbench.sh default
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1577255893
Revision: 2213140d42f0ec688d958ee0c7b114a1f452f3f7
Submitted crossbow builds: [ursacomputing/crossbow @ actions-4f5f8b3ee8](https://github.com/ursacomputing/crossbow/branches/all?query=actions-4f5f8b3ee8)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/5180494844/jobs/9334745113)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on a diff in pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar commented on code in PR #35277:
URL: https://github.com/apache/arrow/pull/35277#discussion_r1176428950
##########
cpp/thirdparty/versions.txt:
##########
@@ -23,8 +23,8 @@
# `DEPENDENCIES` array (see the comment on top of the declaration for the
# format).
-ARROW_ABSL_BUILD_VERSION=20211102.0
-ARROW_ABSL_BUILD_SHA256_CHECKSUM=dcf71b9cba8dc0ca9940c4b316a0c796be8fab42b070bb6b7cab62b48f0e66c4
+ARROW_ABSL_BUILD_VERSION=20230125.2
Review Comment:
> I'm not sure we can just update this without also possibly updating gRPC/Google Cloud SDK
Base on current unit test, it appears it will continue working. Do you recommend also to update that independently of current results? Or do you have some test that I could run to validate that before changes requested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a diff in pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #35277:
URL: https://github.com/apache/arrow/pull/35277#discussion_r1195253695
##########
java/Brewfile:
##########
@@ -17,3 +17,4 @@
brew "openjdk@11"
brew "sccache"
+brew "curl"
Review Comment:
Perhaps keep this file in alphabetical order?
##########
cpp/build-support/run-test.sh:
##########
@@ -60,6 +60,9 @@ rm -f $LOGFILE $LOGFILE.gz
pipe_cmd=cat
+# Install the gcs testbench
+sh $ROOT/../ci/scripts/install_gcs_testbench.sh default
Review Comment:
I don't think we should add this here. Why do you need this change?
##########
ci/scripts/java_jni_macos_build.sh:
##########
@@ -75,15 +77,18 @@ cmake \
-DARROW_DEPENDENCY_USE_SHARED=OFF \
-DARROW_GANDIVA=${ARROW_GANDIVA} \
-DARROW_GANDIVA_STATIC_LIBSTDCPP=ON \
+ -DARROW_GCS=${ARROW_GCS} \
-DARROW_ORC=${ARROW_ORC} \
-DARROW_PARQUET=${ARROW_PARQUET} \
-DARROW_S3=${ARROW_S3} \
-DARROW_USE_CCACHE=${ARROW_USE_CCACHE} \
+ -DARROW_WITH_SNAPPY=ON \
Review Comment:
Why does Snappy need to be enabled here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #35277:
URL: https://github.com/apache/arrow/pull/35277#discussion_r1175855549
##########
cpp/thirdparty/versions.txt:
##########
@@ -23,8 +23,8 @@
# `DEPENDENCIES` array (see the comment on top of the declaration for the
# format).
-ARROW_ABSL_BUILD_VERSION=20211102.0
-ARROW_ABSL_BUILD_SHA256_CHECKSUM=dcf71b9cba8dc0ca9940c4b316a0c796be8fab42b070bb6b7cab62b48f0e66c4
+ARROW_ABSL_BUILD_VERSION=20230125.2
Review Comment:
I'm not sure we can just update this without also possibly updating gRPC/Google Cloud SDK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1518381073
Revision: a05f58e9183432b7b391b4dc7968f0716557fe03
Submitted crossbow builds: [ursacomputing/crossbow @ actions-24f328b4cf](https://github.com/ursacomputing/crossbow/branches/all?query=actions-24f328b4cf)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4769200161/jobs/8479352642)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1577864852
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1592326022
@lidavidm do you have some insight about what I could review to solve this error https://github.com/apache/arrow/actions/runs/5274483912/jobs/9538989549?pr=35277:
```
[70/122] Generating arrow-flight-glib/ArrowFlight-1.0.gir with a custom command (wrapped by meson to set env)
FAILED: arrow-flight-glib/ArrowFlight-1.0.gir
env PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/build/c_glib/meson-uninstalled /usr/bin/g-ir-scanner --quiet --no-libtool --namespace=ArrowFlight --nsversion=1.0 --warn-all --output arrow-flight-glib/ArrowFlight-1.0.gir --c-include=arrow-flight-glib/arrow-flight-glib.h --warn-all --include-uninstalled=./arrow-glib/Arrow-1.0.gir -I/arrow/c_glib/arrow-flight-glib -I/build/c_glib/arrow-flight-glib -I/arrow/c_glib/. -I/build/c_glib/. --filelist=/build/c_glib/arrow-flight-glib/libarrow-flight-glib.so.1300.0.0.p/ArrowFlight_1.0_gir_filelist --include=Arrow-1.0 --symbol-prefix=gaflight --identifier-prefix=GAFlight --pkg-export=arrow-flight-glib --cflags-begin -I/arrow/c_glib/. -I/build/c_glib/. -I/usr/local/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/gobject-introspection-1.0 -DARROW_NO_DEPRECATED_API --cflags-end --add-include-path=/build/c_glib/arrow-glib --add-include-path=/usr/share/gir-1.0 -L/build/c_glib/arrow-flight-glib --library arro
w-flight-glib -L/build/c_glib/arrow-glib -L/usr/local/lib -L/usr/local/lib --extra-library=arrow_flight --extra-library=arrow --extra-library=arrow_acero --extra-library=gobject-2.0 --extra-library=glib-2.0 --extra-library=girepository-1.0 --sources-top-dirs /arrow/c_glib/ --sources-top-dirs /build/c_glib/ --warn-error
/usr/bin/ld: /usr/local/lib/libarrow_flight.so: undefined reference to `absl::lts_20230125::crc_internal::CrcCordState::CrcCordState()'
/usr/bin/ld: /usr/local/lib/libarrow_flight.so: undefined reference to `absl::lts_20230125::crc_internal::CrcCordState::operator=(absl::lts_20230125::crc_internal::CrcCordState&&)'
/usr/bin/ld: /usr/local/lib/libarrow_flight.so: undefined reference to `absl::lts_20230125::crc_internal::CrcCordState::CrcCordState(absl::lts_20230125::crc_internal::CrcCordState&&)'
/usr/bin/ld: /usr/local/lib/libarrow_flight.so: undefined reference to `absl::lts_20230125::base_internal::StrError[abi:cxx11](int)'
/usr/bin/ld: /usr/local/lib/libarrow_flight.so: undefined reference to `absl::lts_20230125::crc_internal::CrcCordState::~CrcCordState()'
/usr/bin/ld: /usr/local/lib/libarrow_flight.so: undefined reference to `absl::lts_20230125::crc_internal::CrcCordState::Checksum() const'
collect2: error: ld returned 1 exit status
linking of temporary binary failed: Command '['x86_64-linux-gnu-gcc', '-pthread', '-o', '/build/c_glib/tmp-introspectci4byn1o/ArrowFlight-1.0', '-DARROW_NO_DEPRECATED_API', '/build/c_glib/tmp-introspectci4byn1o/ArrowFlight-1.0.o', '-L.', '-Wl,-rpath,.', '-Wl,--no-as-needed', '-L/build/c_glib/arrow-flight-glib', '-Wl,-rpath,/build/c_glib/arrow-flight-glib', '-L/build/c_glib/arrow-glib', '-Wl,-rpath,/build/c_glib/arrow-glib', '-L/usr/local/lib', '-Wl,-rpath,/usr/local/lib', '-L/usr/local/lib', '-Wl,-rpath,/usr/local/lib', '-larrow-flight-glib', '-larrow_flight', '-larrow', '-larrow_acero', '-lgobject-2.0', '-lglib-2.0', '-lgirepository-1.0', '-lgio-2.0', '-lgobject-2.0', '-Wl,--export-dynamic', '-lgmodule-2.0', '-pthread', '-lglib-2.0']' returned non-zero exit status 1.
[71/122] Compiling C++ object gandiva-glib/libgandiva-glib.so.1300.0.0.p/expression.cpp.o
[72/122] Compiling C++ object arrow-flight-sql-glib/libarrow-flight-sql-glib.so.1300.0.0.p/server.cpp.o
ninja: build stopped: subcommand failed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1518514785
I am seeing error on MacOS aarch_64 with message `dyld: lazy symbol binding failed: Symbol not found: _curl_multi_poll` @kou / @assignUser Do you have any idea about the reason of?
```c++
Running arrow-gcsfs-test, redirecting output into /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/cpp-build/cpp/build/test-logs/arrow-gcsfs-test.txt (attempt 1/1)
/Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/cpp/build-support/run-test.sh: line 91: 33793 Abort trap: 6 $TEST_EXECUTABLE "$@" > $LOGFILE.raw 2>&1
INFO:werkzeug:WARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead.
* Running on http://localhost:63593
INFO:werkzeug:Press CTRL+C to quit
INFO:werkzeug: * Restarting with stat
Running main() from /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/cpp-build/cpp/googletest_ep-prefix/src/googletest_ep/googletest/src/gtest_main.cc
[==========] Running 99 tests from 3 test suites.
[----------] Global test environment set-up.
[----------] 26 tests from TestGCSFSGeneric
[ RUN ] TestGCSFSGeneric.Empty
dyld: lazy symbol binding failed: Symbol not found: _curl_multi_poll
Referenced from: /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/cpp-build/cpp/release/arrow-gcsfs-test
Expected in: /usr/lib/libcurl.4.dylib
dyld: Symbol not found: _curl_multi_poll
Referenced from: /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/cpp-build/cpp/release/arrow-gcsfs-test
Expected in: /usr/lib/libcurl.4.dylib
...
...
Total Test time (real) = 121.27 sec
The following tests FAILED:
61 - arrow-gcsfs-test (Failed)
Errors while running CTest
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35277: feat: enable GCS on macosx
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1518302920
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1619140922
@lidavidm please could you help me to move this PR to draft?, there are some problems on the CI that I need to test and probably need to call it again and again. Thank you in advance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35274: [Java][CI] Enable GCS on MacOS [arrow]
Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1978750252
In order to define a better alternative solution, the current pull request has been closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35274: [Java][CI] Enable GCS on MacOS [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-2501748816
:warning: GitHub issue #35274 **has no components**, please add labels for components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1614836666
Revision: 828d6892222623bedc0b11f01edf26cfa6206d8e
Submitted crossbow builds: [ursacomputing/crossbow @ actions-221f6dfca1](https://github.com/ursacomputing/crossbow/branches/all?query=actions-221f6dfca1)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/5424633534/jobs/9864268918)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1614833936
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1705981872
Revision: 9acf7dca0fcc9c2e226e3273a602690b64edcf9b
Submitted crossbow builds: [ursacomputing/crossbow @ actions-8d83452f61](https://github.com/ursacomputing/crossbow/branches/all?query=actions-8d83452f61)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/6080693539/job/16495036001)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1541302508
This should fix the m1 issues
```
--- a/dev/tasks/java-jars/github.yml
+++ b/dev/tasks/java-jars/github.yml
@@ -108,6 +108,7 @@ jobs:
set -e
# make brew Java available to CMake
if [ "{{ arch }}" = "aarch_64" ]; then
+ export CURL_ROOT=$(brew --prefix curl)
export JAVA_HOME=$(brew --prefix openjdk@11)/libexec/openjdk.jdk/Contents/Home
fi
arrow/ci/scripts/java_jni_macos_build.sh \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1549788514
@davisusanibar Can you also rebase this PR on git main?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1621195750
Revision: 1deb06be2911d0bba958f177f05c2982d6c48f3a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-abbebdf72b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-abbebdf72b)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/5461602490/jobs/9939819350)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1621191076
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1636579740
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1577253087
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1636580708
Revision: 480a8960c055f688f819216dbba9f052fea039f8
Submitted crossbow builds: [ursacomputing/crossbow @ actions-54eb93bef5](https://github.com/ursacomputing/crossbow/branches/all?query=actions-54eb93bef5)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/5559398140/jobs/10155468972)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1546392324
> Revision: [26d808d](https://github.com/apache/arrow/commit/26d808d39314845889b179d53b90367d1ae4d119)
>
> Submitted crossbow builds: [ursacomputing/crossbow @ actions-ef819b2719](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ef819b2719)
>
> Task Status
> java-jars [](https://github.com/ursacomputing/crossbow/actions/runs/4961934231/jobs/8879348028)
Thank you @assignUser !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1518377872
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1518515933
I think the installed curl version is too old. It looks like libcurl 4 is installed but multi pool was introduced in 7 https://curl.se/libcurl/c/curl_multi_poll.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1619164902
> You can find the "Convert to draft" link in the right side bar.
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1705980047
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1546122932
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1546125120
Revision: 26d808d39314845889b179d53b90367d1ae4d119
Submitted crossbow builds: [ursacomputing/crossbow @ actions-ef819b2719](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ef819b2719)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4961934231/jobs/8879348028)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #35277:
URL: https://github.com/apache/arrow/pull/35277#discussion_r1177415761
##########
cpp/thirdparty/versions.txt:
##########
@@ -23,8 +23,8 @@
# `DEPENDENCIES` array (see the comment on top of the declaration for the
# format).
-ARROW_ABSL_BUILD_VERSION=20211102.0
-ARROW_ABSL_BUILD_SHA256_CHECKSUM=dcf71b9cba8dc0ca9940c4b316a0c796be8fab42b070bb6b7cab62b48f0e66c4
+ARROW_ABSL_BUILD_VERSION=20230125.2
Review Comment:
Hmm, seems Abseil promises compatibility now. So it looks like we're safe here, at least it compiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1518307399
:warning: GitHub issue #35274 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1518307371
* Closes: #35274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on a diff in pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar commented on code in PR #35277:
URL: https://github.com/apache/arrow/pull/35277#discussion_r1218580829
##########
cpp/build-support/run-test.sh:
##########
@@ -60,6 +60,9 @@ rm -f $LOGFILE $LOGFILE.gz
pipe_cmd=cat
+# Install the gcs testbench
+sh $ROOT/../ci/scripts/install_gcs_testbench.sh default
Review Comment:
If we enable ARROW_GCS some test need some software base that is installed by this shell. Just moved inside of MacOS scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #35277:
URL: https://github.com/apache/arrow/pull/35277#discussion_r1218624951
##########
ci/scripts/java_jni_macos_build.sh:
##########
@@ -75,15 +77,18 @@ cmake \
-DARROW_DEPENDENCY_USE_SHARED=OFF \
-DARROW_GANDIVA=${ARROW_GANDIVA} \
-DARROW_GANDIVA_STATIC_LIBSTDCPP=ON \
+ -DARROW_GCS=${ARROW_GCS} \
-DARROW_ORC=${ARROW_ORC} \
-DARROW_PARQUET=${ARROW_PARQUET} \
-DARROW_S3=${ARROW_S3} \
-DARROW_USE_CCACHE=${ARROW_USE_CCACHE} \
+ -DARROW_WITH_SNAPPY=ON \
Review Comment:
If `ARROW_WITH_SNAPPY` is required for `ARROW_GCS`, could you enable `ARROW_WITH_SNAPPY` automatically with `ARROW_GCS`?
```diff
diff --git a/cpp/cmake_modules/DefineOptions.cmake b/cpp/cmake_modules/DefineOptions.cmake
index e2ad9e7a8..247a190ae 100644
--- a/cpp/cmake_modules/DefineOptions.cmake
+++ b/cpp/cmake_modules/DefineOptions.cmake
@@ -335,7 +335,10 @@ takes precedence over ccache if a storage backend is configured" ON)
ARROW_WITH_UTF8PROC)
define_option(ARROW_GCS
- "Build Arrow with GCS support (requires the GCloud SDK for C++)" OFF)
+ "Build Arrow with GCS support (requires the GCloud SDK for C++)"
+ OFF
+ DEPENDS
+ ARROW_WITH_SNAPPY)
define_option(ARROW_HDFS "Build the Arrow HDFS bridge" OFF)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35277:
URL: https://github.com/apache/arrow/pull/35277#issuecomment-1619157999
You can find the "Convert to draft" link in the right side bar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org