You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/02/25 22:37:13 UTC

[GitHub] [tvm] mei-ye commented on a change in pull request #10391: [vulkan] Add integer dot product (4xint8, 4xuint8) tensorization for the vulkan SPIR-V target.

mei-ye commented on a change in pull request #10391:
URL: https://github.com/apache/tvm/pull/10391#discussion_r815199397



##########
File path: python/tvm/topi/cuda/conv2d_alter_op.py
##########
@@ -83,14 +83,19 @@ def _alter_conv2d_layout(attrs, inputs, tinfos, out_type):
     cfg = dispatch_ctx.query(target, workload)
     if cfg.is_fallback:  # if is fallback, clear query cache and return None
         autotvm.task.clear_fallback_cache(target, workload)
-        return None
+        if (
+            "vulkan" not in target.keys
+            or "+dotprod" not in target.mattr
+            or not target.supports_integer_dot_product
+        ):
+            return None

Review comment:
       If it is fall back and if dot product is to be used, make the flow to proceed to do the NCHW => NCHW4c layout transformation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org