You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/11 03:36:37 UTC
[GitHub] [flink] wuchong commented on a change in pull request #10518:
[FLINK-15124][table] Fix types with precision defined in DDL can't be
executed
wuchong commented on a change in pull request #10518: [FLINK-15124][table] Fix types with precision defined in DDL can't be executed
URL: https://github.com/apache/flink/pull/10518#discussion_r356389740
##########
File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sinks/CsvTableSinkFactoryBase.java
##########
@@ -75,6 +75,8 @@
properties.add(SCHEMA + ".#." + DescriptorProperties.TABLE_SCHEMA_TYPE);
properties.add(SCHEMA + ".#." + DescriptorProperties.TABLE_SCHEMA_DATA_TYPE);
properties.add(SCHEMA + ".#." + DescriptorProperties.TABLE_SCHEMA_NAME);
+ // schema watermark
+ properties.add(SCHEMA + "." + DescriptorProperties.WATERMARK + ".*");
Review comment:
The factory can't be found if a watermark is defined in DDL.
I will update the IT case to use watermark.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services