You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "Sqoop QA bot (JIRA)" <ji...@apache.org> on 2015/07/29 23:58:05 UTC

[jira] [Commented] (SQOOP-2447) Sqoop2: Precommit: Improve cobertura test coverage reporting

    [ https://issues.apache.org/jira/browse/SQOOP-2447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646816#comment-14646816 ] 

Sqoop QA bot commented on SQOOP-2447:
-------------------------------------

Testing file [SQOOP-2447.patch|https://issues.apache.org/jira/secure/attachment/12747850/SQOOP-2447.patch] against branch sqoop2 took 0:40:59.153093.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 683 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1493/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} All integration tests passed (executed 71 tests)

Console output is available [here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1493/console].

This message is automatically generated.

> Sqoop2: Precommit: Improve cobertura test coverage reporting
> ------------------------------------------------------------
>
>                 Key: SQOOP-2447
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2447
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.7
>
>         Attachments: SQOOP-2447.patch
>
>
> Two things that I would like to improve here:
> * We're currently printing WARNING with yellow color that is really badly visible, let's use orange instead that will provide better visibility.
> * I've played a bit with cobertura and it seems to me that it's quite often reporting coverage +/- 1% (probably some different order when doing math on top of float/double), so I would like to adjust for that and simply report only if the test coverage decreases by more then 1%.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)