You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/10/19 08:17:23 UTC

[GitHub] [ignite-3] AMashenkov commented on a change in pull request #360: IGNITE-15414 Schema validation refactoring with configuration validators

AMashenkov commented on a change in pull request #360:
URL: https://github.com/apache/ignite-3/pull/360#discussion_r731608890



##########
File path: modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ITDynamicTableCreationTest.java
##########
@@ -120,16 +127,25 @@ void tearDown() throws Exception {
     }
 
     /**
-     * Check dynamic table creation.
+     * @return Grid nodes.
      */
-    @Test
-    void testDynamicSimpleTableCreation() {
+    @NotNull protected List<Ignite> startGrid() {

Review comment:
       There are number of tests that start the grid, so it make sense to move startGrid() function to a higher level e.g. to a new ITIgniteAbstractTest that extends IgniteAbstractTest.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org