[jira] [Commented] (WEEX-126) scripturl will have no value in some way,we need use pageName instead

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WEEX-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255092#comment-16255092 ] 

ASF GitHub Bot commented on WEEX-126:
-------------------------------------

GitHub user gurisxie opened a pull request:

    https://github.com/apache/incubator-weex/pull/878

    [WEEX-126][iOS] protect for pagename when need send jserror

    …pageName instead：
    
    1. compatible old logic;
    2. use instance.pageName as default for front user.
    
    First of all, thank you for your contribution! 
    
    Please makes sure that these checkboxes are checked before submitting your PR, thank you!
    
    <!-- 
    How to use github markdown?
    ### checkable example
    - [x] checked
    - [ ] not checked
    More github Markdown info to see https://guides.github.com/features/mastering-markdown/
    -->
    
    CheckList:
    
    **if** *isBugFix* **:**
    
      * [ ] Make sure that you add at least one unit test for the bug which you had fixed.
    
    **elif** *isNewFeature* **:**
    
      * [ ] Update API docs for the component.
      * [ ] Update/Add demo to demonstrate new feature.
      * [ ] Update test scripts for the feature.
      * [ ] Add unit tests for the feature.
    
    <!--
    （请在***提交***前删除这段描述）
    
    Notes: Weex will move into Apache Software Foundation (ASF) on Feb 24 2017.
    
    Our new GitHub repo is https://github.com/apache/incubator-weex
    
    After Feb 24 2017, we only accept pull requests from https://github.com/apache/incubator-weex
    
    Thank you for your support.
    
    ----
    
    注意：Weex 将于 2017-02-24 迁移至 Apache 基金会
    
    届时我们会使用新的 GitHub 仓库：https://github.com/apache/incubator-weex 并在那里继续接受大家的 pull request。
    
    更多详情请关注：https://github.com/weexteam/article/issues/130
    
    感谢理解和支持
    
    -->
    
    <!--
    （请在***提交***前删除这段描述）
    It's ***RECOMMENDED*** to submit typo fix, new demo, tiny bugfix and large feature to `master` branch.
        
    See [Branch Strategy](https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management) for more detail.
    
    ----
    
    错别字修改、新 demo、较小的 bugfix、甚至较大的功能都可以直接提到 `master` 分支；
    
    查看完整的[分支策略 (英文)](https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management)。
    
    -->


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gurisxie/incubator-weex ios-bugfix-protectToPageName1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/878.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #878
    
----
commit cd38f3bb34d007218ae24629b833418dfc41903e
Author: gurisxie <27...@qq.com>
Date:   2017-11-16T10:34:04Z

    [WEEX-126][iOS] scripturl will have no value in some way,we need use pageName instead：
    1. compatible old logic;
    2. use instance.pageName as default for front user.

----


> scripturl will have no value in some way,we need use pageName instead
> ---------------------------------------------------------------------
>
>                 Key: WEEX-126
>                 URL: https://issues.apache.org/jira/browse/WEEX-126
>             Project: Weex
>          Issue Type: Bug
>            Reporter: Zechang Xie
>            Assignee: Adam Feng
>
> scripturl will have no value in some way,we need use pageName instead：
> 1.  compatible old logic;
> 2.  use instance.pageName as default for front user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)