You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/05/09 07:42:41 UTC

[GitHub] [calcite] chunweilei commented on a change in pull request #1955: [CALCITE-3941] Add the default strict mode to the path in the Json functions

chunweilei commented on a change in pull request #1955:
URL: https://github.com/apache/calcite/pull/1955#discussion_r422465130



##########
File path: core/src/main/java/org/apache/calcite/runtime/JsonFunctions.java
##########
@@ -112,18 +113,22 @@ public static JsonPathContext jsonApiCommonSyntax(String input, String pathSpec)
   }
 
   public static JsonPathContext jsonApiCommonSyntax(JsonValueContext input, String pathSpec) {
+    PathMode mode;
+    String pathWff;
     try {

Review comment:
       What does `pathWff` mean? Should we change it to a more clearer name?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org