You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by GitBox <gi...@apache.org> on 2020/07/16 15:14:34 UTC
[GitHub] [felix-dev] pkriens opened a new pull request #35: FELIX-6279 Unchanged bundle does not obey force policy
pkriens opened a new pull request #35:
URL: https://github.com/apache/felix-dev/pull/35
The force policy indicates that a bundle's configuration should
always override any local changes.
However, the code contained an optimization that if the configuration
in a bundle was unchanged, it would ignore its configuration
completely, ignoring any force policies.
This patch overrides the optimization in ConfigList for records
where the policy is set to force.
- A test is added that failed on the current bundle and now passes
- The OSGi Test Suite has been run on the code, the XML file is
included in the patch
See https://issues.apache.org/jira/browse/FELIX-6279?filter=-2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [felix-dev] pkriens commented on a change in pull request #35: FELIX-6279 Unchanged bundle does not obey force policy
Posted by GitBox <gi...@apache.org>.
pkriens commented on a change in pull request #35:
URL: https://github.com/apache/felix-dev/pull/35#discussion_r455912795
##########
File path: configurator/TEST-org.osgi.test.cases.configurator-7.0.0.xml
##########
@@ -0,0 +1,116 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
No, you need to run the OSGi test suite and that is restricted and not part of the build sadly. I created a bnd workspace and created a run configuration to run these test suites. I am not sure how this is normally handled but thought it best to include it as proof that it passes the OSGi CT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [felix-dev] bosschaert commented on a change in pull request #35: FELIX-6279 Unchanged bundle does not obey force policy
Posted by GitBox <gi...@apache.org>.
bosschaert commented on a change in pull request #35:
URL: https://github.com/apache/felix-dev/pull/35#discussion_r455902057
##########
File path: configurator/TEST-org.osgi.test.cases.configurator-7.0.0.xml
##########
@@ -0,0 +1,116 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
Isn't this file normally what is produced during a surefire test run. Do we need it as part of the sources?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [felix-dev] pkriens merged pull request #35: FELIX-6279 Unchanged bundle does not obey force policy
Posted by GitBox <gi...@apache.org>.
pkriens merged pull request #35:
URL: https://github.com/apache/felix-dev/pull/35
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [felix-dev] pkriens commented on a change in pull request #35: FELIX-6279 Unchanged bundle does not obey force policy
Posted by GitBox <gi...@apache.org>.
pkriens commented on a change in pull request #35:
URL: https://github.com/apache/felix-dev/pull/35#discussion_r455912795
##########
File path: configurator/TEST-org.osgi.test.cases.configurator-7.0.0.xml
##########
@@ -0,0 +1,116 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
No, you need to run the OSGi test suite and that is restricted and not part of the build sadly. I created a bnd workspace and created a run configuration to run these test suites. I am not sure how this is normally handled but thought it best to include it as proof that it passes the OSGi TCK.
I tried my best, could not find any description how to do this. It was non-trivial to get it all to run also because the TCK had a problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org