You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "David Huntsperger (Jira)" <ji...@apache.org> on 2021/07/15 19:34:00 UTC

[jira] [Commented] (BEAM-11944) Code blocks for different runners are all displayed at once.

    [ https://issues.apache.org/jira/browse/BEAM-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17381557#comment-17381557 ] 

David Huntsperger commented on BEAM-11944:
------------------------------------------

I did some research into this:
 * The Beam site leverages the Hugo [highlight shortcode|https://gohugo.io/content-management/shortcodes/#highlight] to create code tabs. The Beam site wrapper is at *website/www/site/layouts/shortcodes/highlight.html*.
 * There's a language switcher template for Java/Python/Go: *website/www/site/layouts/shortcodes/language-switcher.html*, but we don't have one for shells (unix/PowerShell) or runners.
 * If you try to create language tabs for languages other than Java/Python/Go, the tab widget gets set to {{display:none}} and so is not visible. That appears to be caused by logic in *website/www/site/static/js/language-switch.js*.
 * If we could create _visible_ language tabs for more languages, we might be able use the highlight shortcode to create tab switchers for shells and runners. But I don't think you'd get any syntax highlighting if you passed a "language" like {{DirectRunner}}.
 * Looking at the scss files, it seems like there may have been a plan to build out additional switchers:
 ** *website/www/site/assets/scss/_syntax-highlighting.scss*
 ** *website/www/site/assets/scss/_toggler-nav.scss*

> Code blocks for different runners are all displayed at once.
> ------------------------------------------------------------
>
>                 Key: BEAM-11944
>                 URL: https://issues.apache.org/jira/browse/BEAM-11944
>             Project: Beam
>          Issue Type: Bug
>          Components: website
>            Reporter: Kyle Weaver
>            Priority: P3
>              Labels: starter
>
> e.g. https://beam.apache.org//get-started/quickstart-java/
> Before the website redesign, each runner had its own tab, but now all the runners are displayed at once, which makes the page very hard to read.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)