You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sanjeev n <sa...@citrix.com> on 2013/06/17 08:37:47 UTC

Review Request: Test Snapshot Services

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11904/
-----------------------------------------------------------

Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.


Description
-------

Secondary Storage vm type has been modified from "SecondaryStorage" to "SecondaryStorageVM" in host table in Cloud db.
Modified the same in the test.


Diffs
-----

  test/integration/component/test_snapshots.py 014b55a 

Diff: https://reviews.apache.org/r/11904/diff/


Testing
-------

Yes


Thanks,

sanjeev n


Re: Review Request: Test Snapshot Services

Posted by Prasanna Santhanam <ts...@apache.org>.

> On June 18, 2013, 6:40 a.m., Prasanna Santhanam wrote:
> > This test actually passes on jenkins. What are we changing here?
> 
> sanjeev n wrote:
>     In an environment created with apche master, I see ssvm type as "SecondaryStorageVM" in host table. So I modified the script accordingly.

I guess this is now relevant since the object_store merge removed secondarystorage from the host table. Would you be reworking on this?


- Prasanna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11904/#review22054
-----------------------------------------------------------


On June 17, 2013, 6:37 a.m., sanjeev n wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11904/
> -----------------------------------------------------------
> 
> (Updated June 17, 2013, 6:37 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
> 
> 
> Description
> -------
> 
> Secondary Storage vm type has been modified from "SecondaryStorage" to "SecondaryStorageVM" in host table in Cloud db.
> Modified the same in the test.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_snapshots.py 014b55a 
> 
> Diff: https://reviews.apache.org/r/11904/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> sanjeev n
> 
>


Re: Review Request: Test Snapshot Services

Posted by sanjeev n <sa...@citrix.com>.

> On June 18, 2013, 6:40 a.m., Prasanna Santhanam wrote:
> > This test actually passes on jenkins. What are we changing here?

In an environment created with apche master, I see ssvm type as "SecondaryStorageVM" in host table. So I modified the script accordingly.


- sanjeev


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11904/#review22054
-----------------------------------------------------------


On June 17, 2013, 6:37 a.m., sanjeev n wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11904/
> -----------------------------------------------------------
> 
> (Updated June 17, 2013, 6:37 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
> 
> 
> Description
> -------
> 
> Secondary Storage vm type has been modified from "SecondaryStorage" to "SecondaryStorageVM" in host table in Cloud db.
> Modified the same in the test.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_snapshots.py 014b55a 
> 
> Diff: https://reviews.apache.org/r/11904/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> sanjeev n
> 
>


Re: Review Request: Test Snapshot Services

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11904/#review22054
-----------------------------------------------------------


This test actually passes on jenkins. What are we changing here?

- Prasanna Santhanam


On June 17, 2013, 6:37 a.m., sanjeev n wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11904/
> -----------------------------------------------------------
> 
> (Updated June 17, 2013, 6:37 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
> 
> 
> Description
> -------
> 
> Secondary Storage vm type has been modified from "SecondaryStorage" to "SecondaryStorageVM" in host table in Cloud db.
> Modified the same in the test.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_snapshots.py 014b55a 
> 
> Diff: https://reviews.apache.org/r/11904/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> sanjeev n
> 
>