You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/10/16 09:05:08 UTC
[GitHub] [flink] zentol edited a comment on issue #9867:
[FLINK-7958][metrics] Reporters provide default delimiter
zentol edited a comment on issue #9867: [FLINK-7958][metrics] Reporters provide default delimiter
URL: https://github.com/apache/flink/pull/9867#issuecomment-542603787
The delimiter is already exposed through the configuration, that feature isn't new.
As outlined in the PR description, this feature is primarily a preparation for follow-ups, namely exposing the logical scope via the MetricScope for which reporters need a way to define a non-default delimiter ('_') so that we can retain the current behavior of the prometheus/influx reporters. Similarly to your suggestion about the `CharacterFilter`, the delimiter is also mostly static, hence why I don't want to expose methods accepting a custom delimiter in the `MetricScope`.
Ironically, without this change the only way users would be able to have the correct delimiter is to configure it explicitly for the reporter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services