You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Lars Heinemann (JIRA)" <ji...@apache.org> on 2010/02/12 15:52:28 UTC

[jira] Created: (FELIX-2071) Missing checks inside ModuleImpl (in Framework) which causes exceptions

Missing checks inside ModuleImpl (in Framework) which causes exceptions
-----------------------------------------------------------------------

                 Key: FELIX-2071
                 URL: https://issues.apache.org/jira/browse/FELIX-2071
             Project: Felix
          Issue Type: Improvement
          Components: Framework
    Affects Versions: felix-2.0.3
            Reporter: Lars Heinemann
         Attachments: ModuleImpl.java.patch

The method 
{code}
public Class getClassByDelegation(String name) throws ClassNotFoundException
{code}
lacks check for null or empty name parameter which causes trouble...

{code}
<stack-trace><![CDATA[java.lang.StringIndexOutOfBoundsException: String index out of range: 0
 at java.lang.String.charAt(String.java:686)
 at org.apache.felix.framework.ModuleImpl.getClassByDelegation(ModuleImpl.java:635)
 at org.apache.felix.framework.Felix.loadBundleClass(Felix.java:1543)
 at org.apache.felix.framework.BundleImpl.loadClass(BundleImpl.java:887)
{code}

Please review and apply the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (FELIX-2071) Missing checks inside ModuleImpl (in Framework) which causes exceptions

Posted by "Lars Heinemann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833018#action_12833018 ] 

Lars Heinemann edited comment on FELIX-2071 at 2/12/10 6:54 PM:
----------------------------------------------------------------

attached patch

      was (Author: lhein):
    Applied patch
  
> Missing checks inside ModuleImpl (in Framework) which causes exceptions
> -----------------------------------------------------------------------
>
>                 Key: FELIX-2071
>                 URL: https://issues.apache.org/jira/browse/FELIX-2071
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: felix-2.0.3
>            Reporter: Lars Heinemann
>         Attachments: ModuleImpl.java.patch
>
>
> The method 
> {code}
> public Class getClassByDelegation(String name) throws ClassNotFoundException
> {code}
> lacks check for null or empty name parameter which causes trouble...
> {code}
> <stack-trace><![CDATA[java.lang.StringIndexOutOfBoundsException: String index out of range: 0
>  at java.lang.String.charAt(String.java:686)
>  at org.apache.felix.framework.ModuleImpl.getClassByDelegation(ModuleImpl.java:635)
>  at org.apache.felix.framework.Felix.loadBundleClass(Felix.java:1543)
>  at org.apache.felix.framework.BundleImpl.loadClass(BundleImpl.java:887)
> {code}
> Please review and apply the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (FELIX-2071) Missing checks inside ModuleImpl (in Framework) which causes exceptions

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall resolved FELIX-2071.
------------------------------------

    Resolution: Fixed

I committed the fix, which will go out in the Framework 2.0.4 release. Please close if satisfied, thanks!

> Missing checks inside ModuleImpl (in Framework) which causes exceptions
> -----------------------------------------------------------------------
>
>                 Key: FELIX-2071
>                 URL: https://issues.apache.org/jira/browse/FELIX-2071
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: felix-2.0.3
>            Reporter: Lars Heinemann
>            Assignee: Richard S. Hall
>             Fix For: felix-2.0.4
>
>         Attachments: ModuleImpl.java.patch
>
>
> The method 
> {code}
> public Class getClassByDelegation(String name) throws ClassNotFoundException
> {code}
> lacks check for null or empty name parameter which causes trouble...
> {code}
> <stack-trace><![CDATA[java.lang.StringIndexOutOfBoundsException: String index out of range: 0
>  at java.lang.String.charAt(String.java:686)
>  at org.apache.felix.framework.ModuleImpl.getClassByDelegation(ModuleImpl.java:635)
>  at org.apache.felix.framework.Felix.loadBundleClass(Felix.java:1543)
>  at org.apache.felix.framework.BundleImpl.loadClass(BundleImpl.java:887)
> {code}
> Please review and apply the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-2071) Missing checks inside ModuleImpl (in Framework) which causes exceptions

Posted by "Lars Heinemann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Heinemann updated FELIX-2071:
----------------------------------

    Attachment: ModuleImpl.java.patch

Applied patch

> Missing checks inside ModuleImpl (in Framework) which causes exceptions
> -----------------------------------------------------------------------
>
>                 Key: FELIX-2071
>                 URL: https://issues.apache.org/jira/browse/FELIX-2071
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: felix-2.0.3
>            Reporter: Lars Heinemann
>         Attachments: ModuleImpl.java.patch
>
>
> The method 
> {code}
> public Class getClassByDelegation(String name) throws ClassNotFoundException
> {code}
> lacks check for null or empty name parameter which causes trouble...
> {code}
> <stack-trace><![CDATA[java.lang.StringIndexOutOfBoundsException: String index out of range: 0
>  at java.lang.String.charAt(String.java:686)
>  at org.apache.felix.framework.ModuleImpl.getClassByDelegation(ModuleImpl.java:635)
>  at org.apache.felix.framework.Felix.loadBundleClass(Felix.java:1543)
>  at org.apache.felix.framework.BundleImpl.loadClass(BundleImpl.java:887)
> {code}
> Please review and apply the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-2071) Missing checks inside ModuleImpl (in Framework) which causes exceptions

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall updated FELIX-2071:
-----------------------------------

    Fix Version/s: felix-2.0.4
         Assignee: Richard S. Hall

> Missing checks inside ModuleImpl (in Framework) which causes exceptions
> -----------------------------------------------------------------------
>
>                 Key: FELIX-2071
>                 URL: https://issues.apache.org/jira/browse/FELIX-2071
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: felix-2.0.3
>            Reporter: Lars Heinemann
>            Assignee: Richard S. Hall
>             Fix For: felix-2.0.4
>
>         Attachments: ModuleImpl.java.patch
>
>
> The method 
> {code}
> public Class getClassByDelegation(String name) throws ClassNotFoundException
> {code}
> lacks check for null or empty name parameter which causes trouble...
> {code}
> <stack-trace><![CDATA[java.lang.StringIndexOutOfBoundsException: String index out of range: 0
>  at java.lang.String.charAt(String.java:686)
>  at org.apache.felix.framework.ModuleImpl.getClassByDelegation(ModuleImpl.java:635)
>  at org.apache.felix.framework.Felix.loadBundleClass(Felix.java:1543)
>  at org.apache.felix.framework.BundleImpl.loadClass(BundleImpl.java:887)
> {code}
> Please review and apply the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (FELIX-2071) Missing checks inside ModuleImpl (in Framework) which causes exceptions

Posted by "Lars Heinemann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Heinemann closed FELIX-2071.
---------------------------------


Already compiled and tested it before supplying the patch. It fixes the problem.

Thanks a lot for the fast patching ;)

Regards
Lars


> Missing checks inside ModuleImpl (in Framework) which causes exceptions
> -----------------------------------------------------------------------
>
>                 Key: FELIX-2071
>                 URL: https://issues.apache.org/jira/browse/FELIX-2071
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: felix-2.0.3
>            Reporter: Lars Heinemann
>            Assignee: Richard S. Hall
>             Fix For: felix-2.0.4
>
>         Attachments: ModuleImpl.java.patch
>
>
> The method 
> {code}
> public Class getClassByDelegation(String name) throws ClassNotFoundException
> {code}
> lacks check for null or empty name parameter which causes trouble...
> {code}
> <stack-trace><![CDATA[java.lang.StringIndexOutOfBoundsException: String index out of range: 0
>  at java.lang.String.charAt(String.java:686)
>  at org.apache.felix.framework.ModuleImpl.getClassByDelegation(ModuleImpl.java:635)
>  at org.apache.felix.framework.Felix.loadBundleClass(Felix.java:1543)
>  at org.apache.felix.framework.BundleImpl.loadClass(BundleImpl.java:887)
> {code}
> Please review and apply the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.