You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/09/06 09:19:48 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #42833: [SPARK-45091][PYTHON][CONNECT][SQL] Function `floor/round/bround` accept Column type `scale`
zhengruifeng opened a new pull request, #42833:
URL: https://github.com/apache/spark/pull/42833
### What changes were proposed in this pull request?
1, `floor`: add missing parameter `scale` in Python, which already existed in Scala for a long time;
2, `round/bround`: parameter `scale` support Column type, to be consistent with `floor/ceil/ceiling`
### Why are the changes needed?
to make related functions consistent
### Does this PR introduce _any_ user-facing change?
yes
### How was this patch tested?
added doctest
### Was this patch authored or co-authored using generative AI tooling?
NO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #42833: [SPARK-45091][PYTHON][CONNECT][SQL] Function `floor/round/bround` accept Column type `scale`
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #42833: [SPARK-45091][PYTHON][CONNECT][SQL] Function `floor/round/bround` accept Column type `scale`
URL: https://github.com/apache/spark/pull/42833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42833: [SPARK-45091][PYTHON][CONNECT][SQL] Function `floor/round/bround` accept Column type `scale`
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42833:
URL: https://github.com/apache/spark/pull/42833#issuecomment-1709396805
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org