You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/11/16 12:13:06 UTC
[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull
request #3536: Fixes #3370 .Fix and change some code structure
tristaZero commented on a change in pull request #3536: Fixes #3370 .Fix and change some code structure
URL: https://github.com/apache/incubator-shardingsphere/pull/3536#discussion_r347088639
##########
File path: sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/datasource/dialect/MariaDBDataSourceMetaData.java
##########
@@ -50,6 +55,19 @@ public MariaDBDataSourceMetaData(final String url) {
}
hostName = matcher.group(4);
port = Strings.isNullOrEmpty(matcher.group(5)) ? DEFAULT_PORT : Integer.valueOf(matcher.group(5));
- schemaName = matcher.group(6);
+ catalog = matcher.group(6);
+ schemaName = null;
+ }
+
+ public MariaDBDataSourceMetaData(final DataSourceInfo dataSourceInfo) {
Review comment:
Same with `H2DataSourceMetaData`, can we delete `MariaDBDataSourceMetaData(final String url)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services