[GitHub] [james-project] Arsnael edited a comment on pull request #576: JAMES-3625 JMAP session: Remove trailing / in session download url

[GitBox <gi...@apache.org>]

Arsnael edited a comment on pull request #576:
URL: https://github.com/apache/james-project/pull/576#issuecomment-893328446


   And other errors like this:
   ```
   getShouldReturnCorrectSession – org.apache.james.jmap.rfc8621.distributed.DistributedSessionRouteTest
   Error
   1 expectation failed.
   Expected header "Content-Length" was not "3026", was "3025". Headers are:
   Access-Control-Allow-Origin=*
   Access-Control-Allow-Methods=GET, POST, DELETE, PUT
   Access-Control-Allow-Headers=Content-Type, Authorization, Accept
   content-type=application/json; charset=UTF-8
   content-length=3025
   Stacktrace
   java.lang.AssertionError: 
   1 expectation failed.
   Expected header "Content-Length" was not "3026", was "3025". Headers are:
   Access-Control-Allow-Origin=*
   Access-Control-Allow-Methods=GET, POST, DELETE, PUT
   Access-Control-Allow-Headers=Content-Type, Authorization, Accept
   content-type=application/json; charset=UTF-8
   content-length=3025
   ```
   
   On a side note: CI seems capricious lately, if you could at least run the directly concerned tests after fix locally if you can, instead of thinking "let's rely on the CI", might make things faster and less painful IMO


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org