You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by karensmolermiller <gi...@git.apache.org> on 2017/07/07 00:27:06 UTC
[GitHub] geode-native pull request #108: GEODE-3135 Update Geode Client docs OpenSSL ...
GitHub user karensmolermiller opened a pull request:
https://github.com/apache/geode-native/pull/108
GEODE-3135 Update Geode Client docs OpenSSL version
@pivotal-jbarrett @joeymcallister @davebarnes97
Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karensmolermiller/geode-native feature/GEODE-3135
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode-native/pull/108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #108
----
commit 4c4f388ec58be65705cd544d3449e607a26183cc
Author: Karen Miller <km...@pivotal.io>
Date: 2017-07-07T00:21:45Z
GEODE-3135 Update Geode Client docs OpenSSL version
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native issue #108: GEODE-3135 Update Geode Client docs OpenSSL version
Posted by karensmolermiller <gi...@git.apache.org>.
Github user karensmolermiller commented on the issue:
https://github.com/apache/geode-native/pull/108
Closing this PR. Will address issues, and open a new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #108: GEODE-3135 Update Geode Client docs OpenSSL ...
Posted by pivotal-jbarrett <gi...@git.apache.org>.
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/108#discussion_r126114762
--- Diff: docs/geode-native-docs/security/sslclientserver.html.md.erb ---
@@ -42,17 +42,17 @@ To install OpenSSL:
2. Extract the archive in a directory of your choice. For example:
```
- $ tar xvzf openssl-1.0.1u.tar.gz
- x openssl-1.0.1u/ACKNOWLEDGMENTS
- x openssl-1.0.1u/apps/
- x openssl-1.0.1u/apps/app_rand.c
+ $ tar xvzf openssl-1.0.2l.tar.gz
--- End diff --
Leave off the version numbers for all of these examples. These bits of example on OpenSSL setup should be in a separate doc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #108: GEODE-3135 Update Geode Client docs OpenSSL ...
Posted by pivotal-jbarrett <gi...@git.apache.org>.
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/108#discussion_r126113664
--- Diff: docs/geode-native-docs/introduction/client-configurations.html.md.erb ---
@@ -157,7 +157,7 @@ The following libraries are external dependencies of the client library, `libgfc
If you plan on using SSL in your Geode client and server deployment, you will need to download and install OpenSSL.
-The client requires OpenSSL 1.0.1t or later. For Windows platforms, you can use either the regular or the OpenSSL "Light" version.
+The client requires OpenSSL 1.0.2l or later. For Windows platforms, you can use either the regular or the OpenSSL "Light" version.
--- End diff --
Somehow we need to convey that it is restricted to the 1.0.2 releases of OpenSSL. It would not work for someone to install 1.1.0 despite it meeting the terms of "later".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #108: GEODE-3135 Update Geode Client docs OpenSSL ...
Posted by pivotal-jbarrett <gi...@git.apache.org>.
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/108#discussion_r126114295
--- Diff: docs/geode-native-docs/introduction/quickstart.html.md.erb ---
@@ -53,7 +53,7 @@ for the latest Java version for your operating system. See the installation info
Geode User's Guide for the versions of Java that are compatible with Geode.
- **Security Toolkit** (optional): The QuickStart security examples rely on a security plugin, `securityImpl`, which is based on the OpenSSL toolkit.
-If you plan to run the security examples, download the latest version of release 1.0.1 (must be 1.0.1) from the [OpenSSL website] (http://www.openssl.org/source/).
+If you plan to run the security examples, download the latest version of release 1.0.2 (must be 1.0.2) from the [OpenSSL website] (http://www.openssl.org/source/).
--- End diff --
For maintenance purposes it seems cleaner to have a single section in our docs that talk about external requirements like OpenSSL and then have all the places talk about that requirement to reference back to that page. This way when we change versions, instructions, etc., we don't have to change multiple places in the docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #108: GEODE-3135 Update Geode Client docs OpenSSL ...
Posted by pivotal-jbarrett <gi...@git.apache.org>.
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/108#discussion_r126114552
--- Diff: docs/geode-native-docs/security/sslclientserver.html.md.erb ---
@@ -27,7 +27,7 @@ The open-source OpenSSL toolkit provides a full-strength general purpose cryptog
Follow these instructions to download and install OpenSSL for your specific operating system.
-The native client requires OpenSSL 1.0.1t or later. For Windows platforms, you can use either the regular or the OpenSSL 1.0.1t "Light" version.
+The native client requires OpenSSL 1.0.2l or later. For Windows platforms, you can use either the regular or the "Light" version.
--- End diff --
Same line as in first file. Lets consolidate all this into a single doc around SSL and have these pages reference that doc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #108: GEODE-3135 Update Geode Client docs OpenSSL ...
Posted by karensmolermiller <gi...@git.apache.org>.
Github user karensmolermiller closed the pull request at:
https://github.com/apache/geode-native/pull/108
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---