Re: [PR] [AMORO-3695][Improvement]: Reduce unnecessary details in the log output [amoro]

["zhoujinsong (via GitHub)" <gi...@apache.org>]

zhoujinsong commented on code in PR #3696:
URL: https://github.com/apache/amoro/pull/3696#discussion_r2247138065


##########
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/KeyedTableCommit.java:
##########
@@ -139,6 +141,7 @@ public void commit() throws OptimizingCommitException {
 
     try {
       executeCommit(addedDataFiles, removedDataFiles, addedDeleteFiles, removedDeleteFiles);
+      LOG.info("Successfully commit table {} with {} tasks", table.id(), tasks.size());

Review Comment:
   Can you add some information to tell how much time the commit process cost?



##########
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/UnKeyedTableCommit.java:
##########
@@ -231,6 +231,7 @@ public void commit() throws OptimizingCommitException {
             transaction, removedDataFiles, addedDataFiles, removedDeleteFiles, addedDeleteFiles);
       }
       transaction.commitTransaction();
+      LOG.info("Successfully commit table {} with {} tasks", table.id(), tasks.size());

Review Comment:
   Can you add some information to tell how much time the commit process cost?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org