You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/28 17:49:41 UTC

[GitHub] [spark] MaxGekk opened a new pull request #28398: [SPARK-31557][SQL][TESTS][FOLLOWUP] Check rebasing in all legacy formatters

MaxGekk opened a new pull request #28398:
URL: https://github.com/apache/spark/pull/28398


   ### What changes were proposed in this pull request?
   - Check all available legacy formats in the tests added by https://github.com/apache/spark/pull/28345
   - Check dates rebasing in legacy parsers for only one direction either days -> string or string -> days.
   
   ### Why are the changes needed?
   Round trip tests can hide issues in dates rebasing. For example, if we remove rebasing from legacy parsers (from `parse()` and `format()`) the tests will pass.
   
   ### Does this PR introduce any user-facing change?
   No
   
   ### How was this patch tested?
   By running `DateFormatterSuite`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28398: [SPARK-31557][SQL][TESTS][FOLLOWUP] Check rebasing in all legacy formatters

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28398:
URL: https://github.com/apache/spark/pull/28398#issuecomment-620761049


   **[Test build #122010 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122010/testReport)** for PR 28398 at commit [`d653213`](https://github.com/apache/spark/commit/d6532134e313acdd9d1b2f7515f189744ecf56d4).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28398: [SPARK-31557][SQL][TESTS][FOLLOWUP] Check rebasing in all legacy formatters

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28398:
URL: https://github.com/apache/spark/pull/28398#issuecomment-620761779






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28398: [SPARK-31557][SQL][TESTS][FOLLOWUP] Check rebasing in all legacy formatters

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28398:
URL: https://github.com/apache/spark/pull/28398#issuecomment-620761049


   **[Test build #122010 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122010/testReport)** for PR 28398 at commit [`d653213`](https://github.com/apache/spark/commit/d6532134e313acdd9d1b2f7515f189744ecf56d4).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28398: [SPARK-31557][SQL][TESTS][FOLLOWUP] Check rebasing in all legacy formatters

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28398:
URL: https://github.com/apache/spark/pull/28398#issuecomment-620761779






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28398: [SPARK-31557][SQL][TESTS][FOLLOWUP] Check rebasing in all legacy formatters

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28398:
URL: https://github.com/apache/spark/pull/28398#issuecomment-620922918


   **[Test build #122010 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122010/testReport)** for PR 28398 at commit [`d653213`](https://github.com/apache/spark/commit/d6532134e313acdd9d1b2f7515f189744ecf56d4).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28398: [SPARK-31557][SQL][TESTS][FOLLOWUP] Check rebasing in all legacy formatters

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28398:
URL: https://github.com/apache/spark/pull/28398#issuecomment-620923617






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28398: [SPARK-31557][SQL][TESTS][FOLLOWUP] Check rebasing in all legacy formatters

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28398:
URL: https://github.com/apache/spark/pull/28398#issuecomment-620923617






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #28398: [SPARK-31557][SQL][TESTS][FOLLOWUP] Check rebasing in all legacy formatters

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28398:
URL: https://github.com/apache/spark/pull/28398#issuecomment-620760433


   @bersprockets @cloud-fan While working on the fix for legacy timestamp formatters, I have found that the round trip tests for dates are not enough. Need to test in each direction separately. Also existing tests don't cover all legacy parsers. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org