[GitHub] [nifi] turcsanyip commented on a change in pull request #4837: NIFI-6113 Refactoring to remove instance level variable to make it stateless

[GitBox <gi...@apache.org>]

turcsanyip commented on a change in pull request #4837:
URL: https://github.com/apache/nifi/pull/4837#discussion_r581422845



##########
File path: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFSFileInfo.java
##########
@@ -707,24 +642,24 @@ void finish(ProcessSession session) {
     /*
      * Keeps all request details in single object.
      */
-    static class HDFSFileInfoRequest{
-        enum Groupping {
+    static class HDFSFileInfoRequest {
+        protected enum Grouping {

Review comment:
       As the enclosing class is `package private`, I don't think `protected` really makes sense here. I believe the original was fine. Or do I miss something?

##########
File path: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFSFileInfo.java
##########
@@ -264,8 +263,6 @@ protected void init(final ProcessorInitializationContext context) {
     @Override
     public void onPropertyModified(PropertyDescriptor descriptor, String oldValue, String newValue) {

Review comment:
       This method can be deleted now because it does not do anything just calls the super.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org