You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/08/02 11:09:32 UTC
Review Request 37023: Add an endpoint that exposes component flags.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-3104
https://issues.apache.org/jira/browse/MESOS-3104
Repository: mesos
Description
-------
Add an endpoint that exposes component flags.
Diffs
-----
src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f
src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc
src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544
Diff: https://reviews.apache.org/r/37023/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review93860
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37023]
All tests passed.
- Mesos ReviewBot
On Aug. 2, 2015, 9:28 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2015, 9:28 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component flags.
>
>
> Diffs
> -----
>
> src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f
> src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc
> src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544
> src/slave/http.cpp b0fe5f520dfca156548ba8c436d42fc432223f3d
> src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460
> src/slave/slave.cpp 6b21db973dc95dd5eb2238eebe697db9dd063ef1
>
> Diff: https://reviews.apache.org/r/37023/diff/
>
>
> Testing
> -------
>
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags.json 2>/dev/null|jq .
> {
> "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
> }
> }
> ```
>
> ```
> $ curl http://localhost:5050/slave(1)/flags.json 2>/dev/null|jq .
> {
> "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
> }
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by haosdent huang <ha...@gmail.com>.
> On Aug. 3, 2015, 7:45 p.m., Ben Mahler wrote:
> > src/master/http.cpp, line 958
> > <https://reviews.apache.org/r/37023/diff/2/?file=1027280#file1027280line958>
> >
> > Could you fix this in a separate patch?
I split here. https://reviews.apache.org/r/37252/ Thank you very much!
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review93952
-----------------------------------------------------------
On Aug. 8, 2015, 3:50 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2015, 3:50 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component flags.
>
>
> Diffs
> -----
>
> src/master/http.cpp 7d7e562574f3805eef3a4b69c35be29d7dae6c90
> src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e
> src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80
> src/slave/http.cpp b0fe5f520dfca156548ba8c436d42fc432223f3d
> src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460
> src/slave/slave.cpp 9061e671bea2d52e8c009e92b3d0a4473dca0ad9
>
> Diff: https://reviews.apache.org/r/37023/diff/
>
>
> Testing
> -------
>
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags.json 2>/dev/null|jq .
> {
> "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
> }
> }
> ```
>
> ```
> $ curl http://localhost:5050/slave(1)/flags.json 2>/dev/null|jq .
> {
> "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
> }
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review93952
-----------------------------------------------------------
Ship it!
Nice work! Just a couple of small fixes, notably we're trying to avoid the .json extension going forward.
src/master/http.cpp (line 329)
<https://reviews.apache.org/r/37023/#comment148384>
Can you remove "start" here and for the slave?
src/master/http.cpp (line 546)
<https://reviews.apache.org/r/37023/#comment148390>
Could you fix this in a separate patch?
src/master/http.cpp (line 958)
<https://reviews.apache.org/r/37023/#comment148389>
Could you fix this in a separate patch?
src/master/master.cpp (line 764)
<https://reviews.apache.org/r/37023/#comment148387>
Let's just do /flags, since we're trying to avoid the .json extension.
src/master/master.cpp (line 767)
<https://reviews.apache.org/r/37023/#comment148386>
Mind logging this, like we do for state.json?
src/slave/http.cpp (line 187)
<https://reviews.apache.org/r/37023/#comment148392>
s/start//
src/slave/slave.cpp (line 497)
<https://reviews.apache.org/r/37023/#comment148388>
Let's just do /flags, since we're trying to avoid the .json extension.
src/slave/slave.cpp (line 500)
<https://reviews.apache.org/r/37023/#comment148385>
Mind logging this, like we do for state.json?
- Ben Mahler
On Aug. 2, 2015, 9:28 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2015, 9:28 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component flags.
>
>
> Diffs
> -----
>
> src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f
> src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc
> src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544
> src/slave/http.cpp b0fe5f520dfca156548ba8c436d42fc432223f3d
> src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460
> src/slave/slave.cpp 6b21db973dc95dd5eb2238eebe697db9dd063ef1
>
> Diff: https://reviews.apache.org/r/37023/diff/
>
>
> Testing
> -------
>
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags.json 2>/dev/null|jq .
> {
> "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
> }
> }
> ```
>
> ```
> $ curl http://localhost:5050/slave(1)/flags.json 2>/dev/null|jq .
> {
> "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
> }
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review101428
-----------------------------------------------------------
For the description, I think that the current endpoint does not include ".json"?
src/master/http.cpp (line 526)
<https://reviews.apache.org/r/37023/#comment158823>
Does this needed?
- Guangya Liu
On 十月 3, 2015, 4:49 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> -----------------------------------------------------------
>
> (Updated 十月 3, 2015, 4:49 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component flags.
>
>
> Diffs
> -----
>
> src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
> src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c
> src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
> src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
> src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
>
> Diff: https://reviews.apache.org/r/37023/diff/
>
>
> Testing
> -------
>
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags.json 2>/dev/null|jq .
> {
> "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
> }
> }
> ```
>
> ```
> $ curl http://localhost:5050/slave(1)/flags.json 2>/dev/null|jq .
> {
> "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
> }
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review101604
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 十月 6, 2015, 4:15 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> -----------------------------------------------------------
>
> (Updated 十月 6, 2015, 4:15 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component flags.
>
>
> Diffs
> -----
>
> src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
> src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c
> src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
> src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
> src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
>
> Diff: https://reviews.apache.org/r/37023/diff/
>
>
> Testing
> -------
>
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags 2>/dev/null|jq .
> {
> "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
> }
> }
> ```
>
> ```
> $ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
> {
> "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
> }
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review101628
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39037, 37023]
All tests passed.
- Mesos ReviewBot
On Oct. 6, 2015, 4:15 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 4:15 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component flags.
>
>
> Diffs
> -----
>
> src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
> src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c
> src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
> src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
> src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
>
> Diff: https://reviews.apache.org/r/37023/diff/
>
>
> Testing
> -------
>
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags 2>/dev/null|jq .
> {
> "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
> }
> }
> ```
>
> ```
> $ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
> {
> "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
> }
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by haosdent huang <ha...@gmail.com>.
> On Oct. 13, 2015, 9:32 p.m., Ben Mahler wrote:
> > Looks great, I made some minor comments about keeping the HELP constants consistent. But since the existing help strings are static PODs, I've updated them to become static functions and I've updated your patch to follow the same style. Thanks!
Thank you very much! I saw your changes to update exists help strings.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review102534
-----------------------------------------------------------
On Oct. 13, 2015, 2:47 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 2:47 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component flags.
>
>
> Diffs
> -----
>
> src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
> src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f
> src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
> src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
> src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
>
> Diff: https://reviews.apache.org/r/37023/diff/
>
>
> Testing
> -------
>
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags 2>/dev/null|jq .
> {
> "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
> }
> }
> ```
>
> ```
> $ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
> {
> "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
> }
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review102534
-----------------------------------------------------------
Ship it!
Looks great, I made some minor comments about keeping the HELP constants consistent. But since the existing help strings are static PODs, I've updated them to become static functions and I've updated your patch to follow the same style. Thanks!
src/master/master.cpp (lines 125 - 130)
<https://reviews.apache.org/r/37023/#comment160233>
Looks like this should be a static function in Http called FLAGS_HELP, to be consistent, although we still need to make the others functions rather than static strings.
src/master/master.cpp (lines 128 - 129)
<https://reviews.apache.org/r/37023/#comment160231>
No need to wrap here.
How about:
"Exposes the master's flag configuration."
src/slave/slave.cpp (lines 121 - 126)
<https://reviews.apache.org/r/37023/#comment160232>
Ditto here
- Ben Mahler
On Oct. 13, 2015, 2:47 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 2:47 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component flags.
>
>
> Diffs
> -----
>
> src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
> src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f
> src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
> src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
> src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
>
> Diff: https://reviews.apache.org/r/37023/diff/
>
>
> Testing
> -------
>
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags 2>/dev/null|jq .
> {
> "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
> }
> }
> ```
>
> ```
> $ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
> {
> "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
> }
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review102386
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39037, 37023]
All tests passed.
- Mesos ReviewBot
On Oct. 13, 2015, 2:47 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 2:47 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component flags.
>
>
> Diffs
> -----
>
> src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
> src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f
> src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
> src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
> src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
>
> Diff: https://reviews.apache.org/r/37023/diff/
>
>
> Testing
> -------
>
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags 2>/dev/null|jq .
> {
> "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
> }
> }
> ```
>
> ```
> $ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
> {
> "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
> }
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review102389
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 十月 13, 2015, 2:47 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> -----------------------------------------------------------
>
> (Updated 十月 13, 2015, 2:47 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component flags.
>
>
> Diffs
> -----
>
> src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
> src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f
> src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
> src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
> src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
>
> Diff: https://reviews.apache.org/r/37023/diff/
>
>
> Testing
> -------
>
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags 2>/dev/null|jq .
> {
> "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
> }
> }
> ```
>
> ```
> $ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
> {
> "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
> }
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/
-----------------------------------------------------------
(Updated Oct. 13, 2015, 2:47 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Rebase
Bugs: MESOS-3104
https://issues.apache.org/jira/browse/MESOS-3104
Repository: mesos
Description
-------
Add an endpoint that exposes component flags.
Diffs (updated)
-----
src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f
src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
Diff: https://reviews.apache.org/r/37023/diff/
Testing
-------
manual test wich mesos-local.
```
$ curl http://localhost:5050/master/flags 2>/dev/null|jq .
{
"flags": {
"allocation_interval": "1secs",
"allocator": "HierarchicalDRF",
"authenticate": "false",
"authenticate_slaves": "false",
"authenticators": "crammd5",
"framework_sorter": "drf",
"help": "true",
"initialize_driver_logging": "true",
"log_auto_initialize": "true",
"logbufsecs": "0",
"logging_level": "INFO",
"max_slave_ping_timeouts": "5",
"quiet": "false",
"recovery_slave_removal_limit": "100%",
"registry": "replicated_log",
"registry_fetch_timeout": "1mins",
"registry_store_timeout": "5secs",
"registry_strict": "false",
"root_submissions": "true",
"slave_ping_timeout": "15secs",
"slave_reregister_timeout": "10mins",
"user_sorter": "drf",
"version": "false",
"webui_dir": "/home/haosdent/mesos/build/../src/webui",
"work_dir": "/tmp/mesos",
"zk_session_timeout": "10secs"
}
}
```
```
$ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
{
"flags": {
"authenticatee": "crammd5",
"cgroups_cpu_enable_pids_and_tids_count": "false",
"cgroups_enable_cfs": "false",
"cgroups_hierarchy": "/sys/fs/cgroup",
"cgroups_limit_swap": "false",
"cgroups_root": "mesos",
"container_disk_watch_interval": "15secs",
"containerizers": "mesos",
"default_role": "*",
"disk_watch_interval": "1mins",
"docker": "docker",
"docker_kill_orphans": "true",
"docker_remove_delay": "6hrs",
"docker_socket": "/var/run/docker.sock",
"docker_stop_timeout": "0ns",
"enforce_container_disk_quota": "false",
"executor_registration_timeout": "1mins",
"executor_shutdown_grace_period": "5secs",
"fetcher_cache_dir": "/tmp/mesos/fetch",
"fetcher_cache_size": "2GB",
"frameworks_home": "",
"gc_delay": "1weeks",
"gc_disk_headroom": "0.1",
"hadoop_home": "",
"help": "false",
"initialize_driver_logging": "true",
"isolation": "posix/cpu,posix/mem",
"launcher_dir": "/home/haosdent/mesos/build/src",
"logbufsecs": "0",
"logging_level": "INFO",
"oversubscribed_resources_interval": "15secs",
"perf_duration": "10secs",
"perf_interval": "1mins",
"qos_correction_interval_min": "0ns",
"quiet": "false",
"recover": "reconnect",
"recovery_timeout": "15mins",
"registration_backoff_factor": "1secs",
"resource_monitoring_interval": "1secs",
"revocable_cpu_low_priority": "true",
"sandbox_directory": "/mnt/mesos/sandbox",
"strict": "true",
"switch_user": "true",
"version": "false",
"work_dir": "/tmp/mesos/0"
}
}
```
Thanks,
haosdent huang
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/
-----------------------------------------------------------
(Updated Oct. 6, 2015, 4:15 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Update according @gyliu's review
Bugs: MESOS-3104
https://issues.apache.org/jira/browse/MESOS-3104
Repository: mesos
Description
-------
Add an endpoint that exposes component flags.
Diffs (updated)
-----
src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c
src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
Diff: https://reviews.apache.org/r/37023/diff/
Testing
-------
manual test wich mesos-local.
```
$ curl http://localhost:5050/master/flags 2>/dev/null|jq .
{
"flags": {
"allocation_interval": "1secs",
"allocator": "HierarchicalDRF",
"authenticate": "false",
"authenticate_slaves": "false",
"authenticators": "crammd5",
"framework_sorter": "drf",
"help": "true",
"initialize_driver_logging": "true",
"log_auto_initialize": "true",
"logbufsecs": "0",
"logging_level": "INFO",
"max_slave_ping_timeouts": "5",
"quiet": "false",
"recovery_slave_removal_limit": "100%",
"registry": "replicated_log",
"registry_fetch_timeout": "1mins",
"registry_store_timeout": "5secs",
"registry_strict": "false",
"root_submissions": "true",
"slave_ping_timeout": "15secs",
"slave_reregister_timeout": "10mins",
"user_sorter": "drf",
"version": "false",
"webui_dir": "/home/haosdent/mesos/build/../src/webui",
"work_dir": "/tmp/mesos",
"zk_session_timeout": "10secs"
}
}
```
```
$ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
{
"flags": {
"authenticatee": "crammd5",
"cgroups_cpu_enable_pids_and_tids_count": "false",
"cgroups_enable_cfs": "false",
"cgroups_hierarchy": "/sys/fs/cgroup",
"cgroups_limit_swap": "false",
"cgroups_root": "mesos",
"container_disk_watch_interval": "15secs",
"containerizers": "mesos",
"default_role": "*",
"disk_watch_interval": "1mins",
"docker": "docker",
"docker_kill_orphans": "true",
"docker_remove_delay": "6hrs",
"docker_socket": "/var/run/docker.sock",
"docker_stop_timeout": "0ns",
"enforce_container_disk_quota": "false",
"executor_registration_timeout": "1mins",
"executor_shutdown_grace_period": "5secs",
"fetcher_cache_dir": "/tmp/mesos/fetch",
"fetcher_cache_size": "2GB",
"frameworks_home": "",
"gc_delay": "1weeks",
"gc_disk_headroom": "0.1",
"hadoop_home": "",
"help": "false",
"initialize_driver_logging": "true",
"isolation": "posix/cpu,posix/mem",
"launcher_dir": "/home/haosdent/mesos/build/src",
"logbufsecs": "0",
"logging_level": "INFO",
"oversubscribed_resources_interval": "15secs",
"perf_duration": "10secs",
"perf_interval": "1mins",
"qos_correction_interval_min": "0ns",
"quiet": "false",
"recover": "reconnect",
"recovery_timeout": "15mins",
"registration_backoff_factor": "1secs",
"resource_monitoring_interval": "1secs",
"revocable_cpu_low_priority": "true",
"sandbox_directory": "/mnt/mesos/sandbox",
"strict": "true",
"switch_user": "true",
"version": "false",
"work_dir": "/tmp/mesos/0"
}
}
```
Thanks,
haosdent huang
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by haosdent huang <ha...@gmail.com>.
> On Oct. 6, 2015, 3:43 a.m., Guangya Liu wrote:
> > src/master/master.cpp, line 131
> > <https://reviews.apache.org/r/37023/diff/7/?file=1091519#file1091519line131>
> >
> > Does DESCRIPTION still needed since it is empty now.
>
> haosdent huang wrote:
> So far we still need it except we add
> ```
> string HELP(
> string tldr,
> const Option<string>& references)
> ```
> to libprocess/help.cpp
Hmm, let me add it to libprocess/help.cpp.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review101592
-----------------------------------------------------------
On Oct. 6, 2015, 2:29 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 2:29 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component flags.
>
>
> Diffs
> -----
>
> src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
> src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c
> src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
> src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
> src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
>
> Diff: https://reviews.apache.org/r/37023/diff/
>
>
> Testing
> -------
>
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags 2>/dev/null|jq .
> {
> "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
> }
> }
> ```
>
> ```
> $ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
> {
> "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
> }
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by haosdent huang <ha...@gmail.com>.
> On Oct. 6, 2015, 3:43 a.m., Guangya Liu wrote:
> > src/master/master.cpp, line 131
> > <https://reviews.apache.org/r/37023/diff/7/?file=1091519#file1091519line131>
> >
> > Does DESCRIPTION still needed since it is empty now.
So far we still need it except we add
```
string HELP(
string tldr,
const Option<string>& references)
```
to libprocess/help.cpp
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review101592
-----------------------------------------------------------
On Oct. 6, 2015, 2:29 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 2:29 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component flags.
>
>
> Diffs
> -----
>
> src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
> src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c
> src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
> src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
> src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
>
> Diff: https://reviews.apache.org/r/37023/diff/
>
>
> Testing
> -------
>
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags 2>/dev/null|jq .
> {
> "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
> }
> }
> ```
>
> ```
> $ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
> {
> "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
> }
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review101592
-----------------------------------------------------------
src/master/master.cpp (line 131)
<https://reviews.apache.org/r/37023/#comment159025>
Does DESCRIPTION still needed since it is empty now.
- Guangya Liu
On 十月 6, 2015, 2:29 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> -----------------------------------------------------------
>
> (Updated 十月 6, 2015, 2:29 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component flags.
>
>
> Diffs
> -----
>
> src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
> src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c
> src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
> src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
> src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
>
> Diff: https://reviews.apache.org/r/37023/diff/
>
>
> Testing
> -------
>
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags 2>/dev/null|jq .
> {
> "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
> }
> }
> ```
>
> ```
> $ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
> {
> "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
> }
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/
-----------------------------------------------------------
(Updated Oct. 6, 2015, 2:29 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Update according @bmahler's reviews
Bugs: MESOS-3104
https://issues.apache.org/jira/browse/MESOS-3104
Repository: mesos
Description
-------
Add an endpoint that exposes component flags.
Diffs (updated)
-----
src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c
src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
Diff: https://reviews.apache.org/r/37023/diff/
Testing
-------
manual test wich mesos-local.
```
$ curl http://localhost:5050/master/flags 2>/dev/null|jq .
{
"flags": {
"allocation_interval": "1secs",
"allocator": "HierarchicalDRF",
"authenticate": "false",
"authenticate_slaves": "false",
"authenticators": "crammd5",
"framework_sorter": "drf",
"help": "true",
"initialize_driver_logging": "true",
"log_auto_initialize": "true",
"logbufsecs": "0",
"logging_level": "INFO",
"max_slave_ping_timeouts": "5",
"quiet": "false",
"recovery_slave_removal_limit": "100%",
"registry": "replicated_log",
"registry_fetch_timeout": "1mins",
"registry_store_timeout": "5secs",
"registry_strict": "false",
"root_submissions": "true",
"slave_ping_timeout": "15secs",
"slave_reregister_timeout": "10mins",
"user_sorter": "drf",
"version": "false",
"webui_dir": "/home/haosdent/mesos/build/../src/webui",
"work_dir": "/tmp/mesos",
"zk_session_timeout": "10secs"
}
}
```
```
$ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
{
"flags": {
"authenticatee": "crammd5",
"cgroups_cpu_enable_pids_and_tids_count": "false",
"cgroups_enable_cfs": "false",
"cgroups_hierarchy": "/sys/fs/cgroup",
"cgroups_limit_swap": "false",
"cgroups_root": "mesos",
"container_disk_watch_interval": "15secs",
"containerizers": "mesos",
"default_role": "*",
"disk_watch_interval": "1mins",
"docker": "docker",
"docker_kill_orphans": "true",
"docker_remove_delay": "6hrs",
"docker_socket": "/var/run/docker.sock",
"docker_stop_timeout": "0ns",
"enforce_container_disk_quota": "false",
"executor_registration_timeout": "1mins",
"executor_shutdown_grace_period": "5secs",
"fetcher_cache_dir": "/tmp/mesos/fetch",
"fetcher_cache_size": "2GB",
"frameworks_home": "",
"gc_delay": "1weeks",
"gc_disk_headroom": "0.1",
"hadoop_home": "",
"help": "false",
"initialize_driver_logging": "true",
"isolation": "posix/cpu,posix/mem",
"launcher_dir": "/home/haosdent/mesos/build/src",
"logbufsecs": "0",
"logging_level": "INFO",
"oversubscribed_resources_interval": "15secs",
"perf_duration": "10secs",
"perf_interval": "1mins",
"qos_correction_interval_min": "0ns",
"quiet": "false",
"recover": "reconnect",
"recovery_timeout": "15mins",
"registration_backoff_factor": "1secs",
"resource_monitoring_interval": "1secs",
"revocable_cpu_low_priority": "true",
"sandbox_directory": "/mnt/mesos/sandbox",
"strict": "true",
"switch_user": "true",
"version": "false",
"work_dir": "/tmp/mesos/0"
}
}
```
Thanks,
haosdent huang
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review101434
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 十月 4, 2015, 6:27 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> -----------------------------------------------------------
>
> (Updated 十月 4, 2015, 6:27 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component flags.
>
>
> Diffs
> -----
>
> src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
> src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c
> src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
> src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
> src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
>
> Diff: https://reviews.apache.org/r/37023/diff/
>
>
> Testing
> -------
>
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags 2>/dev/null|jq .
> {
> "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
> }
> }
> ```
>
> ```
> $ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
> {
> "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
> }
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by haosdent huang <ha...@gmail.com>.
> On Oct. 6, 2015, 1:19 a.m., Ben Mahler wrote:
> > src/master/http.cpp, line 523
> > <https://reviews.apache.org/r/37023/diff/6/?file=1090061#file1090061line523>
> >
> > Can you avoid the static non-POD? We should follow up on removing the rest as well (I believe there is a ticket for this).
> >
> > How about following the approach from monitor.cpp?
> >
> > https://github.com/apache/mesos/blob/master/src/slave/monitor.cpp#L45
I change it, but current patch looks inconsistent with old style. Should we change to old style here?
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review101570
-----------------------------------------------------------
On Oct. 6, 2015, 2:29 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 2:29 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component flags.
>
>
> Diffs
> -----
>
> src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
> src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c
> src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
> src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
> src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
>
> Diff: https://reviews.apache.org/r/37023/diff/
>
>
> Testing
> -------
>
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags 2>/dev/null|jq .
> {
> "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
> }
> }
> ```
>
> ```
> $ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
> {
> "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
> }
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review101570
-----------------------------------------------------------
Ship it!
Looks great, just a minor cleanup and we can get this committed. Thanks for the patience!
src/master/http.cpp (line 523)
<https://reviews.apache.org/r/37023/#comment159004>
Can you avoid the static non-POD? We should follow up on removing the rest as well (I believe there is a ticket for this).
How about following the approach from monitor.cpp?
https://github.com/apache/mesos/blob/master/src/slave/monitor.cpp#L45
src/master/http.cpp (lines 524 - 528)
<https://reviews.apache.org/r/37023/#comment159009>
The TLDR seems sufficient here, no need for the redundant description.
src/slave/http.cpp (lines 322 - 327)
<https://reviews.apache.org/r/37023/#comment159010>
Ditto the above comments
- Ben Mahler
On Oct. 4, 2015, 6:27 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2015, 6:27 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component flags.
>
>
> Diffs
> -----
>
> src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
> src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c
> src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
> src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
> src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
>
> Diff: https://reviews.apache.org/r/37023/diff/
>
>
> Testing
> -------
>
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags 2>/dev/null|jq .
> {
> "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
> }
> }
> ```
>
> ```
> $ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
> {
> "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
> }
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review101436
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37023]
All tests passed.
- Mesos ReviewBot
On Oct. 4, 2015, 6:27 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2015, 6:27 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component flags.
>
>
> Diffs
> -----
>
> src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
> src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c
> src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
> src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
> src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
>
> Diff: https://reviews.apache.org/r/37023/diff/
>
>
> Testing
> -------
>
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags 2>/dev/null|jq .
> {
> "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
> }
> }
> ```
>
> ```
> $ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
> {
> "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
> }
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/
-----------------------------------------------------------
(Updated Oct. 4, 2015, 6:27 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Update test
Bugs: MESOS-3104
https://issues.apache.org/jira/browse/MESOS-3104
Repository: mesos
Description
-------
Add an endpoint that exposes component flags.
Diffs
-----
src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c
src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
Diff: https://reviews.apache.org/r/37023/diff/
Testing (updated)
-------
manual test wich mesos-local.
```
$ curl http://localhost:5050/master/flags 2>/dev/null|jq .
{
"flags": {
"allocation_interval": "1secs",
"allocator": "HierarchicalDRF",
"authenticate": "false",
"authenticate_slaves": "false",
"authenticators": "crammd5",
"framework_sorter": "drf",
"help": "true",
"initialize_driver_logging": "true",
"log_auto_initialize": "true",
"logbufsecs": "0",
"logging_level": "INFO",
"max_slave_ping_timeouts": "5",
"quiet": "false",
"recovery_slave_removal_limit": "100%",
"registry": "replicated_log",
"registry_fetch_timeout": "1mins",
"registry_store_timeout": "5secs",
"registry_strict": "false",
"root_submissions": "true",
"slave_ping_timeout": "15secs",
"slave_reregister_timeout": "10mins",
"user_sorter": "drf",
"version": "false",
"webui_dir": "/home/haosdent/mesos/build/../src/webui",
"work_dir": "/tmp/mesos",
"zk_session_timeout": "10secs"
}
}
```
```
$ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
{
"flags": {
"authenticatee": "crammd5",
"cgroups_cpu_enable_pids_and_tids_count": "false",
"cgroups_enable_cfs": "false",
"cgroups_hierarchy": "/sys/fs/cgroup",
"cgroups_limit_swap": "false",
"cgroups_root": "mesos",
"container_disk_watch_interval": "15secs",
"containerizers": "mesos",
"default_role": "*",
"disk_watch_interval": "1mins",
"docker": "docker",
"docker_kill_orphans": "true",
"docker_remove_delay": "6hrs",
"docker_socket": "/var/run/docker.sock",
"docker_stop_timeout": "0ns",
"enforce_container_disk_quota": "false",
"executor_registration_timeout": "1mins",
"executor_shutdown_grace_period": "5secs",
"fetcher_cache_dir": "/tmp/mesos/fetch",
"fetcher_cache_size": "2GB",
"frameworks_home": "",
"gc_delay": "1weeks",
"gc_disk_headroom": "0.1",
"hadoop_home": "",
"help": "false",
"initialize_driver_logging": "true",
"isolation": "posix/cpu,posix/mem",
"launcher_dir": "/home/haosdent/mesos/build/src",
"logbufsecs": "0",
"logging_level": "INFO",
"oversubscribed_resources_interval": "15secs",
"perf_duration": "10secs",
"perf_interval": "1mins",
"qos_correction_interval_min": "0ns",
"quiet": "false",
"recover": "reconnect",
"recovery_timeout": "15mins",
"registration_backoff_factor": "1secs",
"resource_monitoring_interval": "1secs",
"revocable_cpu_low_priority": "true",
"sandbox_directory": "/mnt/mesos/sandbox",
"strict": "true",
"switch_user": "true",
"version": "false",
"work_dir": "/tmp/mesos/0"
}
}
```
Thanks,
haosdent huang
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/
-----------------------------------------------------------
(Updated Oct. 4, 2015, 6:26 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Fix failed compile
Bugs: MESOS-3104
https://issues.apache.org/jira/browse/MESOS-3104
Repository: mesos
Description
-------
Add an endpoint that exposes component flags.
Diffs (updated)
-----
src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c
src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
Diff: https://reviews.apache.org/r/37023/diff/
Testing (updated)
-------
manual test wich mesos-local.
```
$ curl http://localhost:5050/master/flags 2>/dev/null|jq .
{
"flags": {
"allocation_interval": "1secs",
"allocator": "HierarchicalDRF",
"authenticate": "false",
"authenticate_slaves": "false",
"authenticators": "crammd5",
"framework_sorter": "drf",
"help": "true",
"initialize_driver_logging": "true",
"log_auto_initialize": "true",
"logbufsecs": "0",
"logging_level": "INFO",
"max_slave_ping_timeouts": "5",
"quiet": "false",
"recovery_slave_removal_limit": "100%",
"registry": "replicated_log",
"registry_fetch_timeout": "1mins",
"registry_store_timeout": "5secs",
"registry_strict": "false",
"root_submissions": "true",
"slave_ping_timeout": "15secs",
"slave_reregister_timeout": "10mins",
"user_sorter": "drf",
"version": "false",
"webui_dir": "/home/haosdent/mesos/build/../src/webui",
"work_dir": "/tmp/mesos",
"zk_session_timeout": "10secs"
}
}
```
```
$ curl http://localhost:5050/slave(1)/flags.json 2>/dev/null|jq .
{
"flags": {
"authenticatee": "crammd5",
"cgroups_cpu_enable_pids_and_tids_count": "false",
"cgroups_enable_cfs": "false",
"cgroups_hierarchy": "/sys/fs/cgroup",
"cgroups_limit_swap": "false",
"cgroups_root": "mesos",
"container_disk_watch_interval": "15secs",
"containerizers": "mesos",
"default_role": "*",
"disk_watch_interval": "1mins",
"docker": "docker",
"docker_kill_orphans": "true",
"docker_remove_delay": "6hrs",
"docker_socket": "/var/run/docker.sock",
"docker_stop_timeout": "0ns",
"enforce_container_disk_quota": "false",
"executor_registration_timeout": "1mins",
"executor_shutdown_grace_period": "5secs",
"fetcher_cache_dir": "/tmp/mesos/fetch",
"fetcher_cache_size": "2GB",
"frameworks_home": "",
"gc_delay": "1weeks",
"gc_disk_headroom": "0.1",
"hadoop_home": "",
"help": "false",
"initialize_driver_logging": "true",
"isolation": "posix/cpu,posix/mem",
"launcher_dir": "/home/haosdent/mesos/build/src",
"logbufsecs": "0",
"logging_level": "INFO",
"oversubscribed_resources_interval": "15secs",
"perf_duration": "10secs",
"perf_interval": "1mins",
"qos_correction_interval_min": "0ns",
"quiet": "false",
"recover": "reconnect",
"recovery_timeout": "15mins",
"registration_backoff_factor": "1secs",
"resource_monitoring_interval": "1secs",
"revocable_cpu_low_priority": "true",
"sandbox_directory": "/mnt/mesos/sandbox",
"strict": "true",
"switch_user": "true",
"version": "false",
"work_dir": "/tmp/mesos/0"
}
}
```
Thanks,
haosdent huang
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/
-----------------------------------------------------------
(Updated Oct. 3, 2015, 4:49 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Rebase
Bugs: MESOS-3104
https://issues.apache.org/jira/browse/MESOS-3104
Repository: mesos
Description
-------
Add an endpoint that exposes component flags.
Diffs (updated)
-----
src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c
src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
Diff: https://reviews.apache.org/r/37023/diff/
Testing
-------
manual test wich mesos-local.
```
$ curl http://localhost:5050/master/flags.json 2>/dev/null|jq .
{
"flags": {
"allocation_interval": "1secs",
"allocator": "HierarchicalDRF",
"authenticate": "false",
"authenticate_slaves": "false",
"authenticators": "crammd5",
"framework_sorter": "drf",
"help": "true",
"initialize_driver_logging": "true",
"log_auto_initialize": "true",
"logbufsecs": "0",
"logging_level": "INFO",
"max_slave_ping_timeouts": "5",
"quiet": "false",
"recovery_slave_removal_limit": "100%",
"registry": "replicated_log",
"registry_fetch_timeout": "1mins",
"registry_store_timeout": "5secs",
"registry_strict": "false",
"root_submissions": "true",
"slave_ping_timeout": "15secs",
"slave_reregister_timeout": "10mins",
"user_sorter": "drf",
"version": "false",
"webui_dir": "/home/haosdent/mesos/build/../src/webui",
"work_dir": "/tmp/mesos",
"zk_session_timeout": "10secs"
}
}
```
```
$ curl http://localhost:5050/slave(1)/flags.json 2>/dev/null|jq .
{
"flags": {
"authenticatee": "crammd5",
"cgroups_cpu_enable_pids_and_tids_count": "false",
"cgroups_enable_cfs": "false",
"cgroups_hierarchy": "/sys/fs/cgroup",
"cgroups_limit_swap": "false",
"cgroups_root": "mesos",
"container_disk_watch_interval": "15secs",
"containerizers": "mesos",
"default_role": "*",
"disk_watch_interval": "1mins",
"docker": "docker",
"docker_kill_orphans": "true",
"docker_remove_delay": "6hrs",
"docker_socket": "/var/run/docker.sock",
"docker_stop_timeout": "0ns",
"enforce_container_disk_quota": "false",
"executor_registration_timeout": "1mins",
"executor_shutdown_grace_period": "5secs",
"fetcher_cache_dir": "/tmp/mesos/fetch",
"fetcher_cache_size": "2GB",
"frameworks_home": "",
"gc_delay": "1weeks",
"gc_disk_headroom": "0.1",
"hadoop_home": "",
"help": "false",
"initialize_driver_logging": "true",
"isolation": "posix/cpu,posix/mem",
"launcher_dir": "/home/haosdent/mesos/build/src",
"logbufsecs": "0",
"logging_level": "INFO",
"oversubscribed_resources_interval": "15secs",
"perf_duration": "10secs",
"perf_interval": "1mins",
"qos_correction_interval_min": "0ns",
"quiet": "false",
"recover": "reconnect",
"recovery_timeout": "15mins",
"registration_backoff_factor": "1secs",
"resource_monitoring_interval": "1secs",
"revocable_cpu_low_priority": "true",
"sandbox_directory": "/mnt/mesos/sandbox",
"strict": "true",
"switch_user": "true",
"version": "false",
"work_dir": "/tmp/mesos/0"
}
}
```
Thanks,
haosdent huang
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review94618
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37023]
All tests passed.
- Mesos ReviewBot
On Aug. 8, 2015, 3:50 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2015, 3:50 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add an endpoint that exposes component flags.
>
>
> Diffs
> -----
>
> src/master/http.cpp 7d7e562574f3805eef3a4b69c35be29d7dae6c90
> src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e
> src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80
> src/slave/http.cpp b0fe5f520dfca156548ba8c436d42fc432223f3d
> src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460
> src/slave/slave.cpp 9061e671bea2d52e8c009e92b3d0a4473dca0ad9
>
> Diff: https://reviews.apache.org/r/37023/diff/
>
>
> Testing
> -------
>
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags.json 2>/dev/null|jq .
> {
> "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
> }
> }
> ```
>
> ```
> $ curl http://localhost:5050/slave(1)/flags.json 2>/dev/null|jq .
> {
> "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
> }
> }
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/
-----------------------------------------------------------
(Updated Aug. 8, 2015, 3:50 a.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-3104
https://issues.apache.org/jira/browse/MESOS-3104
Repository: mesos
Description
-------
Add an endpoint that exposes component flags.
Diffs (updated)
-----
src/master/http.cpp 7d7e562574f3805eef3a4b69c35be29d7dae6c90
src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e
src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80
src/slave/http.cpp b0fe5f520dfca156548ba8c436d42fc432223f3d
src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460
src/slave/slave.cpp 9061e671bea2d52e8c009e92b3d0a4473dca0ad9
Diff: https://reviews.apache.org/r/37023/diff/
Testing
-------
manual test wich mesos-local.
```
$ curl http://localhost:5050/master/flags.json 2>/dev/null|jq .
{
"flags": {
"allocation_interval": "1secs",
"allocator": "HierarchicalDRF",
"authenticate": "false",
"authenticate_slaves": "false",
"authenticators": "crammd5",
"framework_sorter": "drf",
"help": "true",
"initialize_driver_logging": "true",
"log_auto_initialize": "true",
"logbufsecs": "0",
"logging_level": "INFO",
"max_slave_ping_timeouts": "5",
"quiet": "false",
"recovery_slave_removal_limit": "100%",
"registry": "replicated_log",
"registry_fetch_timeout": "1mins",
"registry_store_timeout": "5secs",
"registry_strict": "false",
"root_submissions": "true",
"slave_ping_timeout": "15secs",
"slave_reregister_timeout": "10mins",
"user_sorter": "drf",
"version": "false",
"webui_dir": "/home/haosdent/mesos/build/../src/webui",
"work_dir": "/tmp/mesos",
"zk_session_timeout": "10secs"
}
}
```
```
$ curl http://localhost:5050/slave(1)/flags.json 2>/dev/null|jq .
{
"flags": {
"authenticatee": "crammd5",
"cgroups_cpu_enable_pids_and_tids_count": "false",
"cgroups_enable_cfs": "false",
"cgroups_hierarchy": "/sys/fs/cgroup",
"cgroups_limit_swap": "false",
"cgroups_root": "mesos",
"container_disk_watch_interval": "15secs",
"containerizers": "mesos",
"default_role": "*",
"disk_watch_interval": "1mins",
"docker": "docker",
"docker_kill_orphans": "true",
"docker_remove_delay": "6hrs",
"docker_socket": "/var/run/docker.sock",
"docker_stop_timeout": "0ns",
"enforce_container_disk_quota": "false",
"executor_registration_timeout": "1mins",
"executor_shutdown_grace_period": "5secs",
"fetcher_cache_dir": "/tmp/mesos/fetch",
"fetcher_cache_size": "2GB",
"frameworks_home": "",
"gc_delay": "1weeks",
"gc_disk_headroom": "0.1",
"hadoop_home": "",
"help": "false",
"initialize_driver_logging": "true",
"isolation": "posix/cpu,posix/mem",
"launcher_dir": "/home/haosdent/mesos/build/src",
"logbufsecs": "0",
"logging_level": "INFO",
"oversubscribed_resources_interval": "15secs",
"perf_duration": "10secs",
"perf_interval": "1mins",
"qos_correction_interval_min": "0ns",
"quiet": "false",
"recover": "reconnect",
"recovery_timeout": "15mins",
"registration_backoff_factor": "1secs",
"resource_monitoring_interval": "1secs",
"revocable_cpu_low_priority": "true",
"sandbox_directory": "/mnt/mesos/sandbox",
"strict": "true",
"switch_user": "true",
"version": "false",
"work_dir": "/tmp/mesos/0"
}
}
```
Thanks,
haosdent huang
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/
-----------------------------------------------------------
(Updated Aug. 8, 2015, 3:49 a.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-3104
https://issues.apache.org/jira/browse/MESOS-3104
Repository: mesos
Description
-------
Add an endpoint that exposes component flags.
Diffs (updated)
-----
3rdparty/libprocess/include/process/http.hpp 04c2274bbd53b7e7ed770ea201555218559af078
include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807
include/mesos/slave/isolator.hpp 970730f0ffc7f3359685ccf81452856bea1c4a06
include/mesos/slave/isolator.proto 12ea6ac3552c70a172ae9e8506f4b5d96457a3ec
src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33
src/common/protobuf_utils.hpp 312bc61ebb612be64fc5cfbcda8dcaf9663be6c7
src/common/protobuf_utils.cpp 4de176b5b1d7fe71bdb895b19a90a1d9d33d37db
src/master/http.cpp 7d7e562574f3805eef3a4b69c35be29d7dae6c90
src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e
src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80
src/slave/containerizer/isolator.hpp fbb7c8ab908192ae64f34e466c0c24705b3a134b
src/slave/containerizer/isolator.cpp 7973100ea1a58938c50962120b9ecb6722b2ee4e
src/slave/containerizer/isolators/cgroups/cpushare.hpp 54b83a7d67f9cacbca4f9dd9b9b72a3dbc2e5263
src/slave/containerizer/isolators/cgroups/cpushare.cpp ba748c6caec7253b42167e8a4f9b4535da858259
src/slave/containerizer/isolators/cgroups/mem.hpp 47f73c3b75eb550f766b4ee245731fd3b62fdaee
src/slave/containerizer/isolators/cgroups/mem.cpp 48d7fbdff1e733b7d2200b766670e3b6f9902cb3
src/slave/containerizer/isolators/cgroups/perf_event.hpp c1578b11ea1afd30929b4ea6f2c8272fb65454ce
src/slave/containerizer/isolators/cgroups/perf_event.cpp 8c3018de8e77a2a00c90559a995eae2b3678e42f
src/slave/containerizer/isolators/filesystem/posix.hpp 61b81dda8124e15433f27e1683e037bb641d2e8e
src/slave/containerizer/isolators/filesystem/posix.cpp eec510c4f7655d67b33ad90210eeb57fcc910684
src/slave/containerizer/isolators/filesystem/shared.hpp a21bc79d342ece50c4924fc0ebd2186e57b3e899
src/slave/containerizer/isolators/filesystem/shared.cpp 4b4520e30ce1d1818bd3a13260f6dd55ab3900c9
src/slave/containerizer/isolators/namespaces/pid.hpp b22f5ba8e3743bb243ed2c5d204ab4ba21088630
src/slave/containerizer/isolators/namespaces/pid.cpp 35cb6645c9abc0cf533b844e2b2cccf4374bfd68
src/slave/containerizer/isolators/network/port_mapping.hpp 4bca0b81bf69fb4cd75e05aacd02d3e818e32d09
src/slave/containerizer/isolators/network/port_mapping.cpp 88c0cbc61f3f97b084cc3b3fae8999b07d4aa1c7
src/slave/containerizer/isolators/posix.hpp ee9d275e7fe5fc22c1bab86dd0a558cc8ab9044e
src/slave/containerizer/isolators/posix/disk.hpp 85df5d2855513c760b4f767ea105a547f630a5bf
src/slave/containerizer/isolators/posix/disk.cpp c324c79f8d598095d07fbcb26e806a0978c2a520
src/slave/containerizer/mesos/containerizer.hpp 4c1419290645ad4c44360a81618a6cea7ad190df
src/slave/containerizer/mesos/containerizer.cpp 2cbb879888baf6aff76fbd7c1e19027300fb86e3
src/slave/containerizer/provisioner.hpp 541dd4e0b2f0c92a45c00cab6132a2be69654838
src/slave/containerizer/provisioner.cpp efc7e6996ff6663bebaf61989a7e040bd2ad7a5e
src/slave/http.cpp b0fe5f520dfca156548ba8c436d42fc432223f3d
src/slave/paths.cpp 0741616b656e947cb460dd6ee6a9a4852be001c2
src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460
src/slave/slave.cpp 9061e671bea2d52e8c009e92b3d0a4473dca0ad9
src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
src/slave/state.cpp f8a9514f52bf9f886171c2a0e674e5a89f8dbea7
src/tests/containerizer/isolator.hpp 56ac27b0fab35a03888c906d7d7167bb71f06061
src/tests/containerizer/isolator_tests.cpp dd1ae22865ce4467da5ed819e7f0a1cbb834371d
src/tests/containerizer/launch_tests.cpp d211fc0f665988068c67836ef80916828a0df2bd
src/tests/containerizer/mesos_containerizer_tests.cpp 5bc7d408bda0c249e1b66747d8bd87e688362e6c
src/tests/containerizer/port_mapping_tests.cpp 3c9b7c816a03e2994a353674c5963f1dda043124
src/tests/containerizer/rootfs.hpp 55dd4964cfb1ca0e5f7b7616ccc6d5ad2be135d7
Diff: https://reviews.apache.org/r/37023/diff/
Testing
-------
manual test wich mesos-local.
```
$ curl http://localhost:5050/master/flags.json 2>/dev/null|jq .
{
"flags": {
"allocation_interval": "1secs",
"allocator": "HierarchicalDRF",
"authenticate": "false",
"authenticate_slaves": "false",
"authenticators": "crammd5",
"framework_sorter": "drf",
"help": "true",
"initialize_driver_logging": "true",
"log_auto_initialize": "true",
"logbufsecs": "0",
"logging_level": "INFO",
"max_slave_ping_timeouts": "5",
"quiet": "false",
"recovery_slave_removal_limit": "100%",
"registry": "replicated_log",
"registry_fetch_timeout": "1mins",
"registry_store_timeout": "5secs",
"registry_strict": "false",
"root_submissions": "true",
"slave_ping_timeout": "15secs",
"slave_reregister_timeout": "10mins",
"user_sorter": "drf",
"version": "false",
"webui_dir": "/home/haosdent/mesos/build/../src/webui",
"work_dir": "/tmp/mesos",
"zk_session_timeout": "10secs"
}
}
```
```
$ curl http://localhost:5050/slave(1)/flags.json 2>/dev/null|jq .
{
"flags": {
"authenticatee": "crammd5",
"cgroups_cpu_enable_pids_and_tids_count": "false",
"cgroups_enable_cfs": "false",
"cgroups_hierarchy": "/sys/fs/cgroup",
"cgroups_limit_swap": "false",
"cgroups_root": "mesos",
"container_disk_watch_interval": "15secs",
"containerizers": "mesos",
"default_role": "*",
"disk_watch_interval": "1mins",
"docker": "docker",
"docker_kill_orphans": "true",
"docker_remove_delay": "6hrs",
"docker_socket": "/var/run/docker.sock",
"docker_stop_timeout": "0ns",
"enforce_container_disk_quota": "false",
"executor_registration_timeout": "1mins",
"executor_shutdown_grace_period": "5secs",
"fetcher_cache_dir": "/tmp/mesos/fetch",
"fetcher_cache_size": "2GB",
"frameworks_home": "",
"gc_delay": "1weeks",
"gc_disk_headroom": "0.1",
"hadoop_home": "",
"help": "false",
"initialize_driver_logging": "true",
"isolation": "posix/cpu,posix/mem",
"launcher_dir": "/home/haosdent/mesos/build/src",
"logbufsecs": "0",
"logging_level": "INFO",
"oversubscribed_resources_interval": "15secs",
"perf_duration": "10secs",
"perf_interval": "1mins",
"qos_correction_interval_min": "0ns",
"quiet": "false",
"recover": "reconnect",
"recovery_timeout": "15mins",
"registration_backoff_factor": "1secs",
"resource_monitoring_interval": "1secs",
"revocable_cpu_low_priority": "true",
"sandbox_directory": "/mnt/mesos/sandbox",
"strict": "true",
"switch_user": "true",
"version": "false",
"work_dir": "/tmp/mesos/0"
}
}
```
Thanks,
haosdent huang
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/
-----------------------------------------------------------
(Updated Aug. 2, 2015, 9:28 a.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-3104
https://issues.apache.org/jira/browse/MESOS-3104
Repository: mesos
Description
-------
Add an endpoint that exposes component flags.
Diffs
-----
src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f
src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc
src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544
src/slave/http.cpp b0fe5f520dfca156548ba8c436d42fc432223f3d
src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460
src/slave/slave.cpp 6b21db973dc95dd5eb2238eebe697db9dd063ef1
Diff: https://reviews.apache.org/r/37023/diff/
Testing (updated)
-------
manual test wich mesos-local.
```
$ curl http://localhost:5050/master/flags.json 2>/dev/null|jq .
{
"flags": {
"allocation_interval": "1secs",
"allocator": "HierarchicalDRF",
"authenticate": "false",
"authenticate_slaves": "false",
"authenticators": "crammd5",
"framework_sorter": "drf",
"help": "true",
"initialize_driver_logging": "true",
"log_auto_initialize": "true",
"logbufsecs": "0",
"logging_level": "INFO",
"max_slave_ping_timeouts": "5",
"quiet": "false",
"recovery_slave_removal_limit": "100%",
"registry": "replicated_log",
"registry_fetch_timeout": "1mins",
"registry_store_timeout": "5secs",
"registry_strict": "false",
"root_submissions": "true",
"slave_ping_timeout": "15secs",
"slave_reregister_timeout": "10mins",
"user_sorter": "drf",
"version": "false",
"webui_dir": "/home/haosdent/mesos/build/../src/webui",
"work_dir": "/tmp/mesos",
"zk_session_timeout": "10secs"
}
}
```
```
$ curl http://localhost:5050/slave(1)/flags.json 2>/dev/null|jq .
{
"flags": {
"authenticatee": "crammd5",
"cgroups_cpu_enable_pids_and_tids_count": "false",
"cgroups_enable_cfs": "false",
"cgroups_hierarchy": "/sys/fs/cgroup",
"cgroups_limit_swap": "false",
"cgroups_root": "mesos",
"container_disk_watch_interval": "15secs",
"containerizers": "mesos",
"default_role": "*",
"disk_watch_interval": "1mins",
"docker": "docker",
"docker_kill_orphans": "true",
"docker_remove_delay": "6hrs",
"docker_socket": "/var/run/docker.sock",
"docker_stop_timeout": "0ns",
"enforce_container_disk_quota": "false",
"executor_registration_timeout": "1mins",
"executor_shutdown_grace_period": "5secs",
"fetcher_cache_dir": "/tmp/mesos/fetch",
"fetcher_cache_size": "2GB",
"frameworks_home": "",
"gc_delay": "1weeks",
"gc_disk_headroom": "0.1",
"hadoop_home": "",
"help": "false",
"initialize_driver_logging": "true",
"isolation": "posix/cpu,posix/mem",
"launcher_dir": "/home/haosdent/mesos/build/src",
"logbufsecs": "0",
"logging_level": "INFO",
"oversubscribed_resources_interval": "15secs",
"perf_duration": "10secs",
"perf_interval": "1mins",
"qos_correction_interval_min": "0ns",
"quiet": "false",
"recover": "reconnect",
"recovery_timeout": "15mins",
"registration_backoff_factor": "1secs",
"resource_monitoring_interval": "1secs",
"revocable_cpu_low_priority": "true",
"sandbox_directory": "/mnt/mesos/sandbox",
"strict": "true",
"switch_user": "true",
"version": "false",
"work_dir": "/tmp/mesos/0"
}
}
```
Thanks,
haosdent huang
Re: Review Request 37023: Add an endpoint that exposes component
flags.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/
-----------------------------------------------------------
(Updated Aug. 2, 2015, 9:22 a.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-3104
https://issues.apache.org/jira/browse/MESOS-3104
Repository: mesos
Description
-------
Add an endpoint that exposes component flags.
Diffs (updated)
-----
src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f
src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc
src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544
src/slave/http.cpp b0fe5f520dfca156548ba8c436d42fc432223f3d
src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460
src/slave/slave.cpp 6b21db973dc95dd5eb2238eebe697db9dd063ef1
Diff: https://reviews.apache.org/r/37023/diff/
Testing
-------
Thanks,
haosdent huang