[jira] [Commented] (OAK-9222) results potential improvements

["Angela Schreiber (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-9222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200134#comment-17200134 ] 

Angela Schreiber commented on OAK-9222:
---------------------------------------

based on the results for the various improvements it seems that readonly sessions benefit from eagerly loading permission entries while sessions that include writes or repeated refreshes perform better with a upper boundary. in absence of a mechanism that flags a given sessions as read-only upon login, the threshold can be enabled as soon as the permission provider is being marked for refresh. at the same time the various improvements as listed above were moved to a separate cache-strategy class to simplify changing the different params -> benchmarks for bigger threshold ('cachestrategy-1) and for threshold==maxsize (cachestrategy-2).

> results potential improvements
> ------------------------------
>
>                 Key: OAK-9222
>                 URL: https://issues.apache.org/jira/browse/OAK-9222
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>            Reporter: Angela Schreiber
>            Priority: Major
>         Attachments: HasPermissionHasItemGetItemTest_isfullyloaded_20200916_092114.txt, HasPermissionHasItemGetItemTest_lazyinit_20200911_185719.txt, HasPermissionHasItemGetItemTest_upperbound_20200915_182525.txt, HasPrivilegesHasItemGetItemTest_isfullyloaded_20200916_101741.txt, HasPrivilegesHasItemGetItemTest_lazyinit_20200911_185719.txt, HasPrivilegesHasItemGetItemTest_upperbound_20200915_174941.txt, RefreshHasItemGetItemTest_isfullyloaded_20200916_103829.txt, RefreshHasItemGetItemTest_lazyinit_20200911_183632.txt, RefreshHasItemGetItemTest_upperbound_20200915_172917.txt, RefreshHasPrivPermHasItemGetItemTest_isfullyloaded_20200916_094436.txt, RefreshHasPrivPermHasItemGetItemTest_lazyinit_20200911_194538.txt, RefreshHasPrivPermHasItemGetItemTest_upperbound_20200915_182525.txt, SaveHasItemGetItemTest_isfullyloaded_20200916_110155.txt, SaveHasItemGetItemTest_lazyinit_20200915_152111.txt, SaveHasItemGetItemTest_upperbound_20200915_170411.txt
>
>
> the following potential improvements have been identified:
> - lazy init of the permission-entry-cache: initialize the cache on demand (in particular after calling Session.save())
> - remember if entries for all principals have been fully loaded (in which case using the pathEntryMap is possible)
> - introduce a threshold for eagerly loading entries for principals with few access controlled paths (<maxpaths)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)