You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2011/06/14 21:18:47 UTC
[jira] [Created] (WICKET-3794) Simplify BrowserInfoPage by using
InterceptData
Simplify BrowserInfoPage by using InterceptData
-----------------------------------------------
Key: WICKET-3794
URL: https://issues.apache.org/jira/browse/WICKET-3794
Project: Wicket
Issue Type: Improvement
Components: wicket-core
Affects Versions: 1.5-RC4
Reporter: Martin Grigorov
Assignee: Martin Grigorov
Fix For: 1.5-RC5
http://localhost:8080/hellobrowser/ application is broken in current trunk.
The problem is that it calculates the "continueTo" url too soon (before render time) and the generated url is wrong relative to the URL of the page that is going to be rendered.
The whole concept can be greatly simplified by using org.apache.wicket.RestartResponseAtInterceptPageException.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3794) Simplify BrowserInfoPage by using
InterceptData
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049361#comment-13049361 ]
Martin Grigorov commented on WICKET-3794:
-----------------------------------------
Please create a demo app and attach it here if it doesn't work.
> Simplify BrowserInfoPage by using InterceptData
> -----------------------------------------------
>
> Key: WICKET-3794
> URL: https://issues.apache.org/jira/browse/WICKET-3794
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Affects Versions: 1.5-RC4
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Fix For: 1.5-RC5
>
>
> http://localhost:8080/hellobrowser/ application is broken in current trunk.
> The problem is that it calculates the "continueTo" url too soon (before render time) and the generated url is wrong relative to the URL of the page that is going to be rendered.
> The whole concept can be greatly simplified by using org.apache.wicket.RestartResponseAtInterceptPageException.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3794) Simplify BrowserInfoPage by using
InterceptData
Posted by "Adam Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049358#comment-13049358 ]
Adam Gray commented on WICKET-3794:
-----------------------------------
How does this handle already being at an intercept page? For instance, a login page that needs to check browser compatibility. Will the second continueToOriginalDestination() work correctly?
Example:
http://www.example.com/reports
intercept
http://www.example.com/login
intercept
http://www.example.com/browserInfo
After the browser info is collected, will the original destination for /reports still be available from the login page? I didn't think you could nest intercept pages like this.
> Simplify BrowserInfoPage by using InterceptData
> -----------------------------------------------
>
> Key: WICKET-3794
> URL: https://issues.apache.org/jira/browse/WICKET-3794
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Affects Versions: 1.5-RC4
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Fix For: 1.5-RC5
>
>
> http://localhost:8080/hellobrowser/ application is broken in current trunk.
> The problem is that it calculates the "continueTo" url too soon (before render time) and the generated url is wrong relative to the URL of the page that is going to be rendered.
> The whole concept can be greatly simplified by using org.apache.wicket.RestartResponseAtInterceptPageException.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-3794) Simplify BrowserInfoPage by using
InterceptData
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-3794.
-------------------------------------
Resolution: Fixed
> Simplify BrowserInfoPage by using InterceptData
> -----------------------------------------------
>
> Key: WICKET-3794
> URL: https://issues.apache.org/jira/browse/WICKET-3794
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Affects Versions: 1.5-RC4
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Fix For: 1.5-RC5
>
>
> http://localhost:8080/hellobrowser/ application is broken in current trunk.
> The problem is that it calculates the "continueTo" url too soon (before render time) and the generated url is wrong relative to the URL of the page that is going to be rendered.
> The whole concept can be greatly simplified by using org.apache.wicket.RestartResponseAtInterceptPageException.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira