You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/11/05 00:13:56 UTC
[GitHub] [iceberg] jackye1995 opened a new pull request #3473: AWS: cleanup all tests to obey Iceberg codestyle
jackye1995 opened a new pull request #3473:
URL: https://github.com/apache/iceberg/pull/3473
The module was added when I was not really familiar with the Iceberg code style, as recently there are many people referencing the AWS module to implement custom Catalog and FileIO, we should make it consistent with the rest of the codebase. What I did include:
1. rename test classes as `TestXXXX`
2. rename test methods as `testXXX`
3. remove AWS SDK v1 classes
4. move tests that were in the wrong class
5. remove direct use of Java data structure like HashMap
@yyanyy @danielcweeks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #3473: AWS: cleanup all tests to obey Iceberg codestyle
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #3473:
URL: https://github.com/apache/iceberg/pull/3473#issuecomment-962492882
Got 2 approvals, thanks for the review @kbendick @yyanyy , I will merge on Monday if there is no additional comments received.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #3473: AWS: cleanup all tests to obey Iceberg codestyle
Posted by GitBox <gi...@apache.org>.
jackye1995 merged pull request #3473:
URL: https://github.com/apache/iceberg/pull/3473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org