You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/02/04 20:52:54 UTC

[GitHub] [qpid-dispatch] kgiusti commented on pull request #1018: DISPATCH-1951: fix race in initial delivery transfer

kgiusti commented on pull request #1018:
URL: https://github.com/apache/qpid-dispatch/pull/1018#issuecomment-773596829


   > This patch does neaten things up a bit. I would remove the asserts that appear to be there for testing. Does it fix a test failure/crash?
   
   The assert()s on the delivery refcounts don't fix a bug.  They provide a hint to coverity that the decrefs shouldn't be interpreted as freeing the delivery (sometimes works), and ensure that the caller fulfills the method's assumption that an extra reference count is held during the call (more bug prevention than fix).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org