You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/01/26 11:59:36 UTC
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8247: tools/ci: Update docker to ubuntu 22.04
xiaoxiang781216 opened a new pull request, #8247:
URL: https://github.com/apache/nuttx/pull/8247
## Summary
g++ need update to the new version for libcxx 15.0.7.
## Impact
Docker
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on pull request #8247: tools/ci: Update docker to ubuntu 22.04
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on PR #8247:
URL: https://github.com/apache/nuttx/pull/8247#issuecomment-1488027215
> Another possible method is we build Renesas toolchain in Ubuntu 18.04 and use it in Ubuntu 22.04.
But most probably we will need to host binaries somewhere. Or create a GitHub repo with Renesas toolchain source code and setup GitHub CI to bake binaries. But that is quite a big infrastructure effort I think.
Maybe we can contact Renesas and ask for help? Is that an option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8247: tools/ci: Update docker to ubuntu 22.04
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8247:
URL: https://github.com/apache/nuttx/pull/8247#issuecomment-1404915642
@btashton do you know why docker fail here:
```
Dockerfile:153
--------------------
152 | # Install gcc
153 | >>> RUN cd renesas-tools/source/gcc && \
154 | >>> chmod +x ./contrib/download_prerequisites ./configure ./move-if-change ./libgcc/mkheader.sh && \
155 | >>> ./contrib/download_prerequisites && \
156 | >>> sed -i '1s/^/@documentencoding ISO-8859-1\n/' ./gcc/doc/gcc.texi && \
157 | >>> sed -i 's/@tex/\n&/g' ./gcc/doc/gcc.texi && sed -i 's/@end tex/\n&/g' ./gcc/doc/gcc.texi && \
158 | >>> mkdir -p /tools/renesas-tools/build/gcc && cd /tools/renesas-tools/build/gcc && \
159 | >>> /tools/renesas-tools/source/gcc/configure --target=rx-elf --prefix=/tools/renesas-toolchain/rx-elf-gcc \
160 | >>> --disable-shared --disable-multilib --disable-libssp --disable-libstdcxx-pch --disable-werror --enable-lto \
161 | >>> --enable-gold --with-pkgversion=GCC_Build_1.02 --with-newlib --enable-languages=c && \
162 | >>> make && make install
163 | ENV PATH="/tools/renesas-toolchain/rx-elf-gcc/bin:$PATH"
--------------------
ERROR: failed to solve: process "/bin/sh -c cd renesas-tools/source/gcc && chmod +x ./contrib/download_prerequisites ./configure ./move-if-change ./libgcc/mkheader.sh && ./contrib/download_prerequisites && sed -i '1s/^/@documentencoding ISO-8859-1\\n/' ./gcc/doc/gcc.texi && sed -i 's/@tex/\\n&/g' ./gcc/doc/gcc.texi && sed -i 's/@end tex/\\n&/g' ./gcc/doc/gcc.texi && mkdir -p /tools/renesas-tools/build/gcc && cd /tools/renesas-tools/build/gcc && /tools/renesas-tools/source/gcc/configure --target=rx-elf --prefix=/tools/renesas-toolchain/rx-elf-gcc --disable-shared --disable-multilib --disable-libssp --disable-libstdcxx-pch --disable-werror --enable-lto --enable-gold --with-pkgversion=GCC_Build_1.02 --with-newlib --enable-languages=c && make && make install" did not complete successfully: exit code: 1
Error: buildx failed with: ERROR: failed to solve: process "/bin/sh -c cd renesas-tools/source/gcc && chmod +x ./contrib/download_prerequisites ./configure ./move-if-change ./libgcc/mkheader.sh && ./contrib/download_prerequisites && sed -i '1s/^/@documentencoding ISO-8859-1\\n/' ./gcc/doc/gcc.texi && sed -i 's/@tex/\\n&/g' ./gcc/doc/gcc.texi && sed -i 's/@end tex/\\n&/g' ./gcc/doc/gcc.texi && mkdir -p /tools/renesas-tools/build/gcc && cd /tools/renesas-tools/build/gcc && /tools/renesas-tools/source/gcc/configure --target=rx-elf --prefix=/tools/renesas-toolchain/rx-elf-gcc --disable-shared --disable-multilib --disable-libssp --disable-libstdcxx-pch --disable-werror --enable-lto --enable-gold --with-pkgversion=GCC_Build_1.02 --with-newlib --enable-languages=c && make && make install" did not complete successfully: exit code: 1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8247: tools/ci: Update docker to ubuntu 22.04
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8247:
URL: https://github.com/apache/nuttx/pull/8247#issuecomment-1487972294
> > Yes, that's why I want to upgrade Ubuntu to 22.04 since we can get the new version of gcc automatically.
>
> I'm not sure if that is really going to help us in this situation. In theory, a newer version of gcc is available, but we would still be restricted to using the latest version of the toolchain which Renesas provides, 8.3.0.
>
it's fine that we use Renesas arch with 8.3.0, but not good to simulator.
> > If we can download it automatically, I think it's fine.
>
> As far as I'm aware, the login credentials would need to be sent as part of the request, which isn't really viable.
Another possible method is we build Renesas toolchain in Ubuntu 18.04 and use it in Ubuntu 22.04.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8247: tools/ci: Update docker to ubuntu 22.04
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #8247:
URL: https://github.com/apache/nuttx/pull/8247#discussion_r1297453062
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -295,7 +295,7 @@ RUN pip3 install setuptools
RUN pip3 install wheel
RUN pip3 install cmake-format
# Install CodeChecker and use it to statically analyze the code.
-RUN pip3 install CodeChecker
+# RUN pip3 install CodeChecker
Review Comment:
So we do not need CodeChecker?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8247: tools/ci: Update docker to ubuntu 22.04
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8247:
URL: https://github.com/apache/nuttx/pull/8247#issuecomment-1486178492
> @xiaoxiang781216 I had a brief look into this. Renesas hosts the sources for their, latest toolchain, 8.3.0 [here](https://llvm-gcc-renesas.com/rx/rx-latest-source-code/). As well as a pre-built variant, behind a log-in [here](https://llvm-gcc-renesas.com/rx-download-toolchains/).
>
> I did attempt to build the newer toolchain, using the existing method in the Dockerfile, but without any success. Is it possible here to use the pre-built toolchain, assuming it can be accessed?
If we can download it automatically, I think it's fine.
> Additionally, I'm doubtful that libcxx (from #8244) would compile with GCC 8.3.0.
Yes, that's why I want to upgrade Ubuntu to 22.04 since we can get the new version of gcc automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] g2gps commented on pull request #8247: tools/ci: Update docker to ubuntu 22.04
Posted by "g2gps (via GitHub)" <gi...@apache.org>.
g2gps commented on PR #8247:
URL: https://github.com/apache/nuttx/pull/8247#issuecomment-1487944462
> Yes, that's why I want to upgrade Ubuntu to 22.04 since we can get the new version of gcc automatically.
I'm not sure if that is really going to help us in this situation. In theory, a newer version of gcc is available, but we would still be restricted to using the latest version of the toolchain which Renesas provides, 8.3.0.
> If we can download it automatically, I think it's fine.
As far as I'm aware, the login credentials would need to be sent as part of the request, which isn't really viable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8247: tools/ci: Update docker to ubuntu 22.04
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8247:
URL: https://github.com/apache/nuttx/pull/8247#issuecomment-1489031748
Anyway, I try to upgrade the final image to Ubuntu 22.04, but build all toolchain with 20.04. Let's see what's happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko merged pull request #8247: tools/ci: Update docker to ubuntu 22.04
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko merged PR #8247:
URL: https://github.com/apache/nuttx/pull/8247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8247: tools/ci: Update docker to ubuntu 22.04
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #8247:
URL: https://github.com/apache/nuttx/pull/8247#discussion_r1130676073
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -13,7 +13,7 @@
# License for the specific language governing permissions and limitations
# under the License.
-FROM ubuntu:20.04 AS builder-base
+FROM ubuntu:22.04 AS builder-base
Review Comment:
@xiaoxiang781216 I tried to build image locally and the first error is fixed by adding `bzip2` after `xz-utils`.
But even with that I can't build an image because of error:
```
#54 446.3 /tools/renesas-tools/source/gcc/gcc/reload1.c: In function 'void init_reload()':
#54 446.3 /tools/renesas-tools/source/gcc/gcc/reload1.c:89:24: error: use of an operand of type 'bool' in 'operator++' is forbidden in C++17
#54 446.3 89 | (this_target_reload->x_spill_indirect_levels)
#54 446.3 | ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
#54 446.3 /tools/renesas-tools/source/gcc/gcc/reload1.c:443:7: note: in expansion of macro 'spill_indirect_levels'
#54 446.3 443 | spill_indirect_levels++;
#54 446.3 | ^~~~~~~~~~~~~~~~~~~~~
#54 446.3 /tools/renesas-tools/source/gcc/gcc/reload1.c: In function 'void elimination_effects(rtx, machine_mode)':
#54 446.3 /tools/renesas-tools/source/gcc/gcc/reload1.c:3055:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
#54 446.3 3055 | if (code == POST_MODIFY || code == PRE_MODIFY)
#54 446.3 | ^~
#54 446.3 /tools/renesas-tools/source/gcc/gcc/reload1.c:3059:5: note: here
#54 446.3 3059 | case STRICT_LOW_PART:
#54 446.3 | ^~~~
#54 446.4 make[2]: Leaving directory '/tools/renesas-tools/build/gcc/gcc'
#54 446.4 make[2]: *** [Makefile:1059: reload1.o] Error 1
#54 446.4 make[1]: *** [Makefile:3895: all-gcc] Error 2
#54 446.4 make[1]: Leaving directory '/tools/renesas-tools/build/gcc'
#54 446.4 make: *** [Makefile:842: all] Error 2
```
I'm not sure, but maybe we can seek for an upgrade to renesas toolchain to move forward with `ubuntu:22.04` based images
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] g2gps commented on pull request #8247: tools/ci: Update docker to ubuntu 22.04
Posted by "g2gps (via GitHub)" <gi...@apache.org>.
g2gps commented on PR #8247:
URL: https://github.com/apache/nuttx/pull/8247#issuecomment-1486066716
@xiaoxiang781216 I had a brief look into this. Renesas hosts the sources for their, latest toolchain, 8.3.0 [here](https://llvm-gcc-renesas.com/rx/rx-latest-source-code/). As well as a pre-built variant, behind a log-in [here](https://llvm-gcc-renesas.com/rx-download-toolchains/).
I did attempt to build the newer toolchain, using the existing method in the Dockerfile, but without any success. Is it possible here to use the pre-built toolchain, assuming it can be accessed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8247: tools/ci: Update docker to ubuntu 22.04
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #8247:
URL: https://github.com/apache/nuttx/pull/8247#discussion_r1178722295
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -13,7 +13,7 @@
# License for the specific language governing permissions and limitations
# under the License.
-FROM ubuntu:20.04 AS builder-base
+FROM ubuntu:22.04 AS builder-base
Review Comment:
Adding bzip2 is still needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8247: tools/ci: Update docker to ubuntu 22.04
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8247:
URL: https://github.com/apache/nuttx/pull/8247#issuecomment-1681654159
@pkarashchenko ci could generate the new docker image, please merge this patch, so we can continue fix the issue found by https://github.com/apache/nuttx/pull/8244.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8247: tools/ci: Update docker to ubuntu 22.04
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8247:
URL: https://github.com/apache/nuttx/pull/8247#discussion_r1297575471
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -295,7 +295,7 @@ RUN pip3 install setuptools
RUN pip3 install wheel
RUN pip3 install cmake-format
# Install CodeChecker and use it to statically analyze the code.
-RUN pip3 install CodeChecker
+# RUN pip3 install CodeChecker
Review Comment:
codechecker ever report the ci error since there are many false positive warnings, so it's safe to temp disable it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on pull request #8247: tools/ci: Update docker to ubuntu 22.04
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on PR #8247:
URL: https://github.com/apache/nuttx/pull/8247#issuecomment-1488028985
> but not good to simulator.
@xiaoxiang781216 what do you mean? Do we used simulation of Renesas? Or you are talking that Renesas boards will be restricted to use C++ because of GCC version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8247: tools/ci: Update docker to ubuntu 22.04
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8247:
URL: https://github.com/apache/nuttx/pull/8247#issuecomment-1489030302
> > but not good to simulator.
>
> @xiaoxiang781216 what do you mean?
I mean it isn't good to limit Ubuntu to 20.04(can't upgrade to 22.04) just because Renesas gcc toolchain can't pass the build in 22.04.
> Do we used simulation of Renesas?
No.
> Or you are talking that Renesas boards will be restricted to use C++ because of GCC version?
Yes, since Renesas just provide gcc with 8.3.0, it's reasonable that some new c++ feature can't pass the build for Renesas boards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] g2gps commented on pull request #8247: tools/ci: Update docker to ubuntu 22.04
Posted by "g2gps (via GitHub)" <gi...@apache.org>.
g2gps commented on PR #8247:
URL: https://github.com/apache/nuttx/pull/8247#issuecomment-1486124334
Additionally, I'm doubtful that libcxx (from #8244) would compile with GCC 8.3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on pull request #8247: tools/ci: Update docker to ubuntu 22.04
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on PR #8247:
URL: https://github.com/apache/nuttx/pull/8247#issuecomment-1405152661
@xiaoxiang781216 have you tried to build Docker image locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org