You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/03/10 19:09:25 UTC
Review Request 31903: Added Python binding for the acceptOffers API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31903/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
Bugs: MESOS-2428
https://issues.apache.org/jira/browse/MESOS-2428
Repository: mesos
Description
-------
Added Python binding for the acceptOffers API.
Diffs
-----
src/examples/python/test_framework.py 27106147900f8b5dd2ea0443f5658902ff1145e4
src/python/interface/src/mesos/interface/__init__.py f3d96a455dc8b66fc4527af1b3dee2f8841b29dd
src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp a6980002202b829b40e85188bfb291e5d22c9a26
src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp bb1884597731c73f4815069ceb940cf067790670
Diff: https://reviews.apache.org/r/31903/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 31903: Added Python binding for the acceptOffers
API.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31903/#review75960
-----------------------------------------------------------
Patch looks great!
Reviews applied: [31903]
All tests passed.
- Mesos ReviewBot
On March 10, 2015, 6:09 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31903/
> -----------------------------------------------------------
>
> (Updated March 10, 2015, 6:09 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-2428
> https://issues.apache.org/jira/browse/MESOS-2428
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Python binding for the acceptOffers API.
>
>
> Diffs
> -----
>
> src/examples/python/test_framework.py 27106147900f8b5dd2ea0443f5658902ff1145e4
> src/python/interface/src/mesos/interface/__init__.py f3d96a455dc8b66fc4527af1b3dee2f8841b29dd
> src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp a6980002202b829b40e85188bfb291e5d22c9a26
> src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp bb1884597731c73f4815069ceb940cf067790670
>
> Diff: https://reviews.apache.org/r/31903/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 31903: Added Python binding for the acceptOffers
API.
Posted by Jie Yu <yu...@gmail.com>.
> On March 11, 2015, 7:30 p.m., Ben Mahler wrote:
> > This patch looks good, but can you please include updates to the CHANGELOG and Upgrades documents in this review chain to capture this API change in 0.23.0?
Added ticket https://issues.apache.org/jira/browse/MESOS-2481 to track.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31903/#review76110
-----------------------------------------------------------
On March 10, 2015, 6:09 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31903/
> -----------------------------------------------------------
>
> (Updated March 10, 2015, 6:09 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-2428
> https://issues.apache.org/jira/browse/MESOS-2428
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Python binding for the acceptOffers API.
>
>
> Diffs
> -----
>
> src/examples/python/test_framework.py 27106147900f8b5dd2ea0443f5658902ff1145e4
> src/python/interface/src/mesos/interface/__init__.py f3d96a455dc8b66fc4527af1b3dee2f8841b29dd
> src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp a6980002202b829b40e85188bfb291e5d22c9a26
> src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp bb1884597731c73f4815069ceb940cf067790670
>
> Diff: https://reviews.apache.org/r/31903/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 31903: Added Python binding for the acceptOffers
API.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31903/#review76110
-----------------------------------------------------------
Ship it!
This patch looks good, but can you please include updates to the CHANGELOG and Upgrades documents in this review chain to capture this API change in 0.23.0?
src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp
<https://reviews.apache.org/r/31903/#comment123529>
Can we get some newlines here?
src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp
<https://reviews.apache.org/r/31903/#comment123531>
newline here?
src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp
<https://reviews.apache.org/r/31903/#comment123530>
Can we get some newlines here?
src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp
<https://reviews.apache.org/r/31903/#comment123532>
newline here?
- Ben Mahler
On March 10, 2015, 6:09 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31903/
> -----------------------------------------------------------
>
> (Updated March 10, 2015, 6:09 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-2428
> https://issues.apache.org/jira/browse/MESOS-2428
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Python binding for the acceptOffers API.
>
>
> Diffs
> -----
>
> src/examples/python/test_framework.py 27106147900f8b5dd2ea0443f5658902ff1145e4
> src/python/interface/src/mesos/interface/__init__.py f3d96a455dc8b66fc4527af1b3dee2f8841b29dd
> src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp a6980002202b829b40e85188bfb291e5d22c9a26
> src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp bb1884597731c73f4815069ceb940cf067790670
>
> Diff: https://reviews.apache.org/r/31903/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 31903: Added Python binding for the acceptOffers
API.
Posted by Jie Yu <yu...@gmail.com>.
> On March 11, 2015, 9:38 p.m., Michael Park wrote:
> > src/examples/python/test_framework.py, line 98
> > <https://reviews.apache.org/r/31903/diff/1/?file=890454#file890454line98>
> >
> > Realized that the Java test framework has a filter here but this one doesn't. Do we want one here too? or is it more or less arbitrary?
Just want to keep the existing semantics in this patch:)
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31903/#review76129
-----------------------------------------------------------
On March 10, 2015, 6:09 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31903/
> -----------------------------------------------------------
>
> (Updated March 10, 2015, 6:09 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-2428
> https://issues.apache.org/jira/browse/MESOS-2428
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Python binding for the acceptOffers API.
>
>
> Diffs
> -----
>
> src/examples/python/test_framework.py 27106147900f8b5dd2ea0443f5658902ff1145e4
> src/python/interface/src/mesos/interface/__init__.py f3d96a455dc8b66fc4527af1b3dee2f8841b29dd
> src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp a6980002202b829b40e85188bfb291e5d22c9a26
> src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp bb1884597731c73f4815069ceb940cf067790670
>
> Diff: https://reviews.apache.org/r/31903/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 31903: Added Python binding for the acceptOffers
API.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31903/#review76129
-----------------------------------------------------------
Looks good to me :)
src/examples/python/test_framework.py
<https://reviews.apache.org/r/31903/#comment123571>
Realized that the Java test framework has a filter here but this one doesn't. Do we want one here too? or is it more or less arbitrary?
- Michael Park
On March 10, 2015, 6:09 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31903/
> -----------------------------------------------------------
>
> (Updated March 10, 2015, 6:09 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-2428
> https://issues.apache.org/jira/browse/MESOS-2428
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Python binding for the acceptOffers API.
>
>
> Diffs
> -----
>
> src/examples/python/test_framework.py 27106147900f8b5dd2ea0443f5658902ff1145e4
> src/python/interface/src/mesos/interface/__init__.py f3d96a455dc8b66fc4527af1b3dee2f8841b29dd
> src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp a6980002202b829b40e85188bfb291e5d22c9a26
> src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp bb1884597731c73f4815069ceb940cf067790670
>
> Diff: https://reviews.apache.org/r/31903/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>