You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/07/22 13:12:28 UTC
[GitHub] [rocketmq] thenx-wei opened a new pull request #2186: Optimize the code: switch statements containing the same code in different branches
thenx-wei opened a new pull request #2186:
URL: https://github.com/apache/rocketmq/pull/2186
…erent branches.
## What is the purpose of the change
switch statements containing the same code in different branches
## Brief changelog
switch statements containing the same code in different branches
## Verifying this change
switch statements containing the same code in different branches
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2186: Optimize the code: switch statements containing the same code in different branches
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2186:
URL: https://github.com/apache/rocketmq/pull/2186#issuecomment-662457920
[](https://coveralls.io/builds/32249541)
Coverage increased (+0.1%) to 51.331% when pulling **ee44f17303e7f72c396a08206d1c3114a01d0e88 on thenx-wei:develop** into **fac30c3596d5577cd80a52af9ad89a0839016137 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] minny-park commented on pull request #2186: [ISSUE #2193] Switch statements containing the same code in different branches
Posted by GitBox <gi...@apache.org>.
minny-park commented on pull request #2186:
URL: https://github.com/apache/rocketmq/pull/2186#issuecomment-664863970
@RongtongJin Can we combine this submission ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] vongosling closed pull request #2186: [ISSUE #2193] Switch statements containing the same code in different branches
Posted by GitBox <gi...@apache.org>.
vongosling closed pull request #2186:
URL: https://github.com/apache/rocketmq/pull/2186
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] vongosling commented on pull request #2186: [ISSUE #2193] Switch statements containing the same code in different branches
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #2186:
URL: https://github.com/apache/rocketmq/pull/2186#issuecomment-665416358
Generated By:JavaCC: Do not edit this line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #2186: Optimize the code: switch statements containing the same code in different branches
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #2186:
URL: https://github.com/apache/rocketmq/pull/2186#issuecomment-662886446
Hi, @thenx-wei , plz follow [RocketMQ community operation conventions](https://docs.google.com/document/d/1fo_Z4_nUOyykkmQOE2kEmxcLwhhFiQENQwQiy852XUM/edit), create an issue before submitting a pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org