[GitHub] [spark] HyukjinKwon commented on a change in pull request #35363: [SPARK-38066][SQL] evaluateEquality should ignore attribute without min/max ColumnStat

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #35363:
URL: https://github.com/apache/spark/pull/35363#discussion_r798188000



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala
##########
@@ -307,7 +307,7 @@ case class FilterEstimation(plan: Filter) extends Logging {
       attr: Attribute,
       literal: Literal,
       update: Boolean): Option[Double] = {
-    if (!colStatsMap.contains(attr)) {
+    if (!colStatsMap.contains(attr) || !colStatsMap.hasMinMaxStats(attr)) {

Review comment:
       Can we add a unitest?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org