You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Jinhui Du (JIRA)" <ji...@apache.org> on 2009/04/21 11:40:47 UTC

[jira] Created: (SHINDIG-1025) php json_decode can't process the json filed that doesn't have quotes.

php json_decode can't process the json filed that doesn't have quotes.
----------------------------------------------------------------------

                 Key: SHINDIG-1025
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1025
             Project: Shindig
          Issue Type: Bug
          Components: PHP
    Affects Versions: trunk
            Reporter: Jinhui Du
            Priority: Minor
             Fix For: trunk


It only affect php not java implementation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-1025) Fixes canonicaldb.json file. php json_decode can't process the json filed that doesn't have quotes.

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701121#action_12701121 ] 

Paul Lindner commented on SHINDIG-1025:
---------------------------------------

I checked in the fix for canonicaldb.json,

I'll let one of the PHP folks commit the other half.

Thanks for spotting this!


> Fixes canonicaldb.json file. php json_decode can't process the json filed that doesn't have quotes.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1025
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1025
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>    Affects Versions: trunk
>            Reporter: Jinhui Du
>            Priority: Minor
>             Fix For: trunk
>
>
> It only affect php not java implementation.
> The url for code review: 
> http://codereview.appspot.com/40123/show

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SHINDIG-1025) Fixes canonicaldb.json file. php json_decode can't process the json filed that doesn't have quotes.

Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Chabot resolved SHINDIG-1025.
-----------------------------------

    Resolution: Fixed
      Assignee: Chris Chabot

I've committed the additional $jsonDecoded != null check.

However, I am curious where / what platform / php version your seeing this behavior? While the documentation states that json_decode will return false on a json structure that is deeper then 127 nestings, on plain failed decoding it always returns the original string to me, both on a mac and a linux host

> Fixes canonicaldb.json file. php json_decode can't process the json filed that doesn't have quotes.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1025
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1025
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>    Affects Versions: trunk
>            Reporter: Jinhui Du
>            Assignee: Chris Chabot
>            Priority: Minor
>             Fix For: trunk
>
>
> It only affect php not java implementation.
> The url for code review: 
> http://codereview.appspot.com/40123/show

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-1025) Fixes canonicaldb.json file. php json_decode can't process the json filed that doesn't have quotes.

Posted by "Jinhui Du (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jinhui Du updated SHINDIG-1025:
-------------------------------

    Summary: Fixes canonicaldb.json file. php json_decode can't process the json filed that doesn't have quotes.  (was: php json_decode can't process the json filed that doesn't have quotes.)

> Fixes canonicaldb.json file. php json_decode can't process the json filed that doesn't have quotes.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1025
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1025
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>    Affects Versions: trunk
>            Reporter: Jinhui Du
>            Priority: Minor
>             Fix For: trunk
>
>
> It only affect php not java implementation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-1025) Fixes canonicaldb.json file. php json_decode can't process the json filed that doesn't have quotes.

Posted by "Jinhui Du (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701130#action_12701130 ] 

Jinhui Du commented on SHINDIG-1025:
------------------------------------

Thanks for your quick replies. 
The content of /tmp/ShindigDb.json is written to null after the unittests are run.

The os is Linux 2.6 and the php version is 

$ php -v
PHP 5.2.9 (cli) (built: Feb 27 2009 14:53:43)
Copyright (c) 1997-2009 The PHP Group
Zend Engine v2.2.0, Copyright (c) 1998-2009 Zend Technologies
    with Zend Debugger v5.2.14, Copyright (c) 1999-2008, by Zend Technologies


> Fixes canonicaldb.json file. php json_decode can't process the json filed that doesn't have quotes.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1025
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1025
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>    Affects Versions: trunk
>            Reporter: Jinhui Du
>            Assignee: Chris Chabot
>            Priority: Minor
>             Fix For: trunk
>
>         Attachments: 20090421.patch
>
>
> It only affect php not java implementation.
> The url for code review: 
> http://codereview.appspot.com/40123/show

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-1025) Fixes canonicaldb.json file. php json_decode can't process the json filed that doesn't have quotes.

Posted by "Jinhui Du (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jinhui Du updated SHINDIG-1025:
-------------------------------

    Attachment: 20090421.patch

> Fixes canonicaldb.json file. php json_decode can't process the json filed that doesn't have quotes.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1025
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1025
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>    Affects Versions: trunk
>            Reporter: Jinhui Du
>            Assignee: Chris Chabot
>            Priority: Minor
>             Fix For: trunk
>
>         Attachments: 20090421.patch
>
>
> It only affect php not java implementation.
> The url for code review: 
> http://codereview.appspot.com/40123/show

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-1025) Fixes canonicaldb.json file. php json_decode can't process the json filed that doesn't have quotes.

Posted by "Jinhui Du (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jinhui Du updated SHINDIG-1025:
-------------------------------

    Description: 
It only affect php not java implementation.
The url for code review: 
http://codereview.appspot.com/40123/show

  was:It only affect php not java implementation.


> Fixes canonicaldb.json file. php json_decode can't process the json filed that doesn't have quotes.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1025
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1025
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>    Affects Versions: trunk
>            Reporter: Jinhui Du
>            Priority: Minor
>             Fix For: trunk
>
>
> It only affect php not java implementation.
> The url for code review: 
> http://codereview.appspot.com/40123/show

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.