You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2017/12/17 02:47:03 UTC

[GitHub] carbondata pull request #1666: [CARBONDATA-1900][Core,processing] Modify loa...

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1666#discussion_r157356451
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/statusmanager/LoadMetadataDetails.java ---
    @@ -241,26 +248,28 @@ private long convertTimeStampToLong(String factTimeStamp) {
        * @return
        */
       public Long getTimeStamp(String loadStartTime) {
    -    Date dateToStr = null;
         try {
    -      dateToStr = parser.parse(loadStartTime);
    -      return dateToStr.getTime() * 1000;
    -    } catch (ParseException e) {
    -      LOGGER.error("Cannot convert" + loadStartTime + " to Time/Long type value" + e.getMessage());
    -      return null;
    +      // for new loads the factTimeStamp will be long string
    --- End diff --
    
    In future for maintenance it is not easy to understand what new load is, can you add more background information for better maintenance.


---