[GitHub] [solr] madrob commented on a change in pull request #176: SOLR-15476: Facilitate 'shards.info' content customisation.

[GitBox <gi...@apache.org>]

madrob commented on a change in pull request #176:
URL: https://github.com/apache/solr/pull/176#discussion_r651120975



##########
File path: solr/core/src/java/org/apache/solr/handler/component/ResponseBuilder.java
##########
@@ -175,6 +177,26 @@ public void addRequest(SearchComponent me, ShardRequest sreq) {
     }
   }
 
+  public static abstract class ShardsInfoContainer implements BiConsumer<String,NamedList<Object>>, Supplier<Object> {

Review comment:
       interface v abstract class?
   
   I'd like to see some javadoc here too.

##########
File path: solr/core/src/java/org/apache/solr/handler/component/ResponseBuilder.java
##########
@@ -175,6 +177,26 @@ public void addRequest(SearchComponent me, ShardRequest sreq) {
     }
   }
 
+  public static abstract class ShardsInfoContainer implements BiConsumer<String,NamedList<Object>>, Supplier<Object> {
+  }
+
+  protected ShardsInfoContainer newShardsInfoContainer() {
+    return new ShardsInfoContainer() {

Review comment:
       could this be a concrete implementation?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org