You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/10/14 14:52:01 UTC
[GitHub] [trafficcontrol] mattjackson220 opened a new pull request #6282: Added SANs to Cert Page
mattjackson220 opened a new pull request #6282:
URL: https://github.com/apache/trafficcontrol/pull/6282
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
This PR adds the SANs information from a certificate to the `deliveryservices/xmlId/{xmlid}/sslkeys` endpoint in Traffic Ops and the certificate page in Traffic Portal
<!-- **^ Add meaningful description above** --><hr>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Documentation
- Traffic Ops
- Traffic Portal
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
Create a certificate that has SANs and add it to a delivery service (or use one that already exists)
Verify that on the certificate page in TP there is a field for the SANs and that it is filled in appropriately.
Verify that the `deliveryservices/xmlId/{xmlid}/sslkeys` endpoint returns the SANs for API version 4.1 but does not for any previous version
Verify that the TO tests pass
## If this is a bugfix, which Traffic Control versions contained the bug?
<!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch.
Examples:
- 5.1.2
- 5.1.3 (RC1)
-->
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #6282: Added SANs to Cert Page
Posted by GitBox <gi...@apache.org>.
rawlinp commented on a change in pull request #6282:
URL: https://github.com/apache/trafficcontrol/pull/6282#discussion_r730030223
##########
File path: traffic_ops/traffic_ops_golang/routing/routes.go
##########
@@ -130,6 +130,9 @@ func Routes(d ServerData) ([]Route, http.Handler, error) {
* 4.x API
*/
+ // SSL Keys
+ {api.Version{Major: 4, Minor: 1}, http.MethodGet, `deliveryservices/xmlId/{xmlid}/sslkeys$`, deliveryservice.GetSSLKeysByXMLID, auth.PrivLevelAdmin, nil, Authenticated, nil, 41357729074},
Review comment:
Since 4.0 is unstable, do we even need to add a 4.1 for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on pull request #6282: Added SANs to Cert Page
Posted by GitBox <gi...@apache.org>.
shamrickus commented on pull request #6282:
URL: https://github.com/apache/trafficcontrol/pull/6282#issuecomment-944326474
Also it looks like your rebase didn't pick up the #6284 fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #6282: Added SANs to Cert Page
Posted by GitBox <gi...@apache.org>.
shamrickus commented on a change in pull request #6282:
URL: https://github.com/apache/trafficcontrol/pull/6282#discussion_r729842117
##########
File path: lib/go-util/str.go
##########
@@ -49,6 +49,16 @@ func StrInArray(strs []string, s string) bool {
return false
}
+// RemoveStrFromArray removes a specific string from a string slice.
+func RemoveStrFromArray(strs []string, s string) []string {
+ for idx, str := range strs {
+ if str == s {
+ strs = append(strs[:idx], strs[idx+1:]...)
Review comment:
This modifies the array during iteration which causes a panic when `strs` contains a duplicate. It also modifies the passed in version of `strs` by replacing all instances of `s` with `strs[len(strs)-1]`
```
data := []string{"1", "2", "3", "4", "5", "end"}
log.Println(util.RemoveStrFromArray(data, "4"))
log.Println(data)
log.Println(util.RemoveStrFromArray(data, "end"))
```
```
2021/10/15 07:53:01 [1 2 3 5 end]
2021/10/15 07:53:01 [1 2 3 5 end end]
panic: runtime error: slice bounds out of range [6:5]
```
##########
File path: traffic_ops/traffic_ops_golang/routing/routes.go
##########
@@ -130,6 +130,9 @@ func Routes(d ServerData) ([]Route, http.Handler, error) {
* 4.x API
*/
+ // SSL Keys
+ {api.Version{Major: 4, Minor: 1}, http.MethodGet, `deliveryservices/xmlId/{xmlid}/sslkeys$`, deliveryservice.GetSSLKeysByXMLID, auth.PrivLevelAdmin, nil, Authenticated, nil, 41357729074},
Review comment:
That's a good point that I didn't consider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus merged pull request #6282: Added SANs to Cert Page
Posted by GitBox <gi...@apache.org>.
shamrickus merged pull request #6282:
URL: https://github.com/apache/trafficcontrol/pull/6282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org