You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "AlbumenJ (via GitHub)" <gi...@apache.org> on 2023/03/21 08:20:36 UTC

[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #11653: feat: change default mode

AlbumenJ commented on code in PR #11653:
URL: https://github.com/apache/dubbo/pull/11653#discussion_r1143016767


##########
dubbo-common/src/main/java/org/apache/dubbo/rpc/model/ModuleModel.java:
##########
@@ -48,7 +48,7 @@ public class ModuleModel extends ScopeModel {
     private volatile ModuleDeployer deployer;
     private boolean lifeCycleManagedExternally = false;
 
-    protected ModuleModel(ApplicationModel applicationModel) {
+    public ModuleModel(ApplicationModel applicationModel) {

Review Comment:
   revert



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org