You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/11/10 04:05:04 UTC

[GitHub] ascrutae edited a comment on issue #1892: Custom HystrixConcurrencyStrategy doesn't work when using hystrix plugin.

ascrutae edited a comment on issue #1892: Custom HystrixConcurrencyStrategy doesn't work when using hystrix plugin.
URL: https://github.com/apache/incubator-skywalking/issues/1892#issuecomment-437556403
 
 
   Why would there be  `Custom[SW[Default]]`  situation? What I understand is that Hystrix only set the one HystrixConcurrencyStrategy, and that is means the `registerConcurrencyStrategy` method executes before the `getConcurrencyStrategy` method or it will use the [default strategy](https://github.com/Netflix/Hystrix/blob/master/hystrix-core/src/main/java/com/netflix/hystrix/strategy/HystrixPlugins.java#L165),so  `HystrixPluginsInterceptor` wrap the return value of `getConcurrencyStrategy` method and it will get the right way.
   
   The Hystrix get `HystrixConcurrencyStrategy` by `getConcurrencyStrategy` method and clear `HystrixConcurrencyStrategy` by `reset` method, so Hystrix clear, we clear and Hystrix get, we put or get.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services