You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/20 18:50:26 UTC
[GitHub] [incubator-mxnet] szha opened a new pull request #18972: fix #18927
szha opened a new pull request #18972:
URL: https://github.com/apache/incubator-mxnet/pull/18972
## Description ##
fix #18927
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage:
- [x] Code is well-documented
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [x] fix #18927
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #18972: fix #18927
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #18972:
URL: https://github.com/apache/incubator-mxnet/pull/18972#discussion_r474200033
##########
File path: src/operator/contrib/bounding_box.cc
##########
@@ -37,6 +37,7 @@ DMLC_REGISTER_PARAMETER(BoxDecodeParam);
NNVM_REGISTER_OP(_contrib_box_nms)
.add_alias("_contrib_box_non_maximum_suppression")
+.add_alias("_npx_box_nms")
Review comment:
fyi @zhreshold I added these ops to npx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18972: fix #18927
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18972:
URL: https://github.com/apache/incubator-mxnet/pull/18972#issuecomment-677837101
Hey @szha , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-gpu, website, unix-cpu, sanity, windows-cpu, centos-gpu, clang, windows-gpu, edge, miscellaneous, centos-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #18972: fix #18927
Posted by GitBox <gi...@apache.org>.
szha merged pull request #18972:
URL: https://github.com/apache/incubator-mxnet/pull/18972
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org