You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2023/07/19 11:56:48 UTC
[camel] branch main updated: CAMEL-19447: camel-kafka
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new fca06c83e24 CAMEL-19447: camel-kafka
fca06c83e24 is described below
commit fca06c83e249d66606647b0eee0bf1dbb383a9fa
Author: Nikita Konovalov <nk...@redhat.com>
AuthorDate: Wed Jul 19 10:39:38 2023 +0200
CAMEL-19447: camel-kafka
- Fixed string concatenation
- Added final where possible
- Deleted unused throws
- Fixed grammar issues
---
.../camel/component/kafka/KafkaAutowireTest.java | 4 ++--
.../camel/component/kafka/KafkaComponentTest.java | 2 +-
.../camel/component/kafka/KafkaConsumerTest.java | 16 +++++++--------
.../camel/component/kafka/KafkaProducerTest.java | 24 +++++++++++-----------
.../component/kafka/MockConsumerInterceptor.java | 2 +-
.../component/kafka/MockProducerInterceptor.java | 2 +-
.../component/kafka/consumer/OffsetCacheTest.java | 2 +-
.../KafkaConsumerAsyncManualCommitIT.java | 4 ++--
.../kafka/integration/KafkaConsumerAuthIT.java | 2 +-
.../integration/KafkaConsumerAuthInvalidIT.java | 4 ++--
.../KafkaConsumerAuthInvalidWithReconnectIT.java | 2 +-
.../integration/KafkaConsumerAuthManualTest.java | 2 +-
.../kafka/integration/KafkaConsumerFullIT.java | 2 +-
.../KafkaConsumerIdempotentGroupIdIT.java | 4 ++--
.../integration/KafkaConsumerIdempotentIT.java | 4 ++--
...kaConsumerIdempotentWithCustomSerializerIT.java | 4 ++--
.../KafkaConsumerIdempotentWithProcessorIT.java | 4 ++--
.../integration/KafkaConsumerRebalanceIT.java | 6 +++---
.../kafka/integration/KafkaProducerFullIT.java | 4 ++--
.../kafka/integration/KafkaTransactionIT.java | 4 ++--
.../KafkaConsumerAsyncWithOffsetRepoCommitIT.java | 2 +-
.../KafkaConsumerSyncWithOffsetRepoCommitIT.java | 2 +-
.../KafkaPausableConsumerCircuitBreakerIT.java | 4 ++--
.../integration/pause/KafkaPausableConsumerIT.java | 6 +++---
.../serde/DefaultKafkaHeaderDeserializerTest.java | 2 +-
.../serde/DefaultKafkaHeaderSerializerTest.java | 2 +-
.../kafka/KafkaIdempotentRepositoryEagerIT.java | 2 +-
.../kafka/KafkaIdempotentRepositoryNonEagerIT.java | 2 +-
.../kafka/clients/producer/KafkaProducerTest.java | 2 +-
29 files changed, 61 insertions(+), 61 deletions(-)
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaAutowireTest.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaAutowireTest.java
index c629f7aaeb5..d96842acab9 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaAutowireTest.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaAutowireTest.java
@@ -30,10 +30,10 @@ public class KafkaAutowireTest {
@RegisterExtension
protected static CamelContextExtension contextExtension = new DefaultCamelContextExtension();
- private CamelContext context = contextExtension.getContext();
+ private final CamelContext context = contextExtension.getContext();
@BindToRegistry
- private KafkaClientFactory clientFactory = new TestKafkaClientFactory();
+ private final KafkaClientFactory clientFactory = new TestKafkaClientFactory();
@Test
public void testKafkaComponentAutowiring() {
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaComponentTest.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaComponentTest.java
index ec29f25cdef..cac43c6eb33 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaComponentTest.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaComponentTest.java
@@ -42,7 +42,7 @@ public class KafkaComponentTest {
@RegisterExtension
protected static CamelContextExtension contextExtension = new DefaultCamelContextExtension();
- private CamelContext context = contextExtension.getContext();
+ private final CamelContext context = contextExtension.getContext();
@AfterEach
void clear() {
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaConsumerTest.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaConsumerTest.java
index 152043826d9..58f95e07fda 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaConsumerTest.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaConsumerTest.java
@@ -30,14 +30,14 @@ import static org.mockito.Mockito.when;
public class KafkaConsumerTest {
- private KafkaConfiguration configuration = mock(KafkaConfiguration.class);
- private KafkaClientFactory clientFactory = mock(KafkaClientFactory.class);
- private KafkaComponent component = mock(KafkaComponent.class);
- private KafkaEndpoint endpoint = mock(KafkaEndpoint.class);
- private Processor processor = mock(Processor.class);
- private CamelContext context = mock(CamelContext.class);
- private ExtendedCamelContext ecc = mock(ExtendedCamelContext.class);
- private ExchangeFactory ef = mock(ExchangeFactory.class);
+ private final KafkaConfiguration configuration = mock(KafkaConfiguration.class);
+ private final KafkaClientFactory clientFactory = mock(KafkaClientFactory.class);
+ private final KafkaComponent component = mock(KafkaComponent.class);
+ private final KafkaEndpoint endpoint = mock(KafkaEndpoint.class);
+ private final Processor processor = mock(Processor.class);
+ private final CamelContext context = mock(CamelContext.class);
+ private final ExtendedCamelContext ecc = mock(ExtendedCamelContext.class);
+ private final ExchangeFactory ef = mock(ExchangeFactory.class);
@Test
public void consumerRequiresBootstrapServers() {
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaProducerTest.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaProducerTest.java
index 02271f772c7..6633e4b3a08 100755
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaProducerTest.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaProducerTest.java
@@ -63,16 +63,16 @@ public class KafkaProducerTest {
private static final String SOME_INDIVIDUAL_HEADER = "someIndividualHeader";
- private KafkaProducer producer;
- private KafkaEndpoint endpoint;
- private KafkaEndpoint fromEndpoint;
+ private final KafkaProducer producer;
+ private final KafkaEndpoint endpoint;
+ private final KafkaEndpoint fromEndpoint;
- private TypeConverter converter = Mockito.mock(TypeConverter.class);
- private CamelContext context = Mockito.mock(DefaultCamelContext.class);
- private Exchange exchange = Mockito.mock(Exchange.class);
- private ExtendedCamelContext ecc = Mockito.mock(ExtendedCamelContext.class);
- private Message in = new DefaultMessage(context);
- private AsyncCallback callback = Mockito.mock(AsyncCallback.class);
+ private final TypeConverter converter = Mockito.mock(TypeConverter.class);
+ private final CamelContext context = Mockito.mock(DefaultCamelContext.class);
+ private final Exchange exchange = Mockito.mock(Exchange.class);
+ private final ExtendedCamelContext ecc = Mockito.mock(ExtendedCamelContext.class);
+ private final Message in = new DefaultMessage(context);
+ private final AsyncCallback callback = Mockito.mock(AsyncCallback.class);
@SuppressWarnings({ "unchecked" })
public KafkaProducerTest() throws Exception {
@@ -133,7 +133,7 @@ public class KafkaProducerTest {
@SuppressWarnings({ "unchecked" })
public void processSendsMessageWithException() {
endpoint.getConfiguration().setTopic("sometopic");
- // setup the exception here
+ // set up the exception here
org.apache.kafka.clients.producer.Producer kp = producer.getKafkaProducer();
Mockito.when(kp.send(any(ProducerRecord.class))).thenThrow(new ApiException());
Mockito.when(exchange.getIn()).thenReturn(in);
@@ -167,7 +167,7 @@ public class KafkaProducerTest {
Mockito.when(exchange.getIn()).thenReturn(in);
Mockito.when(exchange.getMessage()).thenReturn(in);
- // setup the exception here
+ // set up the exception here
org.apache.kafka.clients.producer.Producer kp = producer.getKafkaProducer();
Mockito.when(kp.send(any(ProducerRecord.class), any(Callback.class))).thenThrow(new ApiException());
@@ -227,7 +227,7 @@ public class KafkaProducerTest {
in.setHeader(KafkaConstants.KEY, "someKey");
// test using a string value instead of long
- String time = "" + LocalDateTime.now().atZone(ZoneId.systemDefault()).toInstant().toEpochMilli();
+ String time = String.valueOf(LocalDateTime.now().atZone(ZoneId.systemDefault()).toInstant().toEpochMilli());
in.setHeader(KafkaConstants.OVERRIDE_TIMESTAMP, time);
producer.process(exchange);
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/MockConsumerInterceptor.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/MockConsumerInterceptor.java
index 4f6321463f7..f0131e0d865 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/MockConsumerInterceptor.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/MockConsumerInterceptor.java
@@ -27,7 +27,7 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
public class MockConsumerInterceptor implements ConsumerInterceptor<String, String> {
- public static ArrayList<ConsumerRecords<String, String>> recordsCaptured = new ArrayList<>();
+ public static final ArrayList<ConsumerRecords<String, String>> recordsCaptured = new ArrayList<>();
private static final Logger LOG = LoggerFactory.getLogger(MockConsumerInterceptor.class);
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/MockProducerInterceptor.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/MockProducerInterceptor.java
index 9a9b44d9a99..28f9cf789a8 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/MockProducerInterceptor.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/MockProducerInterceptor.java
@@ -25,7 +25,7 @@ import org.apache.kafka.clients.producer.RecordMetadata;
public class MockProducerInterceptor implements ProducerInterceptor<String, String> {
- public static ArrayList<ProducerRecord<String, String>> recordsCaptured = new ArrayList<>();
+ public static final ArrayList<ProducerRecord<String, String>> recordsCaptured = new ArrayList<>();
@Override
public ProducerRecord<String, String> onSend(ProducerRecord<String, String> producerRecord) {
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/consumer/OffsetCacheTest.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/consumer/OffsetCacheTest.java
index 0b515280869..edfc7eafda3 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/consumer/OffsetCacheTest.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/consumer/OffsetCacheTest.java
@@ -37,7 +37,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
class OffsetCacheTest {
- private OffsetCache offsetCache = new OffsetCache();
+ private final OffsetCache offsetCache = new OffsetCache();
@Order(1)
@Test
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerAsyncManualCommitIT.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerAsyncManualCommitIT.java
index a9b966bb961..080986fbc5f 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerAsyncManualCommitIT.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerAsyncManualCommitIT.java
@@ -53,9 +53,9 @@ public class KafkaConsumerAsyncManualCommitIT extends BaseEmbeddedKafkaTestSuppo
private static final Logger LOG = LoggerFactory.getLogger(KafkaConsumerAsyncManualCommitIT.class);
@BindToRegistry("testFactory")
- private KafkaManualCommitFactory manualCommitFactory = new DefaultKafkaManualAsyncCommitFactory();
+ private final KafkaManualCommitFactory manualCommitFactory = new DefaultKafkaManualAsyncCommitFactory();
- private CamelContext context = contextExtension.getContext();
+ private final CamelContext context = contextExtension.getContext();
private org.apache.kafka.clients.producer.KafkaProducer<String, String> producer;
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerAuthIT.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerAuthIT.java
index 2f7be92de1a..d1e386d54d5 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerAuthIT.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerAuthIT.java
@@ -147,7 +147,7 @@ public class KafkaConsumerAuthIT {
@Timeout(30)
@Order(1)
@Test
- public void kafkaMessageIsConsumedByCamel() throws InterruptedException, ExecutionException {
+ public void kafkaMessageIsConsumedByCamel() throws InterruptedException {
MockEndpoint to = contextExtension.getMockEndpoint(KafkaTestUtil.MOCK_RESULT);
String propagatedHeaderKey = "PropagatedCustomHeader";
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerAuthInvalidIT.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerAuthInvalidIT.java
index 7190d925b1f..7a8ed3ff5dd 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerAuthInvalidIT.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerAuthInvalidIT.java
@@ -75,10 +75,10 @@ public class KafkaConsumerAuthInvalidIT {
@Order(1)
@RegisterExtension
- private static KafkaService service = KafkaServiceFactory.createSingletonService();
+ private static final KafkaService service = KafkaServiceFactory.createSingletonService();
@Order(2)
@RegisterExtension
- private static CamelContextExtension contextExtension = new DefaultCamelContextExtension();
+ private static final CamelContextExtension contextExtension = new DefaultCamelContextExtension();
private org.apache.kafka.clients.producer.KafkaProducer<String, String> producer;
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerAuthInvalidWithReconnectIT.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerAuthInvalidWithReconnectIT.java
index 41911b4eaa3..8d287f30658 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerAuthInvalidWithReconnectIT.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerAuthInvalidWithReconnectIT.java
@@ -67,7 +67,7 @@ public class KafkaConsumerAuthInvalidWithReconnectIT {
private static ContainerLocalAuthKafkaService service;
@RegisterExtension
- private static CamelContextExtension contextExtension = new DefaultCamelContextExtension();
+ private static final CamelContextExtension contextExtension = new DefaultCamelContextExtension();
private org.apache.kafka.clients.producer.KafkaProducer<String, String> producer;
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerAuthManualTest.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerAuthManualTest.java
index 9cbdf003926..e93b6ba88bd 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerAuthManualTest.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerAuthManualTest.java
@@ -62,7 +62,7 @@ public class KafkaConsumerAuthManualTest {
private static final int MESSAGE_COUNT = Integer.valueOf(System.getProperty("kafka.manual.test.message.count", "5"));
@RegisterExtension
- private static CamelContextExtension contextExtension = new DefaultCamelContextExtension();
+ private static final CamelContextExtension contextExtension = new DefaultCamelContextExtension();
private static volatile int receivedMessages;
private org.apache.kafka.clients.producer.KafkaProducer<String, String> producer;
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerFullIT.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerFullIT.java
index 28e7b5895be..9571b7e035c 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerFullIT.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerFullIT.java
@@ -63,7 +63,7 @@ public class KafkaConsumerFullIT extends BaseEmbeddedKafkaTestSupport {
private org.apache.kafka.clients.producer.KafkaProducer<String, String> producer;
@BindToRegistry("myHeaderDeserializer")
- private MyKafkaHeaderDeserializer bean = new MyKafkaHeaderDeserializer();
+ private final MyKafkaHeaderDeserializer bean = new MyKafkaHeaderDeserializer();
@BeforeEach
public void before() {
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerIdempotentGroupIdIT.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerIdempotentGroupIdIT.java
index 7d3f7f16a8d..edd237cef27 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerIdempotentGroupIdIT.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerIdempotentGroupIdIT.java
@@ -36,10 +36,10 @@ public class KafkaConsumerIdempotentGroupIdIT extends KafkaConsumerIdempotentTes
public static final String TOPIC = "idempt";
- private int size = 200;
+ private final int size = 200;
@BindToRegistry("kafkaIdempotentRepository")
- private KafkaIdempotentRepository testIdempotent
+ private final KafkaIdempotentRepository testIdempotent
= new KafkaIdempotentRepository("TEST_IDEMPOTENT", getBootstrapServers(), "test_1");
@BeforeEach
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerIdempotentIT.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerIdempotentIT.java
index 568db9243f4..dc76acaf17f 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerIdempotentIT.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerIdempotentIT.java
@@ -41,10 +41,10 @@ public class KafkaConsumerIdempotentIT extends KafkaConsumerIdempotentTestSuppor
public static final String TOPIC = "idempt";
- private int size = 200;
+ private final int size = 200;
@BindToRegistry("kafkaIdempotentRepository")
- private KafkaIdempotentRepository testIdempotent = new KafkaIdempotentRepository("TEST_IDEMPOTENT", getBootstrapServers());
+ private final KafkaIdempotentRepository testIdempotent = new KafkaIdempotentRepository("TEST_IDEMPOTENT", getBootstrapServers());
@BeforeEach
public void before() {
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerIdempotentWithCustomSerializerIT.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerIdempotentWithCustomSerializerIT.java
index 66270b49ecc..e95d6f8066a 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerIdempotentWithCustomSerializerIT.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerIdempotentWithCustomSerializerIT.java
@@ -31,10 +31,10 @@ public class KafkaConsumerIdempotentWithCustomSerializerIT extends KafkaConsumer
public static final String TOPIC = "idempt2";
- private int size = 200;
+ private final int size = 200;
@BindToRegistry("kafkaIdempotentRepository")
- private KafkaIdempotentRepository kafkaIdempotentRepository
+ private final KafkaIdempotentRepository kafkaIdempotentRepository
= new KafkaIdempotentRepository("TEST_IDEMPOTENT", getBootstrapServers());
@BeforeEach
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerIdempotentWithProcessorIT.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerIdempotentWithProcessorIT.java
index 467996bb2e6..1c89b7ec7cf 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerIdempotentWithProcessorIT.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerIdempotentWithProcessorIT.java
@@ -31,9 +31,9 @@ import org.junit.jupiter.api.Test;
public class KafkaConsumerIdempotentWithProcessorIT extends KafkaConsumerIdempotentTestSupport {
public static final String TOPIC = "testidemp3";
- private int size = 200;
+ private final int size = 200;
@BindToRegistry("kafkaIdempotentRepository")
- private KafkaIdempotentRepository kafkaIdempotentRepository
+ private final KafkaIdempotentRepository kafkaIdempotentRepository
= new KafkaIdempotentRepository("TEST_IDEMPOTENT", getBootstrapServers());
@BeforeEach
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerRebalanceIT.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerRebalanceIT.java
index 0067981b6d4..f5ea58456ac 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerRebalanceIT.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaConsumerRebalanceIT.java
@@ -34,10 +34,10 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
public class KafkaConsumerRebalanceIT extends BaseEmbeddedKafkaTestSupport {
private static final String TOPIC = "offset-rebalance";
- private CountDownLatch messagesLatch = new CountDownLatch(1);
+ private final CountDownLatch messagesLatch = new CountDownLatch(1);
@BindToRegistry("offset")
- private OffsetStateRepository offsetStateRepository = new OffsetStateRepository(messagesLatch);
+ private final OffsetStateRepository offsetStateRepository = new OffsetStateRepository(messagesLatch);
@Test
public void offsetGetStateMustHaveBeenCalledTwice() throws Exception {
@@ -67,7 +67,7 @@ public class KafkaConsumerRebalanceIT extends BaseEmbeddedKafkaTestSupport {
public static class OffsetStateRepository implements StateRepository<String, String> {
private static final Logger LOG = LoggerFactory.getLogger(OffsetStateRepository.class);
- CountDownLatch messagesLatch;
+ final CountDownLatch messagesLatch;
public OffsetStateRepository(CountDownLatch messagesLatch) {
this.messagesLatch = messagesLatch;
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaProducerFullIT.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaProducerFullIT.java
index 504ae4e4bef..998b8f355b2 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaProducerFullIT.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaProducerFullIT.java
@@ -85,10 +85,10 @@ public class KafkaProducerFullIT extends BaseEmbeddedKafkaTestSupport {
private ProducerTemplate noRecordSpecificHeadersTemplate;
@BindToRegistry("myStrategy")
- private MyHeaderFilterStrategy headerFilterStrategy = new MyHeaderFilterStrategy();
+ private final MyHeaderFilterStrategy headerFilterStrategy = new MyHeaderFilterStrategy();
@BindToRegistry("myHeaderSerializer")
- private MyKafkaHeadersSerializer headersSerializer = new MyKafkaHeadersSerializer();
+ private final MyKafkaHeadersSerializer headersSerializer = new MyKafkaHeadersSerializer();
@BeforeAll
public static void before() {
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaTransactionIT.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaTransactionIT.java
index 68efdf8088e..f038dc0af85 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaTransactionIT.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaTransactionIT.java
@@ -71,14 +71,14 @@ public class KafkaTransactionIT extends BaseEmbeddedKafkaTestSupport {
protected RouteBuilder createRouteBuilder() {
return new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
from(SEQUENTIAL_TRANSACTION_URI).to("kafka:" + TOPIC_TRANSACTION + "?requestRequiredAcks=-1"
+ "&additional-properties[transactional.id]=1234"
+ "&additional-properties[enable.idempotence]=true"
+ "&additional-properties[retries]=5")
.process(new Processor() {
@Override
- public void process(Exchange exchange) throws Exception {
+ public void process(Exchange exchange) {
String body = exchange.getIn().getBody(String.class);
if (body.contains("fail")) {
throw new RuntimeException("fail process message " + body);
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/commit/KafkaConsumerAsyncWithOffsetRepoCommitIT.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/commit/KafkaConsumerAsyncWithOffsetRepoCommitIT.java
index d711fa916f8..36fecc03aab 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/commit/KafkaConsumerAsyncWithOffsetRepoCommitIT.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/commit/KafkaConsumerAsyncWithOffsetRepoCommitIT.java
@@ -33,7 +33,7 @@ public class KafkaConsumerAsyncWithOffsetRepoCommitIT extends BaseManualCommitTe
public static final String TOPIC = "testAsyncCommitWithOffsetRepoTest";
@BindToRegistry("stateRepository")
- private static MemoryStateRepository stateRepository = new MemoryStateRepository();
+ private static final MemoryStateRepository stateRepository = new MemoryStateRepository();
@AfterEach
public void after() {
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/commit/KafkaConsumerSyncWithOffsetRepoCommitIT.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/commit/KafkaConsumerSyncWithOffsetRepoCommitIT.java
index e6f02495ed5..8e8842d1327 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/commit/KafkaConsumerSyncWithOffsetRepoCommitIT.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/commit/KafkaConsumerSyncWithOffsetRepoCommitIT.java
@@ -33,7 +33,7 @@ class KafkaConsumerSyncWithOffsetRepoCommitIT extends BaseManualCommitTestSuppor
public static final String TOPIC = "testManualCommitSyncWithOffsetRepoTest";
@BindToRegistry("stateRepository")
- private static MemoryStateRepository stateRepository = new MemoryStateRepository();
+ private static final MemoryStateRepository stateRepository = new MemoryStateRepository();
@AfterEach
public void after() {
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/pause/KafkaPausableConsumerCircuitBreakerIT.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/pause/KafkaPausableConsumerCircuitBreakerIT.java
index a34869b258c..42faf368b8b 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/pause/KafkaPausableConsumerCircuitBreakerIT.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/pause/KafkaPausableConsumerCircuitBreakerIT.java
@@ -57,12 +57,12 @@ public class KafkaPausableConsumerCircuitBreakerIT extends BaseEmbeddedKafkaTest
private static final Logger LOG = LoggerFactory.getLogger(KafkaPausableConsumerCircuitBreakerIT.class);
private static final int SIMULATED_FAILURES = 5;
- private static LongAdder count = new LongAdder();
+ private static final LongAdder count = new LongAdder();
private static ScheduledExecutorService executorService;
private org.apache.kafka.clients.producer.KafkaProducer<String, String> producer;
/*
- * This is used by pausable to determine whether or not to pause. If returning true, processing continues. If
+ * This is used by pausable to determine whether to pause. If returning true, processing continues. If
* returning false, processing pauses.
*/
private static boolean canContinue() {
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/pause/KafkaPausableConsumerIT.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/pause/KafkaPausableConsumerIT.java
index 1cc0e8d5952..f84f6cdf9bb 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/pause/KafkaPausableConsumerIT.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/pause/KafkaPausableConsumerIT.java
@@ -55,11 +55,11 @@ public class KafkaPausableConsumerIT extends BaseEmbeddedKafkaTestSupport {
public static final String SOURCE_TOPIC = "pause-source";
private static final Logger LOG = LoggerFactory.getLogger(KafkaPausableConsumerIT.class);
private static final int RETRY_COUNT = 10;
- private static LongAdder count = new LongAdder();
- private static TestListener testConsumerListener = new TestListener();
+ private static final LongAdder count = new LongAdder();
+ private static final TestListener testConsumerListener = new TestListener();
private org.apache.kafka.clients.producer.KafkaProducer<String, String> producer;
- private ScheduledExecutorService executorService = Executors.newSingleThreadScheduledExecutor();
+ private final ScheduledExecutorService executorService = Executors.newSingleThreadScheduledExecutor();
private static boolean canContinue() {
// First one should go through ...
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/serde/DefaultKafkaHeaderDeserializerTest.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/serde/DefaultKafkaHeaderDeserializerTest.java
index 46cddc7a303..87ea012ce65 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/serde/DefaultKafkaHeaderDeserializerTest.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/serde/DefaultKafkaHeaderDeserializerTest.java
@@ -24,7 +24,7 @@ import static org.junit.jupiter.api.Assertions.assertArrayEquals;
public class DefaultKafkaHeaderDeserializerTest {
- private KafkaHeaderDeserializer deserializer = new DefaultKafkaHeaderDeserializer();
+ private final KafkaHeaderDeserializer deserializer = new DefaultKafkaHeaderDeserializer();
@Test
public void shouldDeserializeAsIs() {
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/serde/DefaultKafkaHeaderSerializerTest.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/serde/DefaultKafkaHeaderSerializerTest.java
index 9cfe65dc42f..a897e7a4ddf 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/serde/DefaultKafkaHeaderSerializerTest.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/serde/DefaultKafkaHeaderSerializerTest.java
@@ -28,7 +28,7 @@ import static org.junit.jupiter.api.Assertions.assertArrayEquals;
public class DefaultKafkaHeaderSerializerTest {
- private DefaultKafkaHeaderSerializer serializer = new DefaultKafkaHeaderSerializer();
+ private final DefaultKafkaHeaderSerializer serializer = new DefaultKafkaHeaderSerializer();
@ParameterizedTest
@MethodSource("primeNumbers")
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/processor/idempotent/kafka/KafkaIdempotentRepositoryEagerIT.java b/components/camel-kafka/src/test/java/org/apache/camel/processor/idempotent/kafka/KafkaIdempotentRepositoryEagerIT.java
index fd2584c417f..b08ef00b21f 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/processor/idempotent/kafka/KafkaIdempotentRepositoryEagerIT.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/processor/idempotent/kafka/KafkaIdempotentRepositoryEagerIT.java
@@ -33,7 +33,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
public class KafkaIdempotentRepositoryEagerIT extends SimpleIdempotentTest {
@BindToRegistry("kafkaIdempotentRepositoryEager")
- private KafkaIdempotentRepository idempotentRepository
+ private final KafkaIdempotentRepository idempotentRepository
= new KafkaIdempotentRepository("TEST_EAGER_" + UUID.randomUUID(), service.getBootstrapServers());
@Override
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/processor/idempotent/kafka/KafkaIdempotentRepositoryNonEagerIT.java b/components/camel-kafka/src/test/java/org/apache/camel/processor/idempotent/kafka/KafkaIdempotentRepositoryNonEagerIT.java
index d18ab8ef9e3..176438a39cc 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/processor/idempotent/kafka/KafkaIdempotentRepositoryNonEagerIT.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/processor/idempotent/kafka/KafkaIdempotentRepositoryNonEagerIT.java
@@ -43,7 +43,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
public class KafkaIdempotentRepositoryNonEagerIT extends SimpleIdempotentTest {
@BindToRegistry("kafkaIdempotentRepositoryNonEager")
- private KafkaIdempotentRepository kafkaIdempotentRepository
+ private final KafkaIdempotentRepository kafkaIdempotentRepository
= new KafkaIdempotentRepository("TEST_NON_EAGER_" + UUID.randomUUID(), service.getBootstrapServers());
@ContextFixture
diff --git a/components/camel-kafka/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java b/components/camel-kafka/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java
index e21d631e40b..7eadfa4c5a7 100644
--- a/components/camel-kafka/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java
+++ b/components/camel-kafka/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java
@@ -41,7 +41,7 @@ import static org.mockito.Mockito.when;
@ExtendWith(MockitoExtension.class)
public class KafkaProducerTest {
- private MockProducer kafkaProducer = new MockProducer<>(true, new StringSerializer(), new StringSerializer());
+ private final MockProducer kafkaProducer = new MockProducer<>(true, new StringSerializer(), new StringSerializer());
private KafkaProducer camelProducer;
@Spy
private Exchange exchange;