You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Kyle Weaver (Jira)" <ji...@apache.org> on 2020/01/16 01:38:00 UTC
[jira] [Commented] (BEAM-8047) Handle overflow when converting from
millis to micros
[ https://issues.apache.org/jira/browse/BEAM-8047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016451#comment-17016451 ]
Kyle Weaver commented on BEAM-8047:
-----------------------------------
I see we are using checkedMultiply now. Is this resolved?
https://github.com/apache/beam/blob/8915d6e95c405aeee0f29152545d3210e8e09f1f/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/DateTimeUtils.java#L196
> Handle overflow when converting from millis to micros
> -----------------------------------------------------
>
> Key: BEAM-8047
> URL: https://issues.apache.org/jira/browse/BEAM-8047
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql-zetasql
> Reporter: Rui Wang
> Priority: Major
>
> When converting from Joda Instant/Datetime, what can be gotten is epoch millis, but conversions require epoch micros, so * 1000L is applied, but it definitely has overflow issue and need to be handle appropriately.
> This issue exists in zetasql planner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)