You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/03/09 06:53:31 UTC
[GitHub] [phoenix] dbwong opened a new pull request #726: Phoenix 5760 Pherf
Support Sequential Datatypes for INTEGER type fields and have fixed row
distribution
dbwong opened a new pull request #726: Phoenix 5760 Pherf Support Sequential Datatypes for INTEGER type fields and have fixed row distribution
URL: https://github.com/apache/phoenix/pull/726
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] yanxinyi commented on a change in pull request #726:
Phoenix-5760 Pherf Support Sequential Datatypes for INTEGER type fields and
have fixed row distribution
Posted by GitBox <gi...@apache.org>.
yanxinyi commented on a change in pull request #726: Phoenix-5760 Pherf Support Sequential Datatypes for INTEGER type fields and have fixed row distribution
URL: https://github.com/apache/phoenix/pull/726#discussion_r389919845
##########
File path: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/rules/RulesApplier.java
##########
@@ -57,6 +57,8 @@
private String cachedScenarioOverrideName;
private Map<DataTypeMapping, List> scenarioOverrideMap;
+ private Map<Column,RuleBasedDataGenerator> columnRuleBasedDataGeneratorMap = new HashMap<>();
Review comment:
Do we only consider sequential integer here? What about other scenarios?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] mihir6692 commented on a change in pull request #726:
Phoenix-5760 Pherf Support Sequential Datatypes for INTEGER type fields and
have fixed row distribution
Posted by GitBox <gi...@apache.org>.
mihir6692 commented on a change in pull request #726: Phoenix-5760 Pherf Support Sequential Datatypes for INTEGER type fields and have fixed row distribution
URL: https://github.com/apache/phoenix/pull/726#discussion_r389683565
##########
File path: phoenix-pherf/src/test/java/org/apache/phoenix/pherf/RuleGeneratorTest.java
##########
@@ -175,7 +175,26 @@ public void testSequentialDataSequence() throws Exception {
Column targetColumn = null;
for (Column column : model.getDataMappingColumns()) {
DataSequence sequence = column.getDataSequence();
- if (sequence == DataSequence.SEQUENTIAL) {
+ if (!DataTypeMapping.INTEGER.equals(column.getType()) && sequence == DataSequence.SEQUENTIAL) {
+ targetColumn = column;
+ break;
+ }
+ }
+ assertNotNull("Could not find a DataSequence.SEQENTIAL rule.", targetColumn);
+ assertMultiThreadedIncrementValue(targetColumn, rulesApplier);
+ }
+
+ @Test
+ public void :testSequentialIntegerDataSequence() throws Exception {
Review comment:
extra ":" , this won't compile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] dbwong commented on a change in pull request #726:
Phoenix-5760 Pherf Support Sequential Datatypes for INTEGER type fields and
have fixed row distribution
Posted by GitBox <gi...@apache.org>.
dbwong commented on a change in pull request #726: Phoenix-5760 Pherf Support Sequential Datatypes for INTEGER type fields and have fixed row distribution
URL: https://github.com/apache/phoenix/pull/726#discussion_r389898614
##########
File path: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/rules/SequentialIntegerDataGenerator.java
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.phoenix.pherf.rules;
+
+import com.google.common.base.Preconditions;
+import org.apache.phoenix.pherf.configuration.Column;
+import org.apache.phoenix.pherf.configuration.DataSequence;
+import org.apache.phoenix.pherf.configuration.DataTypeMapping;
+
+import java.util.concurrent.atomic.AtomicLong;
+
+public class SequentialIntegerDataGenerator implements RuleBasedDataGenerator {
+ private final Column columnRule;
+ private final AtomicLong counter;
+ private final long minValue;
+ private final long maxValue;
+
+ SequentialIntegerDataGenerator(Column columnRule) {
Review comment:
Sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] mihir6692 commented on a change in pull request #726:
Phoenix-5760 Pherf Support Sequential Datatypes for INTEGER type fields and
have fixed row distribution
Posted by GitBox <gi...@apache.org>.
mihir6692 commented on a change in pull request #726: Phoenix-5760 Pherf Support Sequential Datatypes for INTEGER type fields and have fixed row distribution
URL: https://github.com/apache/phoenix/pull/726#discussion_r389683024
##########
File path: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/rules/SequentialIntegerDataGenerator.java
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.phoenix.pherf.rules;
+
+import com.google.common.base.Preconditions;
+import org.apache.phoenix.pherf.configuration.Column;
+import org.apache.phoenix.pherf.configuration.DataSequence;
+import org.apache.phoenix.pherf.configuration.DataTypeMapping;
+
+import java.util.concurrent.atomic.AtomicLong;
+
+public class SequentialIntegerDataGenerator implements RuleBasedDataGenerator {
+ private final Column columnRule;
+ private final AtomicLong counter;
+ private final long minValue;
+ private final long maxValue;
+
+ SequentialIntegerDataGenerator(Column columnRule) {
Review comment:
Do you want to make this Class only package visible? It's better to declare it pubic instead of package private with default access modifies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] yanxinyi commented on a change in pull request #726:
Phoenix-5760 Pherf Support Sequential Datatypes for INTEGER type fields and
have fixed row distribution
Posted by GitBox <gi...@apache.org>.
yanxinyi commented on a change in pull request #726: Phoenix-5760 Pherf Support Sequential Datatypes for INTEGER type fields and have fixed row distribution
URL: https://github.com/apache/phoenix/pull/726#discussion_r389919845
##########
File path: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/rules/RulesApplier.java
##########
@@ -57,6 +57,8 @@
private String cachedScenarioOverrideName;
private Map<DataTypeMapping, List> scenarioOverrideMap;
+ private Map<Column,RuleBasedDataGenerator> columnRuleBasedDataGeneratorMap = new HashMap<>();
Review comment:
Do we only consider INTEGER here? What about other types?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] dbwong commented on issue #726: Phoenix-5760 Pherf
Support Sequential Datatypes for INTEGER type fields and have fixed row
distribution
Posted by GitBox <gi...@apache.org>.
dbwong commented on issue #726: Phoenix-5760 Pherf Support Sequential Datatypes for INTEGER type fields and have fixed row distribution
URL: https://github.com/apache/phoenix/pull/726#issuecomment-596363235
Please review @yanxinyi @ChinmaySKulkarni
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] dbwong commented on a change in pull request #726:
Phoenix-5760 Pherf Support Sequential Datatypes for INTEGER type fields and
have fixed row distribution
Posted by GitBox <gi...@apache.org>.
dbwong commented on a change in pull request #726: Phoenix-5760 Pherf Support Sequential Datatypes for INTEGER type fields and have fixed row distribution
URL: https://github.com/apache/phoenix/pull/726#discussion_r389898550
##########
File path: phoenix-pherf/src/test/java/org/apache/phoenix/pherf/RuleGeneratorTest.java
##########
@@ -175,7 +175,26 @@ public void testSequentialDataSequence() throws Exception {
Column targetColumn = null;
for (Column column : model.getDataMappingColumns()) {
DataSequence sequence = column.getDataSequence();
- if (sequence == DataSequence.SEQUENTIAL) {
+ if (!DataTypeMapping.INTEGER.equals(column.getType()) && sequence == DataSequence.SEQUENTIAL) {
+ targetColumn = column;
+ break;
+ }
+ }
+ assertNotNull("Could not find a DataSequence.SEQENTIAL rule.", targetColumn);
+ assertMultiThreadedIncrementValue(targetColumn, rulesApplier);
+ }
+
+ @Test
+ public void :testSequentialIntegerDataSequence() throws Exception {
Review comment:
Think this was accidental after realizing i had another commit on this branch during cleanup. I'll fix and submit hadoopQA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services