You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/16 01:51:51 UTC

[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #11953: Fix alert_send_status may throw duplicate key exception and add limit for query alert

kezhenxu94 commented on code in PR #11953:
URL: https://github.com/apache/dolphinscheduler/pull/11953#discussion_r972542546


##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AlertSendStatus.java:
##########
@@ -69,20 +74,4 @@ public class AlertSendStatus {
     @TableField("create_time")
     private Date createTime;
 
-    @Override

Review Comment:
   Notice the `equals` method generated by `@Data` is not equivalent to this one, that's why I didn't remove this method, to have the equivalent effect after removing this `equals` method, you need to add `@EqualsAndHashCode.Include` to fields `alertId` and `alertPluginInstanceId`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org