You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2008/08/20 02:36:44 UTC
[jira] Created: (THRIFT-114) Isset structure when not using
javabeans generator is completely useless
Isset structure when not using javabeans generator is completely useless
------------------------------------------------------------------------
Key: THRIFT-114
URL: https://issues.apache.org/jira/browse/THRIFT-114
Project: Thrift
Issue Type: Improvement
Reporter: Bryan Duxbury
Priority: Minor
If you're not using the javabeans generator, then interactions with __isset are completely unnecessary. The only time they are set is in the constructor, and they are only checked in the .equals method. It seems like code generated without javabeans should just omit this structure (and the attendant code) completely.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-114) Isset structure when not using
javabeans generator is completely useless
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623883#action_12623883 ]
David Reiss commented on THRIFT-114:
------------------------------------
Um, sure.
> Isset structure when not using javabeans generator is completely useless
> ------------------------------------------------------------------------
>
> Key: THRIFT-114
> URL: https://issues.apache.org/jira/browse/THRIFT-114
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Priority: Minor
>
> If you're not using the javabeans generator, then interactions with __isset are completely unnecessary. The only time they are set is in the constructor, and they are only checked in the .equals method. It seems like code generated without javabeans should just omit this structure (and the attendant code) completely.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-114) Isset structure when not using
javabeans generator is completely useless
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss resolved THRIFT-114.
--------------------------------
Resolution: Invalid
They get set to true by the reader methods to let you know what fields were present.
Please open separate tickets if you want to discuss any of the following.
1/ Unlike in C++, __isset is not respected when writing optional fields.
2/ It is obvious when a non-primitive type was not set.
3/ There is no way to save memory be eliminating __isset when you know you won't need it.
> Isset structure when not using javabeans generator is completely useless
> ------------------------------------------------------------------------
>
> Key: THRIFT-114
> URL: https://issues.apache.org/jira/browse/THRIFT-114
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Priority: Minor
>
> If you're not using the javabeans generator, then interactions with __isset are completely unnecessary. The only time they are set is in the constructor, and they are only checked in the .equals method. It seems like code generated without javabeans should just omit this structure (and the attendant code) completely.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-114) Isset structure when not using
javabeans generator is completely useless
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623881#action_12623881 ]
Bryan Duxbury commented on THRIFT-114:
--------------------------------------
bq. 1/ Unlike in C++, __isset is not respected when writing optional fields.
THRIFT-33
bq. 2/ It is obvious when a non-primitive type was not set.
THRIFT-116
bq. 3/ There is no way to save memory be eliminating __isset when you know you won't need it.
Are you suggesting that there should/could be an option for turning off isset if you don't require it?
> Isset structure when not using javabeans generator is completely useless
> ------------------------------------------------------------------------
>
> Key: THRIFT-114
> URL: https://issues.apache.org/jira/browse/THRIFT-114
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Priority: Minor
>
> If you're not using the javabeans generator, then interactions with __isset are completely unnecessary. The only time they are set is in the constructor, and they are only checked in the .equals method. It seems like code generated without javabeans should just omit this structure (and the attendant code) completely.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-114) Isset structure when not using
javabeans generator is completely useless
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-114:
---------------------------------
Component/s: Compiler (Java)
> Isset structure when not using javabeans generator is completely useless
> ------------------------------------------------------------------------
>
> Key: THRIFT-114
> URL: https://issues.apache.org/jira/browse/THRIFT-114
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Priority: Minor
>
> If you're not using the javabeans generator, then interactions with __isset are completely unnecessary. The only time they are set is in the constructor, and they are only checked in the .equals method. It seems like code generated without javabeans should just omit this structure (and the attendant code) completely.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.