You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "xtern (via GitHub)" <gi...@apache.org> on 2025/07/16 13:25:50 UTC
[PR] IGNITE-25716 [ignite-3]
xtern opened a new pull request, #6261:
URL: https://github.com/apache/ignite-3/pull/6261
https://issues.apache.org/jira/browse/IGNITE-25716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25716 [ignite-3]
Posted by "xtern (via GitHub)" <gi...@apache.org>.
xtern closed pull request #6261: IGNITE-25716
URL: https://github.com/apache/ignite-3/pull/6261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25716 [ignite-3]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #6261:
URL: https://github.com/apache/ignite-3/pull/6261#discussion_r2212270242
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/datatypes/BaseTypeCoercionTest.java:
##########
@@ -764,6 +766,9 @@ private static boolean matchCall(RexCall call, Matcher<RexNode> first, Matcher<R
boolean op1Matches = first.matches(op1);
boolean op2Matches = second.matches(op2);
+ System.out.println("op1Matches: " + op1Matches + " " + op1.getType());
+ System.out.println("op2Matches: " + op2Matches + " " + op1.getType());
Review Comment:
Debug print statements should be removed before merging to production. These appear to be temporary debugging code that was left in.
```suggestion
// Debugging output removed.
// Debugging output removed.
```
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/datatypes/BaseTypeCoercionTest.java:
##########
@@ -741,7 +741,9 @@ Predicate<IgniteTableScan> checkPlan(
RexCall call1 = (RexCall) operands.get(0);
RexCall call2 = (RexCall) operands.get(1);
+ System.out.println("first");
boolean firstOp = matchCall(call1, call1op1, call1op2);
+ System.out.println("second");
Review Comment:
Debug print statements should be removed before merging to production. These appear to be temporary debugging code that was left in.
```suggestion
boolean firstOp = matchCall(call1, call1op1, call1op2);
```
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/datatypes/BaseTypeCoercionTest.java:
##########
@@ -764,6 +766,9 @@ private static boolean matchCall(RexCall call, Matcher<RexNode> first, Matcher<R
boolean op1Matches = first.matches(op1);
boolean op2Matches = second.matches(op2);
+ System.out.println("op1Matches: " + op1Matches + " " + op1.getType());
+ System.out.println("op2Matches: " + op2Matches + " " + op1.getType());
Review Comment:
The debug print statement displays op1.getType() for both op1 and op2. It should display op2.getType() for the second operand.
```suggestion
System.out.println("op2Matches: " + op2Matches + " " + op2.getType());
```
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/datatypes/BaseTypeCoercionTest.java:
##########
@@ -741,7 +741,9 @@ Predicate<IgniteTableScan> checkPlan(
RexCall call1 = (RexCall) operands.get(0);
RexCall call2 = (RexCall) operands.get(1);
+ System.out.println("first");
boolean firstOp = matchCall(call1, call1op1, call1op2);
+ System.out.println("second");
Review Comment:
Debug print statements should be removed before merging to production. These appear to be temporary debugging code that was left in.
```suggestion
boolean firstOp = matchCall(call1, call1op1, call1op2);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org