You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/01 06:35:28 UTC

[GitHub] [beam] iemejia opened a new pull request #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8

iemejia opened a new pull request #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8
URL: https://github.com/apache/beam/pull/11009
 
 
   R: @kennknowles  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] iemejia removed a comment on issue #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8

Posted by GitBox <gi...@apache.org>.
iemejia removed a comment on issue #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8
URL: https://github.com/apache/beam/pull/11009#issuecomment-593304689
 
 
   Run Java PreCommit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] iemejia commented on issue #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8

Posted by GitBox <gi...@apache.org>.
iemejia commented on issue #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8
URL: https://github.com/apache/beam/pull/11009#issuecomment-593276401
 
 
   Rebased to catch with the fix for the formatting error #11010

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] iemejia commented on a change in pull request #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8

Posted by GitBox <gi...@apache.org>.
iemejia commented on a change in pull request #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8
URL: https://github.com/apache/beam/pull/11009#discussion_r386081545
 
 

 ##########
 File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
 ##########
 @@ -514,9 +514,7 @@ public void proccessElement(ProcessContext c) {}
       SingleOutput<KV<String, String>, String> parDo = ParDo.of(fn);
 
       // Use the parDo in a pipeline to cause state coders to be inferred.
-      pipeline
-          .apply(Create.of(KV.of("input", "value")))
-          .apply(parDo);
+      pipeline.apply(Create.of(KV.of("input", "value"))).apply(parDo);
 
 Review comment:
   changes in this class are unrelated but auto applied by `spotlessApply`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] iemejia commented on issue #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8

Posted by GitBox <gi...@apache.org>.
iemejia commented on issue #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8
URL: https://github.com/apache/beam/pull/11009#issuecomment-593304689
 
 
   Run Java PreCommit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] lukecwik commented on issue #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8

Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8
URL: https://github.com/apache/beam/pull/11009#issuecomment-593209029
 
 
   Run Go PreCommit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] lukecwik commented on issue #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8

Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8
URL: https://github.com/apache/beam/pull/11009#issuecomment-593208979
 
 
   Run Python PreCommit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] iemejia commented on a change in pull request #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8

Posted by GitBox <gi...@apache.org>.
iemejia commented on a change in pull request #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8
URL: https://github.com/apache/beam/pull/11009#discussion_r386081545
 
 

 ##########
 File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
 ##########
 @@ -514,9 +514,7 @@ public void proccessElement(ProcessContext c) {}
       SingleOutput<KV<String, String>, String> parDo = ParDo.of(fn);
 
       // Use the parDo in a pipeline to cause state coders to be inferred.
-      pipeline
-          .apply(Create.of(KV.of("input", "value")))
-          .apply(parDo);
+      pipeline.apply(Create.of(KV.of("input", "value"))).apply(parDo);
 
 Review comment:
   changes in this class are unrelated but auto applied by `spotlessApply`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] iemejia commented on issue #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8

Posted by GitBox <gi...@apache.org>.
iemejia commented on issue #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8
URL: https://github.com/apache/beam/pull/11009#issuecomment-593357270
 
 
   Merging eagerly, the python error is unrelated to this PR and related to some missing import on Gcp related tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] lukecwik commented on issue #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8

Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8
URL: https://github.com/apache/beam/pull/11009#issuecomment-593209006
 
 
   Run Portable_Python PreCommit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] iemejia merged pull request #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8

Posted by GitBox <gi...@apache.org>.
iemejia merged pull request #11009: [BEAM-9342[ Update bytebuddy to version 1.10.8
URL: https://github.com/apache/beam/pull/11009
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services