You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/05/19 21:49:46 UTC
[GitHub] [arrow] kou commented on a diff in pull request #35561: GH-35558: [MATLAB] Add signed integer array MATLAB classes (i.e. `Int8Array`, `Int16Array`, `Int32Array`, `Int64Array`)
kou commented on code in PR #35561:
URL: https://github.com/apache/arrow/pull/35561#discussion_r1199436087
##########
matlab/src/cpp/arrow/matlab/proxy/factory.cc:
##########
@@ -28,6 +28,10 @@ std::shared_ptr<Proxy> Factory::make_proxy(const ClassName& class_name, const Fu
// Register MATLAB Proxy classes with corresponding C++ Proxy classes.
REGISTER_PROXY(arrow.array.proxy.Float32Array, arrow::matlab::array::proxy::NumericArray<float>);
REGISTER_PROXY(arrow.array.proxy.Float64Array, arrow::matlab::array::proxy::NumericArray<double>);
+ REGISTER_PROXY(arrow.array.proxy.Int8Array, arrow::matlab::array::proxy::NumericArray<int8_t>);
+ REGISTER_PROXY(arrow.array.proxy.Int16Array, arrow::matlab::array::proxy::NumericArray<int16_t>);
+ REGISTER_PROXY(arrow.array.proxy.Int32Array, arrow::matlab::array::proxy::NumericArray<int32_t>);
+ REGISTER_PROXY(arrow.array.proxy.Int64Array, arrow::matlab::array::proxy::NumericArray<int64_t>);
Review Comment:
We may want to use the same style with `UInt*`:
https://github.com/apache/arrow/blob/4129fe1a3e6fca1ab46d9f59a914110f58ec94c6/matlab/src/cpp/arrow/matlab/proxy/factory.cc#L28-L32
Or we may want to put all `REGISTER_PROXY()` to here:
```cpp
// Register MATLAB Proxy classes with corresponding C++ Proxy classes.
REGISTER_PROXY(arrow.array.proxy.Float32Array, arrow::matlab::array::proxy::NumericArray<float>);
REGISTER_PROXY(arrow.array.proxy.Float64Array, arrow::matlab::array::proxy::NumericArray<double>);
REGISTER_PROXY(arrow.array.proxy.Int8Array, arrow::matlab::array::proxy::NumericArray<int8_t>);
REGISTER_PROXY(arrow.array.proxy.Int16Array, arrow::matlab::array::proxy::NumericArray<int16_t>);
REGISTER_PROXY(arrow.array.proxy.Int32Array, arrow::matlab::array::proxy::NumericArray<int32_t>);
REGISTER_PROXY(arrow.array.proxy.Int64Array, arrow::matlab::array::proxy::NumericArray<int64_t>);
REGISTER_PROXY(arrow.array.proxy.UInt8Array, arrow::matlab::array::proxy::NumericArray<uint8_t>);
REGISTER_PROXY(arrow.array.proxy.UInt16Array, arrow::matlab::array::proxy::NumericArray<uint16_t>);
REGISTER_PROXY(arrow.array.proxy.UInt32Array, arrow::matlab::array::proxy::NumericArray<uint32_t>);
REGISTER_PROXY(arrow.array.proxy.UInt64Array, arrow::matlab::array::proxy::NumericArray<uint64_t>);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org