You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/08/06 05:57:20 UTC

[GitHub] [incubator-echarts] easonyq commented on a change in pull request #13084: fix(bar): showBackground bug when update with no previous background elements

easonyq commented on a change in pull request #13084:
URL: https://github.com/apache/incubator-echarts/pull/13084#discussion_r466163292



##########
File path: src/chart/bar/BarView.js
##########
@@ -135,20 +135,25 @@ export default echarts.extendChartView({
         var bgEls = [];
         var oldBgEls = this._backgroundEls || [];
 
+        var createBackground = dataIndex => {

Review comment:
       Already changed to normal function in commit 2




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org