You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/06/03 18:00:23 UTC

[GitHub] [incubator-pinot] fx19880617 commented on pull request #5438: Add additional datetime functionality

fx19880617 commented on pull request #5438:
URL: https://github.com/apache/incubator-pinot/pull/5438#issuecomment-638364905


   Overall lgtm, could you also add some integration tests for this.
   
   Also for the null primitive arguments functions, do we expect them to be only in nested functions? like `SELECT timezone_hour(timezone('UTC')) from myTable`
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org